Advertisement

08.26.2008 at 12:15PM PDT, ID: 23679747
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
9.8

PHP Code-A Better Way

Asked by IT79637 in PHP and Databases

Tags: ,

I have some very ugly php code.  It does transaction processing on a mysql database.  There are multiple INSERTs and UPDATEs which must be successful as a unit.

Can someone please suggest a better way of doing this?Start Free Trial 
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:

$sqlSuccess = "Y";  
include 'includes/db_connection.php';
  $result = mysql_query("SET AUTOCOMMIT=0");
  if (!$result) { $sqlSuccess = "N";}
  $result = mysql_query("START TRANSACTION");
  if (!$result) { $sqlSuccess = "N";}
 
  $SQL_Select="SELECT voucher_no FROM NEXT_VOUCHER_NO WHERE region='$regionCD'";
  echo "Vchr Number Select:",$result, "<br>";
  $result=mysql_query($SQL_Select) or die ('SELECT voucher_no table failed: ' . mysql_error() .mysql_errno() .mysql_errno() ."<br>");
  if (!$result) { $sqlSuccess = "N";}
  $row = mysql_fetch_row($result);
  $vchrID = $row[0] ;
  $nextVchrID = $vchrID + 1;
  $SQL_Update = "UPDATE next_voucher_no SET voucher_no= $nextVchrID WHERE region='$regionCD'" ;
  $result =  mysql_query($SQL_Update) or die ('UPDATE voucher_no table failed: ' . mysql_error() .mysql_errno() .mysql_errno() ."<br>");
  if (!$result) { $sqlSuccess = "N";}
  echo "Vchr Number Update:",$result, "<br>";
 
  $SQL_Insert = "INSERT into INVOICE values ('01', '$coCD', '$vchrID', '$vndrNo','$invNo', '$invDateWk', '$payTerms',
       '$dueDateWk',  '$grossAmt', '$invFrtAmt', '$invDscntAmt', '$invOtherAmt', '$invNetAmt', '$poNo', NOW())";
  echo "INSERT INVOICE table: ", $SQL_Insert, "<br>";
  $result = mysql_query($SQL_Insert) or die ('Insert into invoice table failed: ' . mysql_error() .mysql_errno() .mysql_errno() ."<br>");
  if (!$result) { $sqlSuccess = "N";}
  echo "INSERT INVOICE table Result",$result, "<br>";
 
  $SQL_Insert = "INSERT into INVOICE_LINE values ($coCD', $vchrID', '$dist_line_no', '$dept1', '$bu1', '$acct1', '$proj1', '$task1', '$amt1')";
  echo "INSERT INVOICE_LINE table: ", $SQL_Insert, "<br>";
  $result = mysql_query($SQL_Insert) or die ('Insert into inv_line 1 table failed: ' . mysql_error() .mysql_errno() ."<br>") ;
  if (!$result) { $sqlSuccess = "N";}
  echo "INSERT INVOICE_LINE table Result:",$result, "<br>";
 
 
  if ($sqlSuccess = "Y") {
      $SQL = "COMMIT;";
      $invoiceSaved="Y";
      $result = mysql_query($SQL) or die('COMMIT failed: ' . mysql_error() .mysql_errno() ."<br>") ;
  } else {
      $SQL = "ROLLBACK;";
      $result = mysql_query($SQL) or die('ROLLBACK failed: ' . mysql_error() .mysql_errno() ."<br>") ;
  }
[+][-]08.26.2008 at 12:29PM PDT, ID: 22318466

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.26.2008 at 12:34PM PDT, ID: 22318507

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.26.2008 at 12:39PM PDT, ID: 22318558

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.26.2008 at 12:50PM PDT, ID: 22318672

View this solution now by starting your 7-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zone: PHP and Databases
Tags: PHP, PHP 5.2
Sign Up Now!
Solution Provided By: jausions
Participating Experts: 3
Solution Grade: A
 
 
[+][-]08.26.2008 at 12:51PM PDT, ID: 22318685

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.26.2008 at 01:49PM PDT, ID: 22319306

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]08.26.2008 at 02:29PM PDT, ID: 22319761

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.26.2008 at 02:31PM PDT, ID: 22319792

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
 
Loading Advertisement...
20080716-EE-VQP-32 / EE_QW_2_20070628