Question

unexpected T_EXIT?

Asked by: katcarvell

I'm not quite sure what they mean here.

Here is my code.

It says line 58.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
   "http://www.w3.org/TR/xhtml1-strict.dtd">
<HTML>
 
<head>
 
<LINK href="style4igs.css" rel="stylesheet" type="text/css">
<meta http-equiv="content-type" content="text/html;charset=iso-8859-1">
<title>4IGS.net</title>
<META NAME="keywords" content="gifts, gift, gift certificate, certificate, holiday, christmas, anniversary, price, spa, restaurant, store, bar code, instant, birthday, mothers day, fathers day, thanksgiving, halloween, user interface, log in, instant gift store, businesses">
 
<META NAME="description" content="Instant Gift Certificate: Get gift certificates instantly online!  Perfect for gifts.  Certificates for restaurants, spas, stores, and much more!">
</head>
<body>
 
 
<div>
  <b class="spiffy">
 
  <b class="spiffy1"><b></b></b>
  <b class="spiffy2"><b></b></b>
  <b class="spiffy3"></b>
  <b class="spiffy4"></b>
  <b class="spiffy5"></b></b>
 
  <div class="spiffyfg">
 
<center><font size="4">Log In</font></center>
<h1>&nbsp;</h1>
 
 
<?php
// Connects to your Database
mysql_connect("server_name", "username", "password") or die(mysql_error());
mysql_select_db("database") or die(mysql_error());
 
//Checks if there is a login cookie
$username = $_COOKIE['ID_my_site'];
$pass = $_COOKIE['Key_my_site'];
$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
while($info = mysql_fetch_array( $check ))
{
   if ($pass != $info['password'])
   {
   }
   else
   {
   header("Location: controlpanel.php");
   }
}
 
 
//if the login form is submitted
if (isset($_POST['submit'])) { // if form has been submitted
 
// makes sure they filled it in
if ( (!isset($_POST['username']) || (!isset($_POST['password']) ) 
   die('You did not fill in a required field.');
}
// checks it against the database
 
if (!get_magic_quotes_gpc()) {
$_POST['email'] = addslashes($_POST['email']);
}
$check = mysql_query("SELECT * FROM users WHERE username = '".$_POST['username']."'")or die(mysql_error());
//Gives error if user dosen't exist
$check2 = mysql_num_rows($check);
if ($check2 == 0) {
die('User name not valid.');
}
while($info = mysql_fetch_array( $check ))
{
$_POST['password'] = stripslashes($_POST['password']);
$info['password'] = stripslashes($info['password']);
$_POST['password'] = md5($_POST['password']);
 
//gives error if the password is wrong
if ($_POST['password'] != $info['password']) {
die('Incorrect password, please try again.');
}
else
{
 
// if login is ok then we add a cookie
$_POST['username'] = stripslashes($_POST['username']);
$hour = time() + 3600;
setcookie(ID_my_site, $_POST['username'], $hour);
setcookie(Key_my_site, $_POST['password'], $hour);
 
//then redirect them to the members area
header("Location: controlpanel.php");
exit;
 
// if they are not logged in
?>
<form action="<?php echo !$_SERVER['PHP_SELF']?>" method="post">
<font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Username:
</font>
<br>
<input type="text" name="username" maxlength="40">
<font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Password:
</font>
<br>
<input type="password" name="password" maxlength="50">
 
<input type="submit" name="submit" value="Login" align="right">
 
</form>
<?php
}
 
?>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:

Select all Open in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2008-12-29 at 09:45:19ID24013586
Tags: PHP
,; mySQL
,; code
Topic: PHP and Databases
Participating Experts: 5
Points: 250
Comments: 12

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: CoyotesITPosted on 2008-12-29 at 09:52:07ID: 23257259

First off, you should change your mysql password now that you posted it to the world.

Next, you are probably missing your closing bracket on your opening if statement checking if the form has been submitted. I took a quick glance and it looks like you are just missing the close to the opening of:

if (isset($_POST['submit'])) {
....code

and possibly your while statement.

just go through and make sure you have all your open,close brackets.

by: katcarvellPosted on 2008-12-29 at 09:58:43ID: 23257308

I tried finding it, but I couldn't.

by: CoyotesITPosted on 2008-12-29 at 10:21:27ID: 23257471

see if this works, if not you should be able to pinpoint the location when you run it.

<?php
// Connects to your Database
mysql_connect("servername", "username", "password") or die(mysql_error());
mysql_select_db("database") or die(mysql_error());
 
//Checks if there is a login cookie
$username = $_COOKIE['ID_my_site'];
$pass = $_COOKIE['Key_my_site'];
$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
while($info = mysql_fetch_array( $check ))
{
   if ($pass != $info['password'])
   {
   }
   else
   {
   header("Location: controlpanel.php");
   }
}
 
 
//if the login form is submitted
if (isset($_POST['submit'])) { // if form has been submitted
    // makes sure they filled it in
    if ( (!isset($_POST['username']) || (!isset($_POST['password']) ) 
       die('You did not fill in a required field.');
    }
    // checks it against the database
     
    if (!get_magic_quotes_gpc()) {
    	$_POST['email'] = addslashes($_POST['email']);
    }
	
    $check = mysql_query("SELECT * FROM users WHERE username = '".$_POST['username']."'")or die(mysql_error());
    //Gives error if user dosen't exist
    $check2 = mysql_num_rows($check);
    
    if ($check2 == 0) {
    	die('User name not valid.');
    }
    
    while($info = mysql_fetch_array( $check ))
    {
        $_POST['password'] = stripslashes($_POST['password']);
        $info['password'] = stripslashes($info['password']);
        $_POST['password'] = md5($_POST['password']);
     
        //gives error if the password is wrong
        if ($_POST['password'] != $info['password']) {
	        die('Incorrect password, please try again.');
        }
		else
		{
            // if login is ok then we add a cookie
            $_POST['username'] = stripslashes($_POST['username']);
            $hour = time() + 3600;
            setcookie(ID_my_site, $_POST['username'], $hour);
            setcookie(Key_my_site, $_POST['password'], $hour);
 
			//then redirect them to the members area
			header("Location: controlpanel.php");
			exit;
 		}
    }
}
else
}
// if they are not logged in
?>
 
<form action="<?php echo !$_SERVER['PHP_SELF']?>" method="post">
  <font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Username: </font> <br>
  <input type="text" name="username" maxlength="40">
  <font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Password: </font> <br>
  <input type="password" name="password" maxlength="50">
  <input type="submit" name="submit" value="Login" align="right">
</form>
<?php
}

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:

Select all Open in new window

by: AielloJPosted on 2008-12-29 at 10:22:34ID: 23257480

katcarvell:

You have unbalanced parenthesis in your 'if' statement.

WRONG:
if ( (!isset($_POST['username']) || (!isset($_POST['password']) )
die('You did not fill in a required field.');

CORRECT:
if (!isset($_POST['username']) || !isset($_POST['password']))

There's a simple way to check unbalanced paranthesis in your code. As you read your code, start counting up for every opening parenthesis, and count down one for every closing parenthesis as shown below. At the end of the 'if' statement you should be at zero.

ie:
1 2 3 2 3 4 3 2
if ( (!isset($_POST['username']) || (!isset($_POST['password']) )

Since you ended up at two, your statement is not balanced. I also ALWAYS suggest:

1) Using opening and closing braces even when there is a single statement after the 'if', or 'while' statement.
2) Use indenting of code after all 'if', 'while', 'for', 'switch', and other block level conditions. It helps eliminate mistakes and makes the intent of the code so much easier to see. I reformatted your original code as shown below.

//if the login form is submitted
if (isset($_POST['submit']))
{ // if form has been submitted

// makes sure they filled it in
if (!isset($_POST['username']) || !isset($_POST['password']))
{
die('You did not fill in a required field.');
}
}

by: MemTest21Posted on 2008-12-29 at 10:25:25ID: 23257500

The error is between your "{" on line 54 and "}" on line 59. Between those two brackets, you have six left parenthesis, and only four right ones. Your error is on line 57, in which you have five left, and only three right. You need another ")" before the "II," and another ")" one at the end of the line. Try that and see if it works.

M.

by: AielloJPosted on 2008-12-29 at 10:27:15ID: 23257510

katcarvell:

Also please take CoyotesIT advice and never post your true connection code anywhere. Anyone reading this post now could now have DBA privileges to your database. The first thing you should be doing at the moment is changing the usernames and passwords. The next time you have a similar post, change the connect line to read:

mysql_connect("datrabase name", "username", "password") or die(mysql_error());

by: katcarvellPosted on 2008-12-29 at 11:04:12ID: 23257802

unexpected T_ELSE on 99 now...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
   "http://www.w3.org/TR/xhtml1-strict.dtd">
<HTML>
 
<head>
 
<LINK href="style4igs.css" rel="stylesheet" type="text/css">
<meta http-equiv="content-type" content="text/html;charset=iso-8859-1">
<title>4IGS.net</title>
<META NAME="keywords" content="gifts, gift, gift certificate, certificate, holiday, christmas, anniversary, price, spa, restaurant, store, bar code, instant, birthday, mothers day, fathers day, thanksgiving, halloween, user interface, log in, instant gift store, businesses">
 
<META NAME="description" content="Instant Gift Certificate: Get gift certificates instantly online!  Perfect for gifts.  Certificates for restaurants, spas, stores, and much more!">
</head>
<body>
 
 
<div>
  <b class="spiffy">
 
  <b class="spiffy1"><b></b></b>
  <b class="spiffy2"><b></b></b>
  <b class="spiffy3"></b>
  <b class="spiffy4"></b>
  <b class="spiffy5"></b></b>
 
  <div class="spiffyfg">
 
<center><font size="4">Log In</font></center>
<h1>&nbsp;</h1>
 
 
<?php
// Connects to your Database
mysql_connect("mysql.18495085748.katcarvell.com", "username", "password") or die(mysql_error());
mysql_select_db("4igsbiz") or die(mysql_error());
 
//Checks if there is a login cookie
$username = $_COOKIE['ID_my_site'];
$pass = $_COOKIE['Key_my_site'];
$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
while($info = mysql_fetch_array( $check ))
{
   if ($pass != $info['password'])
   {
   }
   else
   {
   header("Location: controlpanel.php");
   }
}
 
 
//if the login form is submitted
if (isset($_POST['submit']))
{ // if form has been submitted
 
// makes sure they filled it in
  if (!isset($_POST['username']) || !isset($_POST['password']))
  {
    die('You did not fill in a required field.');
  }
}    // checks it against the database
     
    if (!get_magic_quotes_gpc()) {
        $_POST['email'] = addslashes($_POST['email']);
    }
        
    $check = mysql_query("SELECT * FROM users WHERE username = '".$_POST['username']."'")or die(mysql_error());
    //Gives error if user dosen't exist
    $check2 = mysql_num_rows($check);
    
    if ($check2 == 0) {
        die('User name not valid.');
    }
    
    while($info = mysql_fetch_array( $check ))
    {
        $_POST['password'] = stripslashes($_POST['password']);
        $info['password'] = stripslashes($info['password']);
        $_POST['password'] = md5($_POST['password']);
     
        //gives error if the password is wrong
        if ($_POST['password'] != $info['password']) {
                die('Incorrect password, please try again.');
        }
                else
                {
            // if login is ok then we add a cookie
            $_POST['username'] = stripslashes($_POST['username']);
            $hour = time() + 3600;
            setcookie(ID_my_site, $_POST['username'], $hour);
            setcookie(Key_my_site, $_POST['password'], $hour);
 
                        //then redirect them to the members area
                        header("Location: controlpanel.php");
                        exit;
                }
    }
else
}
// if they are not logged in
?>
 
<form action="<?php echo !$_SERVER['PHP_SELF']?>" method="post">
  <font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Username: </font> <br>
  <input type="text" name="username" maxlength="40">
  <font style="font-family: arial;
color: #ffffff;
font-size: 12px;">Password: </font> <br>
  <input type="password" name="password" maxlength="50">
  <input type="submit" name="submit" value="Login" align="right">
</form>
<?php
}
?>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:

Select all Open in new window

by: angelIIIPosted on 2008-12-29 at 11:10:51ID: 23257859

you now have:

else
}

but the else is not matching a "if", and the } would be missing the { any how.

tip:

comment the closing } with where it comes from, and do the indendation.
doing it that way will make 100% sure you will find the culprit once you commented all of them.


if ( somecondition )
{
  while ( othercondition )
  {
 
  } //  while ( othercondition )
 
}  // if ( somecondition )
else
{
 
} //  else if ( somecondition )

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select all Open in new window

by: katcarvellPosted on 2008-12-29 at 11:19:34ID: 23257935

now it is saying the user name isn't valid, when it most certainly is. (for the log in itself.)

by: angelIIIPosted on 2008-12-29 at 13:30:43ID: 23258895

well, I guess that is another problem :)
the php syntax issue is solved...

by: Ray_PaseurPosted on 2008-12-30 at 07:47:44ID: 23263349

@katcarvell: Maybe a little OT, but you are going to be debugging unpredictable behavior in this script soon, so I will try to offer a little guidance on the use of header().

header() is an inline command in PHP. After you issue header, the script keeps right on running. This makes sense - you can issue several header commands depending on your needs.

But header("Location: ") almost ALWAYS intends to send the browser to a new page. In order to do that and terminate the operation of your script in a predictable fashion, you need to add exit; after the header() statement. See lines 43 through 49 in your OP snippet.

Best regards, ~Ray

   if ($pass != $info['password'])
   {
   }
   else
   {
   header("Location: controlpanel.php");
   exit;
   }

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

unexpected T_EXIT?

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

PHP

mySQL

code

PHP and Databases

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press