[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.3

php 5.0 script performance question

Asked by jmoriarty in PHP and Databases, MySQL Server, PHP for Windows

Hey folks,

I have a very basic script written in php 5.0 connecting to a mysql database that parses a csv of 3 fields to update entries in the database, and the script takes a significant amount of time to execute and I'm trying to figure out why. For example, a sheet of 600 records takes almost 5 minutes. I've attached the part of the code that parses the csv incase anyone can catch a reason why it might be bottlenecking somewhere.

Comments/help appreciate.

Thanks!
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
(note: I didn't include the file upload part, opening/closing tags, database connection info and so forth, since all that logic seems to function properly.
 
//set row count
$row = 0;
 
//loop through each row and assign elements to named variables
while ((list($sku, $price, $msrp) = fgetcsv($fh, ",")) !== FALSE) 
{
		$row++;
		//skip headers
     if ($row == 1) {
         continue;
     }
 
// in the database, sku is a varchar field, price/msrp are decimal(5,2)
 
$sku = "'" . mysql_real_escape_string($sku) . "'"; 
$msrp = mysql_real_escape_string($msrp); 
$price = mysql_real_escape_string($price);
 
//verify the sku column actually contains data
 
if ($sku == '')
{
exit("empty sku found");
}
 
//verify price has a value to update; script can update price, msrp, or both
 
if ($price != '')
{
$sql = "UPDATE mmproductgroupdetail mmp SET mmp.price = $price WHERE mmp.sku = $sku";
mysql_query($sql) or die('SQL ERROR:'.mysql_error());
 
}
//verify msrp has a value to update
 
if ($msrp != '')
{
$sql = "UPDATE mmproductgroupdetail mmp SET mmp.msrp = $msrp WHERE mmp.sku = $sku";
mysql_query($sql) or die('SQL ERROR:'.mysql_error());
}
 
//reset script execution time so it doesn't timeout due to long execution
 
set_time_limit(20);
}
//clean up
 
fclose($fh);
unlink($file);
mysql_close($conn);
[+][-]04/09/09 02:37 PM, ID: 24111949Accepted Solution

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

About this solution

Zones: PHP and Databases, MySQL Server, PHP for Windows
Sign Up Now!
Solution Provided By: bportlock
Participating Experts: 2
Solution Grade: A
 
[+][-]04/09/09 02:40 PM, ID: 24111974Assisted Solution

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 30-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]04/09/09 03:00 PM, ID: 24112113Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]04/09/09 03:24 PM, ID: 24112258Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]04/09/09 03:43 PM, ID: 24112377Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]04/10/09 03:04 AM, ID: 24114336Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]04/10/09 03:16 AM, ID: 24114396Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]04/10/09 03:35 AM, ID: 24114466Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]04/10/09 03:37 AM, ID: 24114474Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]04/10/09 05:17 AM, ID: 24114956Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]04/10/09 04:04 PM, ID: 24120088Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]04/19/09 10:57 AM, ID: 24179934Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]04/19/09 01:08 PM, ID: 24180383Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
 
Loading Advertisement...
20091021-EE-VQP-81 - Hierarchy / EE_QW_3_20080625