delete a file using php

should be something like this. Remember that the $dir directory must be 777 permission if you run it from HTTP!

$dir = "/path/to/images";

// Open a known directory, and proceed to read its contents
if (is_dir($dir)) {
   if ($dh = opendir($dir)) {
       while (($file = readdir($dh)) !== false) {
           if (preg_match('/^D001_image\d\.jpg$/', $file))
              unlink($dir . "/" . $file);
       }
       closedir($dh);
   }
}

unlink'('D001_image.jpg');

this is a php function?

and is the ' before the open bracket a miss type?

>> unlink'('D001_image.jpg');

Unlink is a PHP function: http://www.php.net/manual/en/function.unlink.php

>> unlink'('D001_image.jpg');
Yes that was a mistype naturaly.

-r-

Unlink is a common command.
PERL uses unlink too!
:)

ok guys, sorry i had to finish off some of my other questions off first.

right im trying to do, this delete any images associated with a record in a mysql db.

the table is called tblProperties which stores details on properties.

the page im trying to code is for deleting properties from the db., but not only delete the properties, but delete the images belong to that property too. all the images are stored in another folder. so far i can delete the properties record in the db with no hassle, but the next step is deleting the images too.

here is my code for deleting the property details/record from the db:

if (!$link_id) $link_id = db_connect();
                  $id = $_POST['id'];
                  if($id)
                  {
                        $Query = "SELECT record_id FROM tblProperties WHERE record_id=$id";
                        $PropertiesResult = mysql_query($Query, $link_id) or die("Database troubles</body></html>");
                        if ($row = mysql_fetch_array($PropertiesResult))
                        {
$ref_num = $row['property_ref_num'];                              
$Query = "DELETE FROM tblProperties WHERE record_id = $id";
                              mysql_query($Query, $link_id) or die("Database troubles deleting Property</body></html>");
                              ?>
                              <p>Property Deleted.<br>Redirecting you to the main page. Please wait...</p>
                              <script type="text/javascript">
                              <!--
                                    redirect('main.php');
                              //-->
                              </script>
                              <?php
                        }
                  }
                  else
                  {
                        die("No Record ID present");
                  }


what i now need to do is include the above code into my code to delete the images too...

as i mentioned above the image names are in a format like "ReferenceNum_image1.jpg"

only the reference number part of all the images change depending on what properties is selected to be deleted.

is it clear to what i want to do?

can somebody help me please?

what i have is:

the relative path to my image folder is:

e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images\\

this page is located in folder called "properties"

so now my code looks like:

function delete_images_by_refnum($image_folder, $ref_num)
{
  $d = opendir($image_folder);'
  if(!is_resource($d)) return;
  while($f = readdir($d))
  {
    if(substr($f, 0, strlen($ref_num)+1) == $ref_num + '_')
      unlink ($image_folder.'/'.$f);
  }
}

if (!$link_id) $link_id = db_connect();
               $id = $_POST['id'];
               if($id)
               {
                    $Query = "SELECT record_id FROM tblProperties WHERE record_id=$id";
                    $PropertiesResult = mysql_query($Query, $link_id) or die("Database troubles</body></html>");
                    if ($row = mysql_fetch_array($PropertiesResult))
                    {
$ref_num = $row['property_ref_num'];    

delete_images_by_refnum(dirname("e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties").'/property_images', $ref_num);


                     
$Query = "DELETE FROM tblProperties WHERE record_id = $id";
                         mysql_query($Query, $link_id) or die("Database troubles deleting Property</body></html>");
                         ?>
                         <p>Property Deleted.<br>Redirecting you to the main page. Please wait...</p>
                         <script type="text/javascript">
                         <!--
                              redirect('main.php');
                         //-->
                         </script>
                         <?php
                    }
               }
               else
               {
                    die("No Record ID present");
               }


am i right in the way ive got my code for the directory?

Ah, you have to full absolute path, that's even better.

Change the command to:

delete_images_by_refnum("e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images', $ref_num);

Or either

delete_images_by_refnum("e:/domains/a/antons-law.com/user/htdocs/properties/property_images', $ref_num);

-r-

ok i got this error:

Parse error: parse error, unexpected T_STRING in e:\domains\a\antons-law.com\user\htdocs\properties\secure\propertiesdelete.php on line 261

line 261 is:

$Query = "DELETE FROM tblProperties WHERE record_id = $id";

my code at the end of the page to delete is:

if (!$link_id) $link_id = db_connect();
                  $id = $_POST['id'];
                  if($id)
                  {
                        $Query = "SELECT record_id FROM tblProperties WHERE record_id=$id";
                        $PropertiesResult = mysql_query($Query, $link_id) or die("Database troubles</body></html>");
                        if ($row = mysql_fetch_array($PropertiesResult))
                        {

                              $ref_num = $row['property_ref_num'];

                              delete_images_by_refnum("e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images', $ref_num);

                              $Query = "DELETE FROM tblProperties WHERE record_id = $id";
                              mysql_query($Query, $link_id) or die("Database troubles deleting Property</body></html>");
                              ?>
                              <p>Property Deleted.<br>Redirecting you to the main page. Please wait...</p>
                              <script type="text/javascript">
                              <!--
                                    redirect('main.php');
                              //-->
                              </script>
                              <?php
                        }
                  }
                  else
                  {
                        die("No Record ID present");
                  }


                  function delete_images_by_refnum($image_folder, $ref_num)
                  {
                        $d = opendir($image_folder);

                        if(!is_resource($d)) return;

                        while($f = readdir($d))
                        {
                              if(substr($f, 0, strlen($ref_num)+1) == $ref_num + '_')
                                    unlink ($image_folder.'/'.$f);
                        }
                  }

delete_images_by_refnum("e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images', $ref_num);

should be either

delete_images_by_refnum("e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images", $ref_num);

or

delete_images_by_refnum('e:\\domains\\a\\antons-law.com\\user\\htdocs\\properties\\property_images', $ref_num);

The start and ending quotes didn't match up.

work here is finished. i have to go home now, but will be back online when i get home to finish this.

if you could take  alook at my code and see if you can find the error?

It could be that I am offline later this evening, but will respond back tomorrow if not toning :-)

ah, a simple error like that can go unnoticed very easy!!

you have very sharp eyes!!

ok i got a error on permissions?

you can see a screen shot here:

http://www.antons-law.com/properties/error.jpg

another thing i noticed too, when i delete 1 property hoping that properties images are deleted too, i find all my images get deleted when i refresh the page??

any ideas?

Ellandrd

The errors indicate that the line below is incorrect. Because this line fails the script just unlinks every item readdir returns, including parent directory ('..'), current directory ('.') and any other directories.

if(substr($f, 0, strlen($ref_num)+1) == $ref_num + '_')

I think it might be because of the $ref_num + '_'. Can you have a try with:

if(substr($f, 0, strlen($ref_num)+1) == $ref_num.'_')

And otherwise we could probably use:

if(preg_match('/^'.intval($ref_num).'_image/i', $f))

Hope this helps (finally ;-) )

-r-

Good morning Roonan,

i will change my line to:

if(substr($f, 0, strlen($ref_num)+1) == $ref_num.'_')

and see what happens, give me a minute, to make the changes and i'll get back to you

Ellandrd

it worked.

it was this line of code...

if(substr($f, 0, strlen($ref_num)+1) == $ref_num.'_')

thanks a million. grade A plus the 500 points!

can we now concentrate on my second question that we left yesterday and get that working?

Ellandrd