Need help creating individual form fields in this PHP script.

first things first, remove your extra php closing tags, you have ?>'s showing up on your site

Secondly, to add more form fields you just add them?  I see you already have two at the top, <input type="text" ... />, and have them replace the <textarea ... />
unless of course you want them to be able to provide free-format information to a question...

Is that clear enough?

Could you give me an example?

This was a freeware script that I modified and I've tried tweaking it already w/o suceess.  I'm not a programmer, so your help would be greatly appreciated.

oh boy...

ummm... I would research HTML form tags before trying to go any further if I were you...  A good quick reference that shows how things are done can be found here:

http://www.echoecho.com/htmlforms15.htm

that will give you primer on what you need, and you should be able to see the items in your code there.

I've added the separate fields but when I receive the e-mail oly the attachment comes thru and not the band's info that get's put in.

http://www.x929.com/xupload/index.php

OK, now that you have the fields you want on the form you'll have to modify the code that receives the information, which from the code you have up there looks like it's mail_module.php (the action in the form tag).  I have no idea what that code looks like, but basically where it's adding items to the mail message you'll have to retrieve the fields you just added to the form using the _$POST['field_name'] and append it to the mail message

you will use the _$POST variable because it contains all of the elements that are posted to the page you are calling (you see your form tag?  the action is "mail_module.php" , which means that is the page this information will be passed to, the type is "post", which means you need to retrieve the information from the _$POST associative array)

do you understand what I mean?

Sort of......here is the code from my mailmodule.php

<?
include "config.php";
?>
<link rel=stylesheet href="formstyle.css">
<p align=center class=title>Thank You!</p>
<?php  
//----------------------------------------------
function checkfileatt($fname,$fsize){
  global $max_size;
  global $banned_ext;
  $err="No file attached";
  //Checking file type in or out of banned file extensions list
    $pos1=strrchr($fname,".");
    $ftype=str_replace(".","",$pos1);
    $blist=explode("|",$banned_ext);
    for($i=0;$i<sizeof($blist)-1;$i++){
      if($ftype==$blist[$i]) $err="ERROR: Your file extension (<b>*.$ftype</b>) is not be accepted.";
    }
  //Check file size
    if(round($fsize/1024)>$max_size) $err="ERROR: Your file size (<b>" .round($fsize/1024) ."</b> Kb) is too large. We only accept <b>$max_size</b> Kb.";
  //Return the value
  return $err;
}

function formathtml($text){
  $text=stripslashes($text);
  $text=str_replace("\r\n","<BR>",$text);
  $text=str_replace("\n","<BR>",$text);
return $text;
}

function checkemail($email){
  if(!eregi("^[A-za-z0-9\_\.-]+@[A-za-z0-9\_\.-]+.[A-za-z0-9\_-]+.*",$email) || empty($email))
  return FALSE;
  else return TRUE;
}
//----------------------------------------------

    if($mail_mode==0) $email_to=$email_to_anonymous;
    else $email_to=$my_email;
   
    if($version=="demo") {
          $email_from="anonymous@anonymous-server.com";
    }

    $kt=0;
    //Checking valid email address
    if(!checkemail($email_to)) $kt=1;
    if(!checkemail($email_from)) $kt=1;
    if(empty($email_subject)) $kt=2;
   
    if($kt==1) print("<p>ERROR: Email address (From email or To email) is not correct</p>");
    else if($kt==2) print("<p>ERROR: Your email Subject is blank</p>");
   
    if($kt==0){

                //BEGIN //----------------------------------------------
                      $email_message=formathtml($real_email_message);
                      $chked=0;
                      if ($upfile == "none" || $upfile_size==0) $chked=1;
                      if (checkfileatt($upfile_name,$upfile_size)!="No file attached") $chked=1;
                      if($chked==0) {
                            copy($upfile, $upfile_name);
                        $fileatt=$upfile_name;
                        $fileatt_type=$upfile_type;
                        $fileatt_name=$upfile_name;
                        $file = fopen($fileatt,'rb');
                        $data = fread($file,filesize($fileatt));
                        fclose($file);
                      }
                      $headers = "From: ".$email_from;

                      $semi_rand = md5(time());
                      $mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

                      $headers .= "\nMIME-Version: 1.0\n" . "Content-Type: multipart/mixed;\n" . " boundary=\"{$mime_boundary}\"";
                      $email_message = "This is a multi-part message in MIME format.\n\n" . "--{$mime_boundary}\n" . "Content-Type:text/html; charset=\"iso-8859-1\"\n" . "Content-Transfer-Encoding: 7bit\n\n" . $email_message . "\n\n";

                      $data = chunk_split(base64_encode($data));

                      $email_message .= "--{$mime_boundary}\n" . "Content-Type: {$fileatt_type};\n" . " name=\"{$fileatt_name}\"\n" . "Content-Disposition: attachment;\n" . " filename=\"{$fileatt_name}\"\n" . "Content-Transfer-Encoding: base64\n\n" . $data . "\n\n" ."--{$mime_boundary}--\n";
                      $sending_ok = @mail($email_to, $email_subject, $email_message, $headers);

                      if($chked==0) unlink($upfile_name);

                //END mode 3 and 0//----------------------------------------------


                //Print the email result
                if($sending_ok){
                  print("<title>Sending successful to $email_to</title><div align=center><p>Email sending successful</p>");
                }
                else print("<title>Sending failed to $email_to</title><div align=center><p><b>ERROR in mail server</b> Your email could not been sent</p>");

                print("
                    <p><table border=0 width=80% cellspacing=1 bgcolor=#AED0F2><tr><td bgcolor=#F0F0F0>
                     <p><u><b>Sent to email</b></u><br>
                     $email_to
                     <p><u><b>From email</b></u><br>
                     $email_from
                     <p><u><b>Email subject</b></u><br>
                     $email_subject
                    <p><u><b>Message</b></u><p>
                    <table border=0 width=100% cellspacing=1 style=\"border: 1 dotted #AED0F2;\"><tr><td>");
                print(formathtml($real_email_message));
                print("</td></tr></table><p><br></p>
                    <p align=center><a href=$my_url title=\"Come back to my site\">Thank you, back to my site</a>  or  <a href=index.php>Send me another email</a></p>
                    <p><br></p>
                    </td></tr></table>
                   
                    <p><b>Attachment status</b>
                    <p><table border=0 width=80% cellspacing=1 bgcolor=#AED0F2><tr><td bgcolor=#CAE4FF>");
                    if($mail_mode==0 || $mail_mode==1) {
                      if($chked==0) print("<p><b>$upfile_name</b><br>Filesize: " .round($upfile_size/1024) ." Kb | Filetype : $upfile_type");
                      else print("<p>" .checkfileatt($upfile_name,$upfile_size) ."</p>");
                    }
    }
?>
</td></tr></table>
<p><br></p>
<center> &nbsp;</center>

ok, I don't see how it's getting the information out of the variables in that example.  you're probably going to have to look at the included file for that

Ok, Can you pls help me get this submission form working? I would greatly appreciate the help!

OK, be we'll need to look at the code in config.php - I don't see where mail_module is getting the variables from, and it should be retrieveing them from the $_POST superglobal...

what is in config.php?

Please x out, or delete any code that is not for public consumption (i.e. contains security information, etc)

OK, here's my config.php:

<?
/*
-------------------------------------------------------
FORM TO EMAIL WITH ATTACHMENT
Version: 1.0
Last update: 13,May,03
-------------------------------------------------------
*/

/*------------------
Mail mode:
 0 for Anonymous HTML email WITH attachment file (For TESTING only: "email_from" and "email_to" fields can be blank)
 1 for HTML email WITH attachment file
------------------*/

      $mail_mode = 1;

//------------------Max file size: Maximum size of attchment file, in (KB)

      $max_size=1000000;

//------------------My email: Your own email address

      $my_email="webmaster@x929.com";


//------------------My URL: Your own website address

      $my_url="http://www.x929.com";

/*------------------
List of banned file extensions:
For security, users can not execute their script
 (uploaded by attachment file) on your server
Note: the charactor "|" MUST be in the end
------------------*/

      $banned_ext="php|phtml|cgi|pl|asp|jsp|c|cfm|shtml|exe|bat|com|";

//------------------Script version

      $version="1.2";
?>

now I'm really confused.  I don't see how it gets the values out of the form, what eversion of PHP are you using?

It looks like it's using a really old-school way of getting the variables, by using the $form_element_name (I had almost forgotten about that)
so, if you add new fields you would need to get the values of those fields and add them to the text before sending the email:

directly after the // BEGIN // ------------------------- comment in mail_module.php you would need to add the field to the email message form:

(I don't know that the ? will work at the end of your HTML field names when translating to a PHP variable, so I removed them for this code example.  I also used all lowercase variable names - you might need uppercase first letters to make this work, OK?)


// BEGIN // ---------------------------------------------
$email_message = "Band Name: " . $band . "\n" . $real_email_message . "\nPhone #: " . $phone . "\nWebsite: " . $website";
$email_message = format_html($email_message);

// continue with the rest of your code unmodified here....

OK, I made those changes and got this error when I tried submitting an mp3.:

Parse error: syntax error, unexpected '"' in /usr/home/twi/jayhawkbroadcasting/x929/public_html/xupload/mail_module.php on line 58

oh, remove the last double quote of the first line there, right after $website.

did you also cahnge the form so that the ?'s were out of the form names, and that the input's you added were in lowercase?  I don't know if it makes a huge world of difference, but it might

OK, that time it seemed to take but said


Thank You!

ERROR: Your email Subject is blank

and I have yet to receive the e-mail.

did you enter an email subject?

I have it set to "Local X Music Upload" within the form

Here my form now:

<link rel=stylesheet href="css/formstyle.css">
<?
include "config.php";
?>
<title>Local X Music Upload</title>
<body bgcolor="#000000">

<div align=center>
<form action="mail_module.php" method="post" ENCTYPE="multipart/form-data">
<p>
                  <img border="0" src="images/localxrocks_header.gif" width="518" height="229"><table border=0 width="56%" cellspacing=1 cellpadding=8 bgcolor=#AED0F2>
<tr><td bgcolor=#F0F0F0>
<p align="center"><b><font size="4">Please Include The Following Information Below:</font></b><table border="0" width="93%" id="table3" cellpadding="2">
      <tr>
            <td align="right">&nbsp;</td>
            <td width="392">
<input class=fi type=text size=46 name=email_subject value="Local X Music Upload"?></td>
      </tr>
      <tr>
            <td align="right"><b><font size="1">Your band's e-mail
      address</font></b></td>
            <td width="392">
<input class=fi size=46 name=Email_from width="36%" align="right" style="float: none"?></td>
      </tr>
      <tr>
            <td align="right"><b><font size="1">Your Band's name</font></b></td>
            <td width="392">
<input class=fi type=text size=59 name=Band?></td>
      </tr>
      <tr>
            <td align="right"><b><font size="1">Band Bio and Credits</font></b><p>&nbsp;</p>
            <p>&nbsp;</p>
            <p>&nbsp;</p>
            <p>&nbsp;</p>
            <p>&nbsp;</td>
            <td width="392">
            <textarea class=fi name=Real_email_message cols=57 rows=13 onclick=createCaret(this); onselect=createCaret(this);>
<? if($mail_mode==0) echo "Test message

With blank lines and <b>HTML</b> tags
<hr>

";?>
</textarea></td>
      </tr>
      <tr>
            <td align="right"><b><font size="1">Contact Phone # </font></b>
                        </td>
            <td width="392">
<input class=fi type=text size=59 name=Phone?></td>
      </tr>
      <tr>
            <td align="right"><b><font size="1">Website URL</font></b></td>
            <td width="392">
<input class=fi type=text size=59 name=Website?></td>
      </tr>
</table>
<div align="center">
      <p><font color="#FF0000" size="1"><b>*MP3 File size must not exceed 6 MB</b></font></div>
</p>
<?
print("
   <p><b>Attach your MP3 file</b> <input class=fi type=\"file\" size=40 name=\"upfile\"><br>
   <input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"$max_size\">
   <br><u>");
?>

<p align="center">
<input class=fb type="submit" value="Submit" style="font-size: 8pt; font-family: Verdana; font-weight: bold"></td></tr></table>
</form>
</div>

change your check email function to use A-Z in all cases, other than A-z to start

other than that I would recommend adding this prior to your if(!checkemail($email_to)) $kt=1; test

echo $email_to . "<br />";
echo $email_from . "<br />";
echo $email_subject . "<br />";
echo $band . "<br />";
echo $real_email_message . "<br />";
echo $website . "<br />";
echo $phone . "<br />";

this will show us what are in the form variables...

so modify this line to what?

  if(!eregi("^[A-za-z0-9\_\.-]+@[A-za-z0-9\_\.-]+.[A-za-z0-9\_-]+.*",$email) || empty($email))

this?

  if(!eregi("^[A-ZA-Z0-9\_\.-]+@[A-ZA-Z0-9\_\.-]+.[A-ZA-Z0-9\_-]+.*",$email) || empty($email))

OK, having made those changes I now get this after submission:

Thank You!

ERROR: Email address (From email or To email) is not correct

It used to work, I just wanted separate form field instead of just 1 "all-inclusive" one.

I think the values of your variables is empty....
I don't know why - but that's what it looks like.

try the echo statemetns I supplied earlier, and if you want this function will validate email address too:

function checkemail( $email )
{
      $valid = false;
      
      if( preg_match('/^([a-z0-9\_\.-]+?)\@([a-z][a-z0-9\_\.-]+)\.([a-z]{2,4})$/i', $email) == 1 )
      {
            $valid = true;
      }

      return $valid;
}

hey webfx, are you still out there?

Yeah, I'm at home sick today but I still need to get some sort of e-mail attachment script working for the Local X site so bands can upload their MP3's to us but I haven't found a solution yet.  I've almost decided to give up on the previous e-mail attachment script and find something else.  I'm really in a bind "time-frame" wise and need to get something up and running ASAP.

would you try the echo of the variables?  I don't understand why you haven't done that yet?

Could you pls show me what you mean?