Advertisement

08.15.2008 at 02:36PM PDT, ID: 23652680
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
9.9

classes: when to use static and when not to... opinions on this class

Asked by NeilT in PHP Scripting Language

Hi

I'm slowly moving from many years of writing crap code basically all in 1 file and moving into the proper use of classes.

I'm still unale to grasp the proper use of static as I see some entire sites using things like :
ABC::getSurname()

and others using :

$abc = new ABC();
$abc->getSurname("neil");

I've attached one of my classes below, do you thing this should be left as it is or should I use static and call it in other pages like Logger::commonLog($result)

or

Leave it as the old xx->commonLog($result) style.

Cheers
NeilStart Free Trial 
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:

<?php
 
/**
* Logger Class
*
* Logs successful and or failed payment attempts to files defined in config.php
*
* @author Neil Thompson <neil@ephpay.co.uk>
* @version 1.0
* @access public
* @copyright Neil Thompson 2008
* @package ephpay
*	
*/
	
class Logger {
 
	/**
	* Common
	*
	* Logs all payment attemts whether success or fail
	*
	* @param string $result (payment result)
	* @access	public
	*/	
	public function commonLog($result="") {
		
		require_once("../config.php");
		$timestamp = date('Y-m-d H:i:s');
		
		if (_EPHPAY_GENERAL_LOG == "") {		
			error_log("### Unable to log payment requests: No log file defined in config.php");			
		} else {		
			$cl = fopen(_EPHPAY_GENERAL_LOG, 'a') or die("can't open file : "._EPHPAY_GENERAL_LOG);
			fwrite($cl, $timestamp . "\n" . $result . "\n");
			fclose($cl);			
		}
		return;
		
	}
	
	/**
	* Success
	*
	* Logs successful payments only
	*
	* @param string $result (payment result)
	* @access	public
	*/	
	public function successLog($result="") {
	
		require_once("../config.php");
		$timestamp = date('Y-m-d H:i:s');
		
		if (_EPHPAY_SUCCESSFUL_PAYMENT_LOG == "") {		
			error_log("### Unable to log payment requests: No log file defined in config.php");			
		} else {		
			$cl = fopen(_EPHPAY_SUCCESSFUL_PAYMENT_LOG, 'a') or die("can't open file : "._EPHPAY_SUCCESSFUL_PAYMENT_LOG);
			fwrite($cl, $result . "\n");
			fclose($cl);			
		}
		return;
	}
		
}	
 
?>
 
Keywords: classes: when to use static and whe…
Title
1 crap
2 Opinions on the Iraq Conflict
3 Logger in Servlet
4 keyboard logger
5 Napster... opinions?
6 FOR THE NEIL
 
Loading Advertisement...
 
[+][-]08.15.2008 at 02:53PM PDT, ID: 22241968

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 7-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08.15.2008 at 03:07PM PDT, ID: 22242029

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]08.15.2008 at 03:07PM PDT, ID: 22242030

View this solution now by starting your 7-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zone: PHP Scripting Language
Sign Up Now!
Solution Provided By: hernst42
Participating Experts: 2
Solution Grade: A
 
 
[+][-]08.15.2008 at 03:16PM PDT, ID: 22242068

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]08.18.2008 at 01:28AM PDT, ID: 22250168

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]08.18.2008 at 10:05PM PDT, ID: 22257312

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]08.19.2008 at 12:39AM PDT, ID: 22257785

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
 
Loading Advertisement...
20080716-EE-VQP-32 / EE_QW_2_20070628