Link to home
Start Free TrialLog in
Avatar of Michel Plungjan
Michel PlungjanFlag for Denmark

asked on

Where does the trailing space come from?

http://plungjan.name/SO/load.php

The following code will fail if I do not trim the data.

Why does the PHP return "1 " or "0 " instead of "1" or "0" ?

<?php //load.php
if(isset($_POST["id"])){
  $myid = $_POST['id'];
  if($myid == "1"){
    echo "1";
  }else if($myid == "0"){
    echo "0";
  }
}
else {
?>
<!DOCTYPE html>
<html>
<head>
<title>Post something</title>
<script src="http://code.jquery.com/jquery-1.10.0.min.js"></script>
<script type="text/javascript">
$(function() {
  $('#submit').click( function(){
    $.post('load.php', {"id":$('#id').val()}, function(data){
        window.console&&console.log(data,data=="1");
        var val = $.trim(data);
        if(val == "1"){
            $('#resurl').html('Success');
        }else if (val == "0"){
            $('#resurl').html('Failure');
        }else{
            $('#resurl').html('Unknown:[<span>'+val+'</span>]');
        }
    });
  });
});
</script>
</head>
<body>
<input id="id" />
<div id="resurl"></div>
<input type="button" id="submit" />
</html>
<? } ?> 

Open in new window

Avatar of duncanb7
duncanb7

There is typing error, please re-run again

<?php //load.php
if(isset($_POST["id"])){
  $myid = $_POST['id'];
  if($myid == "1"){
    echo "1";
  }else if($myid == "0"){
    echo "0";
  }
}
else {

}
?>
<!DOCTYPE html>
<html>
<head>
<title>Post something</title>
<script src="http://code.jquery.com/jquery-1.10.0.min.js"></script>
<script type="text/javascript">
$(function() {
  $('#submit').click( function(){
    $.post('load.php', {"id":$('#id').val()}, function(data){
        window.console&&console.log(data,data=="1");
        var val = $.trim(data);
        if(val == "1"){
            $('#resurl').html('Success');
        }else if (val == "0"){
            $('#resurl').html('Failure');
        }else{
            $('#resurl').html('Unknown:[<span>'+val+'</span>]');
        }
    });
  });
});
</script>
</head>
<body>
<input id="id" />
<div id="resurl"></div>
<input type="button" id="submit" />
</html>

Open in new window


window.console&&console.log("=="+data+"==",data=="1");

it show "1" and "0" not "1 " && "0 " if
using window.console&&console.log("=="+data+"==",data=="1");
Avatar of Michel Plungjan

ASKER

I do not understand what you mean.
I do not see any typing error.
I log data and the boolean data == "1" which is false since the data returned is "1 " and not "1"
on line 10 on your first post
I changed to

 window.console&&console.log(">>"+data+"<<",data=="1",data=="1 ");

>>1 << false true

So I do not understand what you mean by line 10?
SOLUTION
Avatar of Robert Schutt
Robert Schutt
Flag of Netherlands image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
PS: that could have been an unrelated issue, only in the post, but with that file I saw the problem and when I removed the space there, the problem disappeared.
ASKER CERTIFIED SOLUTION
Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Actually, just an update to what I said - the space is after the closing php tag, not the one after the closing if bracket. One of the easiest ways to avoid this is to just leave off the closing PHP tag (but only if it's the end of your document). Finish your page like this:

<input type="button" id="submit" />
</html>
<? }

Open in new window

This made sense for me.  Please see:
http://www.laprbass.com/RAY_temp_mplungjan.php

<?php // RAY_temp_mplungjan.php
error_reporting(E_ALL);

if(isset($_POST["id"]))
{   // FILTER / NORMALIZE THE REQUEST DATA
    $myid = trim($_POST['id']);

    // USING THE FILTERED DATA
    if($myid == "1")
    {
        echo "1";
    }
    elseif($myid == "0")
    {
        echo "0";
    }
    else
    {   // UNKNOWN
        echo $myid;
    }
}
else {
?>
<!DOCTYPE html>
<html>
<head>
<title>Post something</title>
<script type="text/javascript" src="http://code.jquery.com/jquery-latest.min.js"></script>
<script type="text/javascript">
$(document).ready(function(){
  $('#submit').click( function(){
    id = $("#id").val();
    $.post('RAY_temp_mplungjan.php', {id:id}, function(data){
      var val = $.trim(data);
      if(val == "1"){
        $('#resurl').html('Success');
      }else if (val == "0"){
        $('#resurl').html('Failure');
      }else{
        $('#resurl').html('Unknown:[<span>' + val + '</span>]');
      }
    });
  });
});
</script>
</head>
<body>
<input id="id" />
<div id="resurl"></div>
<input type="button" id="submit" />
</html>
<? } ?>

Open in new window

HTH, ~Ray
In this post, line 22 opens a control structure, line 23 stops the PHP interpreter.  Then some HTML is sent to the browser.  PHP needs to know when the control structure ends.  That is line 52.  It starts PHP, provides the end of the control structure and then stops PHP.

If the "short open tag" is not set, you would need the complete <?php instead of just the <? to start the PHP interpreter.

I probably would have written this a little differently, but I was in a hurry and just working from what had been posted with the question.
Thanks for the participation.

I do not exactly see how the code Ray posted is any different than mine, however I understand now that the spurious space came from

} ?>_ <=== here

and that I could delete it or just do

} /* end of php */

which is what I did. Hence I accept this answer as the solution to my issue

Learned something new.
I think ChrisStanyon's answer to this thread is much completed and fast
by taking out php closing tab to solve mplungjan's issue completely
(no need to take care of how many space is left before ?>)


If I am wrong, I am sorry and please ignore my post

Duncan
Robert's solution was first, but Chris' explanation was better.

thanks for pointing that out