amira123
asked on
Can't pass vaiable from from to another ASP ..
This question is a continuation to these two topics:
https://www.experts-exchange.com/jsp/qManageQuestion.jsp?ta=asp&qid=20162452
and
https://www.experts-exchange.com/jsp/qManageQuestion.jsp?qid=20161841
I have a form in a script edirrecord.asp that is supposed to pass on values to the script changerec.asp ... however I passes all blanks. I am sure it's a simple typo because I had it working with much less fields. Can anyone point it out because I can't see it;
editrecord.asp is:
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<TITLE></TITLE>
</HEAD>
<BODY>
<%
dim ID
ID=Request.QueryString("Us erName")
dim PW
PW=Request.QueryString("Pa ssword")
dim conn
set conn=Server.CreateObject(" ADODB.Conn ection")
dim strConnectString
strConnectString = "Provider=Microsoft.Jet.OL EDB.4.0;" & "Data Source=" & Server.Mappath("/data/Stud ents.mdb") & ";"
conn.Open strConnectString
dim rs 'record set
dim sql 'sql statement
set rs = Server.CreateObject("ADODB .RecordSet ")
'Old sql
'sql = "Select * from students where UserName =" & ID
'end of old sql
'New sql
'sql = "SELECT students.* FROM students WHERE (((students.UserName)=" & ID & ") AND ((students.Password)=" & PW & "))"
'end of new sql
sql = "SELECT * FROM students WHERE UserName=" & ID & " AND Password='" & PW & "'"
rs.Open sql, conn
%>
<hr>
<FORM action="../database/change rec.asp" method=POST id=form1 name=form1>
<table border=0>
<input type = hidden size=50 name="UserName" value = "<%=rs("UserName")%>">
<tr><td width = 100>Password</td><td><inpu t type = "text" size="50" name="Password" value ="<%=rs("Password")%>"></t d></tr>
<tr><td width = 100>FirstName</td><td><inp ut type = "text" size="50" name="FirstName" value ="<%=rs("FirstName")%>"></ td></tr>
<tr><td width = 100>MiddleName</td><td><in put type = "text" size="50" name="MiddleName" value ="<%=rs("MiddleName")%>">< /td></tr>
<tr><td width = 100>LastName</td><td><inpu t type = "text" size="50" name="LastName" value ="<%=rs("LastName")%>"></t d></tr>
<tr><td width = 100>Address</td><td><input type = "text" size="50" name="Address" value ="<%=rs("Address")%>"></td ></tr>
<tr><td width = 100>AptNumber</td><td><inp ut type = "text" size="50" name="AptNumber" value ="<%=rs("AptNumber")%>"></ td></tr>
<tr><td width = 100>City</td><td><input type = "text" size="50" name="City" value ="<%=rs("City")%>"></td></ tr>
<tr><td width = 100>State</td><td><input type = "text" size="50" name="State" value ="<%=rs("State")%>"></td>< /tr>
<tr><td width = 100>ZipCode</td><td><input type = "text" size="50" name="ZipCode" value ="<%=rs("ZipCode")%>"></td ></tr>
<tr><td width = 100>Country</td><td><input type = "text" size="50" name="Country" value ="<%=rs("Country")%>"></td ></tr>
<tr><td width = 100>Phone</td><td><input type = "text" size="50" name="Phone" value ="<%=rs("Phone")%>"></td>< /tr>
<tr><td width = 100>Fax</td><td><input type = "text" size="50" name="Fax" value ="<%=rs("Fax")%>"></td></t r>
<tr><td width = 100>MobilePhone</td><td><i nput type = "text" size="50" name="MobilePhone" value ="<%=rs("MobilePhone")%>"> </td></tr>
<tr><td width = 100>OtherPhone</td><td><in put type = "text" size="50" name="OtherPhone" value ="<%=rs("OtherPhone")%>">< /td></tr>
<tr><td width = 100>Pager</td><td><input type = "text" size="50" name="Pager" value ="<%=rs("Pager")%>"></td>< /tr>
<tr><td width = 100>BusinessPhone</td><td> <input type = "text" size="50" name="BusinessPhone" value ="<%=rs("BusinessPhone")%> "></td></t r>
<tr><td width = 100>EmailAddress</td><td>< input type = "text" size="50" name="EmailAddress" value ="<%=rs("EmailAddress")%>" ></td></tr >
<tr><td></td><td><input type="submit" value = "submit" id=submit1 name=submit1></td></tr>
</table>
<%conn.close%>
</FORM>
<hr>
</BODY>
</HTML>
changerec.asp is:
<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<TITLE></TITLE>
</HEAD>
<BODY>
<%
Dim ID, Password, FirstName, MiddleName, LastName, Address, AptNumber, City, State, ZipCode, Country, Phone, Fax, MobilePhone, OtherPhone, Pager, BusinessPhone, EmailAddress
ID = Request.QueryString("UserN ame")
Password = Request.QueryString("Passw ord")
FirstName = Request.QueryString("First Name")
MiddleName = Request.QueryString("Middl eName")
LastName = Request.QueryString("LastN ame")
Address = Request.QueryString("Addre ss")
AptNumber = Request.QueryString("AptNu mber")
City = Request.QueryString("City" )
State = Request.QueryString("State ")
ZipCode = Request.QueryString("ZipCo de")
Country = Request.QueryString("Count ry")
Phone = Request.QueryString("Phone ")
Fax = Request.QueryString("Fax")
MobilePhone = Request.QueryString("Mobil ePhone")
OtherPhone = Request.QueryString("Other Phone")
Pager = Request.QueryString("Pager ")
BusinessPhone = Request.QueryString("Busin essPhone")
EmailAddress = Request.QueryString("Email Address")
response.write "1"
response.write UserName
response.write LastName
dim conn
set conn=Server.CreateObject(" ADODB.Conn ection")
dim strConnectString
strConnectString = "Provider=Microsoft.Jet.OL EDB.4.0;" & "Data Source=" & Server.Mappath("/data/Stud ents.mdb") & ";"
conn.Open strConnectString
dim rs 'record set
dim sql 'sql statement
set rs = Server.CreateObject("ADODB .RecordSet ")
'sql = "UPDATE students SET "
'sql = sql &
' & "LastName='" & LastName & "',"_
' & "FirstName='" & FirstName &"',"_
' & "Password=" & Password & " WHERE UserName="& ID
sql = "UPDATE students SET "
sql = sql & "LastName='" & LastName & "', "
sql = sql & "FirstName='" & FirstName & "', "
sql = sql & "City='" & City & "'"
sql = sql & " WHERE UserName=" & ID
response.write sql
'Set RS = Conn.Execute(SQLStmt)
set rs = Conn.Execute(sql)
response.write "<font face='arial' size=4>"
response.write "<br><br>Your changes have been saved."
response.write "</b></font>"
Conn.Close
%>
<p>
<p>
<A HREF="../database_copy(1)/ logon.htm" >Login Again</A>
</BODY>
</HTML>
https://www.experts-exchange.com/jsp/qManageQuestion.jsp?ta=asp&qid=20162452
and
https://www.experts-exchange.com/jsp/qManageQuestion.jsp?qid=20161841
I have a form in a script edirrecord.asp that is supposed to pass on values to the script changerec.asp ... however I passes all blanks. I am sure it's a simple typo because I had it working with much less fields. Can anyone point it out because I can't see it;
editrecord.asp is:
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<TITLE></TITLE>
</HEAD>
<BODY>
<%
dim ID
ID=Request.QueryString("Us
dim PW
PW=Request.QueryString("Pa
dim conn
set conn=Server.CreateObject("
dim strConnectString
strConnectString = "Provider=Microsoft.Jet.OL
conn.Open strConnectString
dim rs 'record set
dim sql 'sql statement
set rs = Server.CreateObject("ADODB
'Old sql
'sql = "Select * from students where UserName =" & ID
'end of old sql
'New sql
'sql = "SELECT students.* FROM students WHERE (((students.UserName)=" & ID & ") AND ((students.Password)=" & PW & "))"
'end of new sql
sql = "SELECT * FROM students WHERE UserName=" & ID & " AND Password='" & PW & "'"
rs.Open sql, conn
%>
<hr>
<FORM action="../database/change
<table border=0>
<input type = hidden size=50 name="UserName" value = "<%=rs("UserName")%>">
<tr><td width = 100>Password</td><td><inpu
<tr><td width = 100>FirstName</td><td><inp
<tr><td width = 100>MiddleName</td><td><in
<tr><td width = 100>LastName</td><td><inpu
<tr><td width = 100>Address</td><td><input
<tr><td width = 100>AptNumber</td><td><inp
<tr><td width = 100>City</td><td><input type = "text" size="50" name="City" value ="<%=rs("City")%>"></td></
<tr><td width = 100>State</td><td><input type = "text" size="50" name="State" value ="<%=rs("State")%>"></td><
<tr><td width = 100>ZipCode</td><td><input
<tr><td width = 100>Country</td><td><input
<tr><td width = 100>Phone</td><td><input type = "text" size="50" name="Phone" value ="<%=rs("Phone")%>"></td><
<tr><td width = 100>Fax</td><td><input type = "text" size="50" name="Fax" value ="<%=rs("Fax")%>"></td></t
<tr><td width = 100>MobilePhone</td><td><i
<tr><td width = 100>OtherPhone</td><td><in
<tr><td width = 100>Pager</td><td><input type = "text" size="50" name="Pager" value ="<%=rs("Pager")%>"></td><
<tr><td width = 100>BusinessPhone</td><td>
<tr><td width = 100>EmailAddress</td><td><
<tr><td></td><td><input type="submit" value = "submit" id=submit1 name=submit1></td></tr>
</table>
<%conn.close%>
</FORM>
<hr>
</BODY>
</HTML>
changerec.asp is:
<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<TITLE></TITLE>
</HEAD>
<BODY>
<%
Dim ID, Password, FirstName, MiddleName, LastName, Address, AptNumber, City, State, ZipCode, Country, Phone, Fax, MobilePhone, OtherPhone, Pager, BusinessPhone, EmailAddress
ID = Request.QueryString("UserN
Password = Request.QueryString("Passw
FirstName = Request.QueryString("First
MiddleName = Request.QueryString("Middl
LastName = Request.QueryString("LastN
Address = Request.QueryString("Addre
AptNumber = Request.QueryString("AptNu
City = Request.QueryString("City"
State = Request.QueryString("State
ZipCode = Request.QueryString("ZipCo
Country = Request.QueryString("Count
Phone = Request.QueryString("Phone
Fax = Request.QueryString("Fax")
MobilePhone = Request.QueryString("Mobil
OtherPhone = Request.QueryString("Other
Pager = Request.QueryString("Pager
BusinessPhone = Request.QueryString("Busin
EmailAddress = Request.QueryString("Email
response.write "1"
response.write UserName
response.write LastName
dim conn
set conn=Server.CreateObject("
dim strConnectString
strConnectString = "Provider=Microsoft.Jet.OL
conn.Open strConnectString
dim rs 'record set
dim sql 'sql statement
set rs = Server.CreateObject("ADODB
'sql = "UPDATE students SET "
'sql = sql &
' & "LastName='" & LastName & "',"_
' & "FirstName='" & FirstName &"',"_
' & "Password=" & Password & " WHERE UserName="& ID
sql = "UPDATE students SET "
sql = sql & "LastName='" & LastName & "', "
sql = sql & "FirstName='" & FirstName & "', "
sql = sql & "City='" & City & "'"
sql = sql & " WHERE UserName=" & ID
response.write sql
'Set RS = Conn.Execute(SQLStmt)
set rs = Conn.Execute(sql)
response.write "<font face='arial' size=4>"
response.write "<br><br>Your changes have been saved."
response.write "</b></font>"
Conn.Close
%>
<p>
<p>
<A HREF="../database_copy(1)/
</BODY>
</HTML>
ASKER
This is the error message I am getting:
1UPDATE students SET LastName='', FirstName='', City='' WHERE UserName=
Microsoft JET Database Engine error '80040e14'
Syntax error (missing operator) in query expression 'UserName='.
/TAA/database/changerec.as p, line 69
1UPDATE students SET LastName='', FirstName='', City='' WHERE UserName=
Microsoft JET Database Engine error '80040e14'
Syntax error (missing operator) in query expression 'UserName='.
/TAA/database/changerec.as
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Use this update sql statement. More less error-prone
sql = "UPDATE students SET "
sql = sql & "LastName='" & replace(LastName,"'","''") & "', "
sql = sql & "FirstName='" & replace(FirstName,"'","''" ) & "', "
sql = sql & "City='" & replace(City,"'","''") & "'"
sql = sql & " WHERE UserName=" & ID
Make sure that ID is an integer field. If it is a string field, do this
sql = "UPDATE students SET "
sql = sql & "LastName='" & replace(LastName,"'","''") & "', "
sql = sql & "FirstName='" & replace(FirstName,"'","''" ) & "', "
sql = sql & "City='" & replace(City,"'","''") & "'"
sql = sql & " WHERE UserName='" & replace(ID,"'","''") & "'"
hongjun
sql = "UPDATE students SET "
sql = sql & "LastName='" & replace(LastName,"'","''")
sql = sql & "FirstName='" & replace(FirstName,"'","''"
sql = sql & "City='" & replace(City,"'","''") & "'"
sql = sql & " WHERE UserName=" & ID
Make sure that ID is an integer field. If it is a string field, do this
sql = "UPDATE students SET "
sql = sql & "LastName='" & replace(LastName,"'","''")
sql = sql & "FirstName='" & replace(FirstName,"'","''"
sql = sql & "City='" & replace(City,"'","''") & "'"
sql = sql & " WHERE UserName='" & replace(ID,"'","''") & "'"
hongjun
ASKER
Thanks that worked. I have on more question:
If I leave some fields blank it gives this error message:
Microsoft JET Database Engine error '80004005'
Field 'students.AptNumber' cannot be a zero-length string
How do I fix that?
(BTW I raised the points to 75)
If I leave some fields blank it gives this error message:
Microsoft JET Database Engine error '80004005'
Field 'students.AptNumber' cannot be a zero-length string
How do I fix that?
(BTW I raised the points to 75)
ASKER
ASKER
response.write "1"
response.write UserName
response.write LastName
and it only shows a one.