<action forward struts

The code you posted is referrint to an action called orderCreated.

The request http://localhost:8085/wptStrutsHib/orderCreated.do would take you to the desired page.

Either this was the mistake you made, or you'll have to post the correct action configuration (for the action createCustomer).

I agree with brunoguimaraes, you posted wrong action definition (orderCreated instead of createCustomer).  Post the relevant one.

Sorry:

    <action
      path="/createCustomer"      
      name="createCustomerForm"
      input="/form/createCustomer.jsp"
      scope="request"      
      type="actions.CreateCustomerAction">
      <forward name="customerCreated" path="/form/createOrder.jsp" />
    </action>

Also ActionClass:

public abstract class AbstractAction extends Action {

            public ActionForward execute(
                  ActionMapping mapping,
                  ActionForm form,
                  HttpServletRequest request,
                  HttpServletResponse response)
                  throws Exception {

                  // Define action errors and forward
                  ActionErrors errors = new ActionErrors();
                  ActionForward forward = new ActionForward();
                  
                  try {
                            forward = performAction(mapping, form, request, response);
                  } catch (Exception e) {
                        // Report the error using the appropriate name and ID.
                        errors.add("name", new ActionError("id"));
                  }

                  // If a message is required, save the specified key(s)
                  // into the request for use by the <struts:errors> tag.
                  
                  //Saves the error
//Listing 4: Contents of new performAction method.
                  if (!errors.empty()) {
                        saveErrors(request, errors);
                        // Forward control to the appropriate 'failure' URI
                        forward = mapping.findForward("failure");
                  } else {
                        // Forward control to the appropriate 'success' URI
                        if (forward == null) {
                              forward = mapping.findForward("success");
                        }
                  }

                  // Finish with
                  return (forward);

            }




================ subclass ==================
public class CreateCustomerAction extends AbstractAction {

      public ActionForward performAction(ActionMapping mapping, ActionForm form,
                  HttpServletRequest request, HttpServletResponse response)
                  throws Exception {
            
          DynaActionForm createCustomerForm = (DynaActionForm) form;// TODO Auto-generated method stub

            // TODO Auto-generated method stub
            String fn = (String) createCustomerForm.get("firstName");
            String ln = (String) createCustomerForm.get("lastName");
        String ad = (String) createCustomerForm.get("address");
        int custId = Math.abs( (int)System.currentTimeMillis());
       
        domain.Customer currentCustomer  = new Customer();
        currentCustomer.setFirstName(fn);
        currentCustomer.setLastName(ln);
        currentCustomer.setAddress(ad);
        currentCustomer.setId(custId);
       
    try {
                  // perform list customer operations
                  CommandExecutor.getInstance().executeHibernateCommand(
                                          new CreateCustomer(currentCustomer));
                  request.setAttribute("customer",currentCustomer );
                        
            }
          catch (Exception e)
          {
                  throw new ServletException(e);
            }

            return mapping.findForward("customerCreated");

      }

}

Forward "customerCreated" is redirecting to the same page the action was called (/form/createOrder.jsp). Is this the desired behaviour?

brunoguimaraes;

I don't think that is true. May wrong naming but notice  "customerCreated" versus "createCustomer"

Here is your action definition:

<action
      path="/createCustomer"      
      name="createCustomerForm"
      input="/form/createCustomer.jsp"
      scope="request"      
      type="actions.CreateCustomerAction">
      <forward name="customerCreated" path="/form/createOrder.jsp" />
</action>

The forward name is called "customerCreated", and it forwards do the page /form/createOrder.jsp.

Now your action class:

public class CreateCustomerAction extends AbstractAction {

public ActionForward performAction(ActionMapping mapping, ActionForm form,
                  HttpServletRequest request, HttpServletResponse response)
                  throws Exception {
           
        DynaActionForm createCustomerForm = (DynaActionForm) form;

        String fn = (String) createCustomerForm.get("firstName");
        String ln = (String) createCustomerForm.get("lastName");

        String ad = (String) createCustomerForm.get("address");
        int custId = Math.abs( (int)System.currentTimeMillis());
       
        domain.Customer currentCustomer  = new Customer();
        currentCustomer.setFirstName(fn);
        currentCustomer.setLastName(ln);
        currentCustomer.setAddress(ad);
        currentCustomer.setId(custId);
       
    try {
                  CommandExecutor.getInstance().executeHibernateCommand(new CreateCustomer(currentCustomer));
                  request.setAttribute("customer",currentCustomer );
                       
    }  catch (Exception e) {
                  throw new ServletException(e);
    }

     return mapping.findForward("customerCreated");

}
      
As you see on the last line, it returns the same forward, "customerCreated".

Summerian, you are right,... i added the failure page but now i don't really know what happened?

i mean i am been forward to the failure.jsp page,... i don't know why it is failing to the success page

Add the following lines - code below.

This is not a good pattern to follow, but it will show you why exception is thrown.

But. I must point out that this kind of pattern you were applying swallows exceptions - you don't have stacktrace in app logs, or any error message on pages. You must add something like e.printStacktrace() to your catch clause, to have some info in app logs afterwards, or you will never have a clue what's happening if something's gone wrong.

try {
    CommandExecutor.getInstance().executeHibernateCommand(new CreateCustomer(currentCustomer));
    request.setAttribute("customer",currentCustomer );
                       
}  catch (Exception e) {
    request.setAttribute("errorMessage", e.getMessage());    
    throw new ServletException(e);
}
 
(failure.jsp)
error reason: <%=request.getAttribute("errorMessage")%>

Select allOpen in new window

Excellent Help,... I appreciate it