asked on
Assist in fixing javascript

I have some excellent code written by leakim971. It has one error in it.

leakim:

Can you see what is wrong with the window.open line? It gives a script error. I fixed it by using the old, original code you provided, but it woudl be good to open the resulting text window at a certain size
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Document sans titre</title>
<script language="javascript">
 
	var aCities = new Array(12);
 
 	function initialiseDD() {
		yearChange();
		restrictFilename();
	}
 
	function yearChange() {
		var dy = document.getElementById("ddYear");
//		alert(dy.options[dy.selectedIndex].value);
		switch(dy.options[dy.selectedIndex].value)
		{ 
			case "2008" :	aCities = ["Lakeview","Crofton","_Marion","Lynnville","Iuka","Vanleer","Maplesville","MichiganCity","Livingston","Nunnley","Gamaliel","Camden"];break
			case "2009" :	aCities = ["Lakeview","Cadiz","_Iuka","Lynnville","Vanleer","Maplesville","Saulsbury","Camden","Nunley","Marion","Gamaliel","Crofton"];break
			default :		aCities = ["event1","event2","_event3","event4","event5","event6","event7","event8","event9","event10","event11","event12"];break
		}
		var de = document.getElementById("ddEvent");
		for(i=de.options.length-1;i>=0;i--) {
			de.remove(i);
		}
		for(i=0;i<aCities.length;i++) {
			var city = document.createElement("OPTION");
			if(aCities[i].match("_")=="_") {
				city.text = aCities[i].replace("_","");
				city.selected = "selected";
			}
			else {
				city.text = aCities[i];
			}
			city.value=String(i+1);
			de.options.add(city);
		}
	}
	
	function restrictFilename() {
		var dt = document.getElementById("ddType");
		switch(dt.options[dt.selectedIndex].value)
		{ 
			case "M" :	aFilenames = ["-P2.TXT","Places","-OV.TXT","_Overall","-LP.TXT","Laptimes"];break
			case "A" :	aFilenames = ["-P2.TXT","Places","-OV.TXT","_Overall","-LP.TXT","Laptimes"];break
			case "Y" :	aFilenames = ["-P2.TXT","Places","-OV.TXT","_Overall","-LP.TXT","Laptimes"];break
		}
		var df = document.getElementById("ddFilename");
		for(i=df.options.length-1;i>=0;i--) {
			df.remove(i);
		}
		for(i=0;i<aFilenames.length/2;i++) {
			var filename = document.createElement("OPTION");
			if(aFilenames[i*2+1].match("_")=="_") {
				filename.text =aFilenames[i*2+1].replace("_","");
				filename.selected = "selected";
			}
			else {
				filename.text = aFilenames[i*2+1];
			}
			filename.value=aFilenames[i];
			df.options.add(filename);
		}
	}
	
	function gotofile() {
		var dy = document.getElementById("ddYear");
		var de = document.getElementById("ddEvent");
		var dt = document.getElementById("ddType");
		var df = document.getElementById("ddFilename");		
 
//		alert("http://www.google.com/" + dy.options[dy.selectedIndex].value + "/" + de.options[de.selectedIndex].value + "/" + dt.options[dt.selectedIndex].value + df.options[df.selectedIndex].value);
//		window.location = "http://www.google.com/" + dy.options[dy.selectedIndex].value + "/" + de.options[de.selectedIndex].value + "/" + dt.options[dt.selectedIndex].value + df.options[df.selectedIndex].value;
		var url = "http://www.google.com/" + dy.options[dy.selectedIndex].value + "/" + de.options[de.selectedIndex].value + "/" + dt.options[dt.selectedIndex].value + df.options[df.selectedIndex].value
		window.open(url,'Results Events','width=400,height=200');
	}
</script>
</head>
 
<body onload="initialiseDD();">
 
  <label>
  </label>
  <table width="335" border="2">
    <tr>
    <td width="83" align="right"><em><strong>Year : </strong></em></td>
    <td width="234"><select name="ddYear" id="ddYear" onchange="yearChange()">
<!--      <option value="2007">2007</option> -->
      <option value="2008">08 Winter</option>
      <option value="2009" selected="selected">09 Winter</option>
    </select></td>
  </tr>
  <tr>
    <td align="right"><em><strong>Event :</strong></em></td>
    <td><select name="ddEvent" id="ddEvent">
      <option value="1">event will be replace at onLoad page event</option>
    </select></td>
  </tr>
  <tr>
    <td align="right"><em><strong>Type :</strong></em></td>
    <td><select name="ddType" id="ddType" onchange="restrictFilename()" >
      <option value="M">MC</option>
      <option value="A">ATV</option>
      <option value="Y">Youth</option>
    </select></td>
  </tr>
  <tr>
    <td align="right"><em><strong>Filename :</strong></em></td>
    <td><select name="ddFilename" id="ddFilename">
      <option value="-P2.TXT">Places</option>
      <option value="-OV.TXT">Overall</option>
      <option value="-LP.TXT">Laptimes</option>
    </select></td>
  </tr>
  <tr>
  <td colspan="2" align="center"><input type="submit" name="button" id="button" value="Request file" onclick="gotofile()" /></td>
  </tr>
</table>
 
 
</body>
</html>