We help IT Professionals succeed at work.

We've partnered with Certified Experts, Carl Webster and Richard Faulkner, to bring you two Citrix podcasts. Learn about 2020 trends and get answers to your biggest Citrix questions!Listen Now

x

Readln Problem

peteyj
peteyj asked
on
Medium Priority
492 Views
Last Modified: 2010-04-04
When I use the Readln procedure to read a line from a text file, everything goes ok.  But when I use it within a loop to read the body of the text it gives me everything but when there's a empty line (or simply a couple of carraige returns, whatever) it doesn't give back a result.  So when I'm writing to an array of strings, it acts like it skips all carraige returns.  Does anyone know how to resolve this or a better procedure to use.  Any tips would be helpful.
Comment
Watch Question

Commented:
try this code

procedure TForm1.Button1Click(Sender: TObject);
var F: TextFile;
    I: Integer;
    A: Array [0 .. 100] of String;
begin
  AssignFile(F, 'C:\MyFileName.Txt');
  Reset(F);
  I := 0;
  while not EOF(F) do
  begin
    ReadLn(F, A[I]);
    Inc(I);
  end;
  CloseFile(F);
end;

This code works for me.

Why don't you use a StringList instead of an array like this

procedure TForm1.Button1Click(Sender: TObject);
var F: TextFile;
    I: Integer;
    S: String;
    A: TStringList;
begin
  AssignFile(F, 'C:\MyFileName.Txt');
  A := TStringList.Create;
  Reset(F);
  while not EOF(F) do
  begin
    ReadLn(F, S);
    A.Add(S);
  end;
  CloseFile(F);
end;

Hope this helps
Good Luck

Not the solution you were looking for? Getting a personalized solution is easy.

Ask the Experts

Commented:
Try "LoadFromFile" method of TStringList.

/// John

Author

Commented:
Using Writeln, I am also getting errors.  Any suggestions for these?  And how many strings can I have in a stringlist?

Commented:
Submit the code so we can have a look!

/// John

Commented:
A StringList Should be able to hold 32767,
but I have never tried to hold that many.

Does the ReadLn code work?

Author

Commented:
The readln procedures are working ok, but now the writeln still aren't.  Here's the code if anyone can take a crack at it.

function TMainForm.OverWriteTextFile(SatFileName: String;
                                     SatRTextFile: RTextFile): Boolean;
var
  SalTextFile         : TextFile;
  SalFileName         : String;
  SalRTextFile        : RTextFile;
  SalWriteString      : String;
  i                   : integer;
begin
  Result := False;
  SalFileName  := SatFileName;
  SalRTextFile := SatRTextFile;
  AssignFile(SalTextFile, SalFileName);
  try
    Rewrite(SalTextFile);
  except on EInOutError do
    begin
      CloseFile(SalTextFile);
      Result := False;
      exit;
    end;
  end;
  for i := 1 to 8192 do
  begin
    SalWriteString := SalRTextFile.OutputBuffer[i];
    if (SalWriteString <> '') then
    begin
      try
        Writeln(SalTextFile, SalWriteString);
      except on EInOutError do
        begin
          CloseFile(SalTextFile);
          exit;
        end;
      end;

    end;
  end;
  CloseFile(SalTextFile);
  Result := True;
end;


All variables of type RTextFile are records, and InputBuffer and OutputBuffer are arrays of strings, which I plan to change to SringLists.  If you've got any questions on anything else let me know.

Commented:
Sorry I have not responded for a while but I was on site in another City.

What error are you getting when you use the WriteLn?

If the problem is that it is not writing the blank lines then try
taking out the check "if the SalWriteString <> '' then".

Other than that it looks like your code sould work.

Here is a bit of code that will write a Memo to a text file

unit MyTextFile.Pas;

interface

uses
  Windows, Messages, SysUtils, Classes, Graphics, Controls, Forms, Dialogs,
  StdCtrls;

type
  TForm1 = class(TForm)
    Button1: TButton;
    Memo1: TMemo;
    procedure Button1Click(Sender: TObject);
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;

implementation

{$R *.DFM}

function WriteTextFile(SatFileName: String; StringListToWrite: TStringList): Boolean;
var FileToWrite: TextFile;
    I: Integer;
begin
  AssignFile(FileToWrite, SatFileName);
  //Add try finally to close the file
  try
    try
      Rewrite(FileToWrite);
    except
      on EInOutError do
      begin
        Result := False;
        Exit;
      end;
    end;
    // for item in the StringList
    for I := 0 to StringListToWrite.Count - 1 do
    begin
      try
        //Write the line
        Writeln(FileToWrite, StringListToWrite[I]);
      except
        on EInOutError do
        begin
          Result := False;
          Exit;
        end;
      end;
    end;
  finally
    CloseFile(FileToWrite);
  end;
end;

procedure TForm1.Button1Click(Sender: TObject);
begin
  WriteTextFile('C:\MyTextFile.txt', TStringList(Memo1.Lines));
end;

end.

Try this out.
Access more of Experts Exchange with a free account
Thanks for using Experts Exchange.

Create a free account to continue.

Limited access with a free account allows you to:

  • View three pieces of content (articles, solutions, posts, and videos)
  • Ask the experts questions (counted toward content limit)
  • Customize your dashboard and profile

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.