Solved

Thread Exiting Problems

Posted on 1997-09-15
1
157 Views
Last Modified: 2010-04-04
Hello,

    I have a thread which does some painting on the screen. During the Execute method I repeatedly call a procedure (which is in another unit). This procedure itself has a longish (1 or 2 seconds) for...do loop, and I need to include Application.ProcessMessages in this loop, because if the user clicks the form during this loop, I want the application to end (a la screensaver). So in the execute method of MyThread I have:

 while not Terminated do begin
      Synchronize (PaintIt);
      Delay(1000)           // 1 second
 end

PaintIt is a thread procedure which has the following code:

//some code before this
PaintLoop(Canvas);

and finally, PaintLoop, is a procedure in another unit which looks like:

for i := 1 to 1000 do begin
  BitBlt(bla bla bla);
  Application.ProcessMessages;
end;

So, in the mouse click event of the main form, I say:

MyThread.Terminate;
Close;

The PROBLEM is that after the FormClose event, the application doesn't end, and attempts to go back to the for...do loop in the PaintLoop procedure. Problem, of course, is that all of the canvases have by now been Free'd, and I therefore get an access violation. Why is it going back to the for...do loop, and what can I do to stop this!?

Note: If I click on the form after the for...do loop (i.e. during the 1 second delay) then the application terminates nicely.
0
Comment
Question by:wolfcrag
1 Comment
 
LVL 5

Accepted Solution

by:
JimBob091197 earned 100 total points
ID: 1344994
It would appear that your for loop in PaintIt needs to get all the way to 1000, even if the thread terminates when i = 10.

Here are 2 possible solutions:
1)  Change the for loop in PaintLoop to a while loop, and exit the loop early if the thread terminates.

2)  Create a variable or something which the thread sets to True when it's finished.  E.g. In your form's MouseClick event add the following:
    MyThread.Terminate;
    while  not OkToExit  do
        Application.ProcessMessages;
    Close;
Your thread's Execute method would then look something like this:
    OkToExit := False;
    while not Terminated do begin
        Synchronize(PaintIt);
        Delay(1000);
    end;
    OkToExit := True;

0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Creating an auto free TStringList The TStringList is a basic and frequently used object in Delphi. On many occasions, you may want to create a temporary list, process some items in the list and be done with the list. In such cases, you have to…
Introduction Raise your hands if you were as upset with FireMonkey as I was when I discovered that there was no TListview.  I use TListView in almost all of my applications I've written, and I was not going to compromise by resorting to TStringGrid…
This video shows how to use Hyena, from SystemTools Software, to bulk import 100 user accounts from an external text file. View in 1080p for best video quality.
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

685 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question