We help IT Professionals succeed at work.

We've partnered with Certified Experts, Carl Webster and Richard Faulkner, to bring you two Citrix podcasts. Learn about 2020 trends and get answers to your biggest Citrix questions!Listen Now

x

RS232 communications

Grailman
Grailman asked
on
Medium Priority
501 Views
Last Modified: 2013-11-20
I'm trying to implement serial communications from an app and to test it out I wanted to write & read from the same com port by tying the TX & RX pins together(this works in Hyper terminal). My problem is that when I get to ReadFile the program hangs & I'm not good enough w/ the assembly code to figure out why...?

hCom = CreateFile("COM1",GENERIC_READ | GENERIC_WRITE,
          0,NULL,OPEN_EXISTING,FILE_FLAG_OVERLAPPED,NULL);
   
if (hCom == INVALID_HANDLE_VALUE) // deal w/ err

char strBuffer[80] = "ABAB";
DWORD dwWrite;
OVERLAPPED OLWrite;

PurgeComm(hCom, PURGE_RXCLEAR);

if(!WriteFile(hCom,strBuffer,4,&dwWrite,&OLWrite))
      // deal w/ err

// delay a second before reading

if(!ReadFile(hCom,(void*)strBuffer,5,&dwRead,&OLRead))

This is the assembly code from 'ReadFile' call:
lea       eax,dword ptr [OLRead]
push      eax
lea       eax,dword ptr [dwRead]
push      eax
push      00000005
lea       eax,dword ptr [strBuffer]
push      eax
mov       eax,dword ptr [hCom]
push      eax
call      dword ptr [__imp__ReadFile@20 (004075a0)]

*** hangs at the next line ***
test      eax,eax      
jne       CLabTestView::Com+0000012a (00401c88)

Any suggestions?
Comment
Watch Question

Dear Grailman.
I worked a lot with serial ports, sometimes it works tricky and there is no good documentation. There is also subtle difference between windows 95 and windows NT. You cannot use GetOverlappedResults in win 95 to get the number of bytes written to serial port. Also if you do not specify comm. events mask, then WaitCommEvents blocks in win95 and doesn't blocks in windows NT.
Now about your question. I just send you a code that opens the serial port in my program and it works. There are additional calls for initialisation, thius explains your problem:

BOOL CUMDSerPort::OpenDevCommun( LPCSTR lpszPortName, int BaudRate )

{      if ( lpszPortName == NULL )  goto FileOpenError;
//-------------- Saves the port name and buffers sizes.  
  m_strPortName   =  lpszPortName;
//------------- Opens
  m_hPort = CreateFile
  ( lpszPortName,
            GENERIC_READ | GENERIC_WRITE,
            0,                                                                              // exclusive access                
            NULL,                           // no security attributes
            OPEN_EXISTING,
            FILE_FLAG_OVERLAPPED, //| FILE_FLAG_OVERLAPPED,
            NULL                            // No template
  );
      if ( m_hPort == INVALID_HANDLE_VALUE )                        goto FileOpenError;
//---------------      
  m_inBufferSize  =  4096 ;
  m_outBufferSize =  256;
  if ( !SetupComm( m_inBufferSize, m_outBufferSize ) )          goto FileOpenError;
//----------------- Set comm timeouts.
  COMMTIMEOUTS commTimeOuts;
      ZeroMemory( &commTimeOuts, sizeof( commTimeOuts ) );
  if ( !SetCommTimeouts( &commTimeOuts ) )                      goto FileOpenError;

//********************** Code copied from Moshe for tuning of port ************
  DCB  dcb;
  dcb.DCBlength = sizeof( DCB );
  GetCommState( &dcb );
    //For a string such as 96,n,8,1 or any other older-form mode string
    //    that doesn't end with an x or a p:
    //  fInX, fOutX, fOutXDsrFlow,
    //           and fOutXCtsFlow   are all set to FALSE
    //  fDtrControl                 is set to DTR_CONTROL_ENABLE
    //  sfRtsControl                is set to RTS_CONTROL_ENABLE
  dcb.BaudRate  = BaudRate;
  dcb.ByteSize  = 8;
  dcb.Parity    = NOPARITY;
  dcb.StopBits  = ONESTOPBIT;
     // Resume as if wire has not been pulled out, in case it has.  If
    // setting is TRUE, default, I will have to use a ClearCommError()
    // in the serial thread procedure.                            Hmm..?
  dcb.fAbortOnError=FALSE;  
 
  if ( !SetCommState( &dcb ) )                                  goto FileOpenError;
//****************************************************************************************  
//----------- The port is opened successfully
  return TRUE;
//*************** If error occured during opening, the control jump here.
FileOpenError :
//------------- We do not send message box from Server Application.
  Close();      
  return FALSE;
}

It is a member function of the CUMDSerPort, so instead of
SetupComm( m_inBufferSize, m_outBufferSize ) use API -
SetupComm( m_hPort, m_inBufferSize, m_outBufferSize ),
I just created wrappers in my class for all API.
If you are interested I can send you the source code for theis class. YOu can write to my e-mail igor_u@ultramind.co.il
Yours Igor

Not the solution you were looking for? Getting a personalized solution is easy.

Ask the Experts

Author

Commented:
I think this should get me going.

Thanks, Grailman
Access more of Experts Exchange with a free account
Thanks for using Experts Exchange.

Create a free account to continue.

Limited access with a free account allows you to:

  • View three pieces of content (articles, solutions, posts, and videos)
  • Ask the experts questions (counted toward content limit)
  • Customize your dashboard and profile

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.