?
Solved

a string class problem

Posted on 1998-02-05
9
Medium Priority
?
273 Views
Last Modified: 2010-04-10
Following code gave wrong output, can you explain why. Any comments for the "correct" part of the code also wellcome :-)

#include <iostream.h>
#include <string.h>

class Mystring
{
private:
char *pstring;
int length;
public:
Mystring()
{  length = 0;
   pstring = NULL;
}
Mystring(char *pchar)
{  if (pstring!=NULL) delete pstring;
   length = strlen(pchar);
   pstring = new char[length + 1];
   strcpy(pstring, pchar);
}
Mystring(Mystring &mystring1)
{  if (pstring!=NULL) delete pstring;
   length = mystring1.length;
   pstring = new char [length + 1];
   strcpy (pstring, mystring1.pstring);
}
~Mystring()
{  delete pstring;
}
int Len (void)
{  return length;
}
void Show (void)
{  cout<<pstring<<endl;
}
};

int main ()
{  Mystring Mystring1;
   Mystring Mystring2("a string");
   Mystring Mystring3(Mystring2);     //Remove these 2 lines  
   Mystring2.Show(); Mystring3.Show();//the output become OK    
   Mystring1="another string";
   Mystring1.Show();
   return 0;
}

Without operator overloading, Do you think Mystring1="another string" is OK?
0
Comment
Question by:learn
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 4
9 Comments
 

Author Comment

by:learn
ID: 1180696
Edited text of question
0
 
LVL 3

Accepted Solution

by:
q2guo earned 150 total points
ID: 1180697
I don't see anything wrong except you should make the
following changes

~Mystring()
{
      if (pstring !=NULL) delete pstring;
}  

also, you should move your implementation of the member functions
out of the class definition.
e.g.
void MyString::show(void)
{
      .....
}

I don't think Mystring1="another string" is ok
since what this line actually does is
creates a temperory Mystring Object that contains "another string" and assigns this temmperory object to MyString1
because your MyString class contains pointer type data members
so, =operator will have to be overloaded.

Tell me if this helps

Terry
0
 
LVL 3

Expert Comment

by:q2guo
ID: 1180698
Forget to ask you, what output are you getting anyway?
0
VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

 

Author Comment

by:learn
ID: 1180699
Hi Q2guo,

1. The output from my code is something like "ano..er string" including some strange characters!

2. There is no operator (=) overloading in the code, how the string "another string" can go into the class and gave its value to the pointer pstring for Mystring1?

Cheers
0
 
LVL 3

Expert Comment

by:q2guo
ID: 1180700
C++ compiler automatically creates the =operator function
for every object.  But, in this case, you don't want to use
the =operator provided by the compiler 'cause it will generate a bug in your program.

DOes mystring2.show() output ok in your program above?
0
 

Author Comment

by:learn
ID: 1180701
Yes, both Mystring2.Show() and Mystring3.Show() are OK.
0
 
LVL 3

Expert Comment

by:q2guo
ID: 1180702
You are saying both Mystring2.show() and Mystring3.show()
work ok or are you saying they both give the correct output?
0
 

Author Comment

by:learn
ID: 1180703
Both outputs for Mystring2 and Mystring3 were correct.
0
 
LVL 3

Expert Comment

by:q2guo
ID: 1180704
I tried out the program on my computer

the only problem I have is the
Mystring1="another string";
line, other than this everything works out fine


0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
Unlike C#, C++ doesn't have native support for sealing classes (so they cannot be sub-classed). At the cost of a virtual base class pointer it is possible to implement a pseudo sealing mechanism The trick is to virtually inherit from a base class…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

719 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question