Tech or Treat! Write an article about your scariest tech disaster to win gadgets!Learn more


Question on storing a couple of string into an array

Posted on 1998-03-23
Medium Priority
Last Modified: 2010-04-10
With reference to the brief program segment below:

int index=0;
char *name[10];  // can hold up to a maximum of 10 strings
char str[50];
FILE *fp;

/* assume that file has been opened for reading */
while(fgets(str, 40, fp)) != NULL)

/* end of program segment */
Content of a file,
dog              0.123
cat              0.456
monkey           0.789

How can I store the just the name of the 3 animals in an
array called name? If possible, please include a program
segment or so to illustrate your point.

Is there anything wrong with my attempt of doing this?
Thanks for any help offered!
Question by:justinng
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
LVL 84

Expert Comment

ID: 1183741
You'll probably get an error trying to write to an uninitialized pointer.
Try either
   char name[10][40];
   name[index++] = strdup(str);

Author Comment

ID: 1183742
erm.... thanx....and how about if I want to store only the
float value?

LVL 22

Expert Comment

ID: 1183743
The problem is that

char *name[10]  

is an array of 10 pointers to strings.  That is, it is an array that has 10 items.  Those items are pointers to strings, but those pointers have not yet been iniitalized to point to strings.  This your code write to what ever they point to.  That's bad.

You could go through array and initialize each pointer, like

for (int i = 0; i < 10; ++i)
   name[i] = new char[100];

This makes eack pointer point to a dynamically allocated string of 100 characters.  However, to clean up you will have to go though and deleted [] each string at the end.  

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.


Expert Comment

ID: 1183744
This should do it

int index=0;
char name[10][50];  // can hold up to a maximum of 10 strings
float value[10];
FILE *fp;

/* assume that file has been opened for reading */
while(feof(fp) != NULL) {
      fscanf(fp, "%s", name[index])
      fscanf(fp, "%f" value);
LVL 22

Expert Comment

ID: 1183745
ozo's idea is to not use an array of string pointer's but to use an array of strings.  The array he suggested stores 10 strings that are 40 characters long.  It actually has space for the strings, rather than pointers to the strings.  

Thee are advantages and dissadvantages to each.  An array of string pointers is good for cases where the strings will have different lengths because you can allocate memory for each string for just the length you need.  The array of strings is simpler and safer (less room for bugs) but you must declare each line long enough to hold the longest line and it therefore wastes space.

LVL 22

Expert Comment

ID: 1183746
To store the float values you could create and array of floats and store them just like the strings.  You could create a structure that stores both a string and a float and create an array of these.  Then you could store both the name and the value in one array.
LVL 22

Expert Comment

ID: 1183747
I see q2quo has answered here and pointed out somthing I missed (ozo might of missed to)  You were running into the floats and needed to read them to get to the next string.  His algorithm will read and discard each float so that you can go on to the next string.

Author Comment

ID: 1183748
but how can i store just the float values into an array??
As nietod has pointed it out, my intention is to store the
name of the animal and the float values of it into 2 different
arrays one which is for the name of the animal and the other is
for the float values.
How should I go about it?

And can I declare a long value of char???
I've tried the following,

long char *name[10];
char long *name[10];

but none of the above works in microsoft visual c++ 4.0....
it gives me an error saying its illegal.
Please correct me.

Author Comment

ID: 1183749
Oops....guess I missed out an important point in the content of the file,
cats and dogs          0.123
mouse rats             0.456
elephant               0.789
----------------- should look like this.... anyway...I've managed to store the names into an array of strings (Thanks!) but it's just
the float values which is giving me a headache now :P

LVL 11

Expert Comment

ID: 1183750
take q2_guo's answer and replace
      fscanf(fp, "%f" value);
      fscanf(fp, "%f", value[index++]);

(I think his answer was valid)

There is no such animal as a "long value of char".  What were you trying to do?


Accepted Solution

sllsgl earned 50 total points
ID: 1183751
char *name[10];  // can hold up to a maximum of 10 strings
 {WRONG, this without the * will only means that name can contain maximum 10 chars.}

To store 10 names, you can use CString Class, this is a very powerful class you will soon like it very much. You don't even have to worry if you have allocated enough memory space to store long, long name.

CString name[10];
if you still prefer char, use char name[10][50];   // this will allocate enough space for 10 names with maximum of 50 characters.  Make sure you do not exceed 20 chars in a single name.

To read string from the file, you can use
while (!feof(fp)) {
       fscanf(fp, "%s", name[i]);   // This will just read the characters until the white space.

alternatively, read in the complete string first.
char str[81];

while (!feof(fp)) {
   fgets(str, 80, fp);   // will stop at end of line
   sprintf(name[i], "%s", str);  // read the name from str
   sprintf(number[i], " %f", str+strlen(name));

To store just the float value, declare this first.
float number[10];


Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Article by: SunnyDark
This article's goal is to present you with an easy to use XML wrapper for C++ and also present some interesting techniques that you might use with MS C++. The reason I built this class is to ease the pain of using XML files with C++, since there is…
Introduction This article is a continuation of the C/C++ Visual Studio Express debugger series. Part 1 provided a quick start guide in using the debugger. Part 2 focused on additional topics in breakpoints. As your assignments become a little more …
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
Suggested Courses

647 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question