We help IT Professionals succeed at work.

Fast Get File Modification Time

hustch
hustch asked
on
575 Views
Last Modified: 2013-12-03
Giving the path of a file, does anyone know a faster way to get the LastWrite time, than the following ?

// Try with GetFileTime, fast but I think it may fail if file is locked, but I haven't been able to provoke it

TimeFound = 0;
h = CreateFile(FileName, 0, FILE_SHARE_READ or FILE_SHARE_WRITE, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
if (h >= 0) {
  if (GetFileTime(h, CreateTime, LastAccess, LastWrite)) {
   TimeFound = 1;
  }
}

if (!TimeFound) {
  // Get time using FindFirstFile, slow but don't care if file locked.
}
Comment
Watch Question

Commented:
That looks like that should work well.  It shouldn't be too slow even when the FindFirstFile needs to be used.  

The "FILE_SHARE_READ or FILE_SHARE_WRITE" should be expressed as "FILE_SHARE_READ || FILE_SHARE_WRITE"  in C or C++, however.

Commented:
What do you mean by a faster way? One function call or faster speed?

If you are looking for one function call:

On Windows NT 4.0 or later, you can use the GetFileAttributesEx function to get the information.

You can also use FindFirstFile. But you have to use FindClose.

By the way, it should be | instead of ||.

Commented:
Opps.  Correct a mistake with a mistake.  Yes,

"FILE_SHARE_READ | FILE_SHARE_WRITE"

Chensu got me thinking too.  Looking at what you had I was lured into thinking that by opening the file with CreateFile() the OS would not have to search the directory tree and would therefore be faster.  That was stupid on my part.  The OS will still search, only it will do it on the open rather than on the procedure that gets the time.  In addition there is considerable overhead for opening and closing a file.  You are probably best off just using FindFirstFile (and associated procedures) in all cases.

Author

Commented:
The or got there because it is actually Delphi code, that I translated because it is not the Delphi forum.
I know I have to use FindClose.

By faster, I mean shorter execution times.

The CreateFile is a lot faster, I don't know why, but I timed it. There is a lot of files in the directory.
The parameters to CreateFile was chosen in an attempt to avoid sharing problems.
I'll try GetFileAttributesEx

Commented:
There are probably plenty of people here who "speak" delphi, so you ussually shouldn't have to translate.

When you use FindFirstFile(), do you use a path that specifcally indicates the file?  You don't use wildcards and then look fo the file do you?

Author

Commented:
The GetFileAttirbutesEx is faster than the CreateFile approach.
It is what i wanted when I started, but I can't find using Delphi help, but I found it using MSVC++ help.

chensu, make an answer with GetFileAtttibutesEx, and I will accept it.
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION

Gain unlimited access to on-demand training courses with an Experts Exchange subscription.

Get Access
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Empower Your Career
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE

Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Unlock the solution to this question.
Join our community and discover your potential

Experts Exchange is the only place where you can interact directly with leading experts in the technology field. Become a member today and access the collective knowledge of thousands of technology experts.

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.