Fix it please

I have my progect in a zip file at <A HREF="www.shasta.cc.ca.us/cfdocs/test/myvb.zip"> www.shasta.cc.ca.us/cfdocs/test/myvb.zip</A>. Every time i run it it hangs when it tries to run the szreplace function. I f anyone could make this run again i'll shell ou all of my points (currently 135). It was done in VB4.
 
hessAsked:
Who is Participating?

[Webinar] Streamline your web hosting managementRegister Today

x
 
bruncheyConnect With a Mentor Commented:
the problem with your function is that it always starts at the beginning of the passed in string...

nThere = InStr(szTemp, szFind)

The actual syntax for InStr(startloc, string1, string2) where startloc is where you want it to start searching in string 1.  If you omit this, it will always start at the first letter in the string.  You need to change this location on every interation of the loop like so

Dim ll_begin as long
ll_begin = 1
Do
     nThere = InStr(ll_begin,szTemp, szFind)

     If nthere > 0 then    'we found one!!!
          szTemp = Left$(szTemp, nThere - 1) & _
                  szRepl & Mid$(szTemp,nThere + Len(szFind))
          ll_begin = nthere + len(szRepl)
     else
          exit do
     end if
loop
     
Loop


0
 
SekansCommented:
hess
Do you have the Microsoft DAO Object library loaded?  If not, try that.

Regards,
Sekans
0
 
SekansCommented:
brunchey,
I don't think that is the problem.  Every time a match is found, it is replaced with something else.  So even if it starts at the beginning again, it won't find the same occurrance, because it won't be there anymore.

assume temp = "test text"
search for "t" and replace with "X"

first pass starts at first character finds "t" at position 1 changes to X"
now temp = "Xest text"
second pass starts at first character finds "t" at position 4
now temp = "XesX test"

Regards,
Sekans

0
The new generation of project management tools

With monday.com’s project management tool, you can see what everyone on your team is working in a single glance. Its intuitive dashboards are customizable, so you can create systems that work for you.

 
SekansCommented:
brunchey,
Please accept my apology.  I failed to check the values of sfind and sreplace.  You are absolutely correct.  Your answer should solve the problem.  Good work.

Regards,
Sekans
0
 
SekansCommented:
hess,
You do need to initialize the variable ll_begin.

Dim ll_begin as Integer
ll_begin = 0

put this before the Do...Loop

Sekans
0
 
hessAuthor Commented:
Why are there to loop statements at the end of the answer is one not suposed to be there
0
 
hessAuthor Commented:
I'll test it now and if it works i'll give you the 135 points
0
 
hessAuthor Commented:
could you please rewrite the answer so that the whole szReplace function is included, From "Public Function" to "End Functioin" I've been working with vb for only a couple of days and i would like to be able to just paste it in.
0
 
hessAuthor Commented:
Never Mind. It works great and thanks for the help sekans and Brunchey. But why did you say to set II_Begin to 0 instead of 1 sekans
0
 
SekansCommented:
That was a mistake, 1 is correct.
0
 
bruncheyCommented:
Function szReplace(szText As String, szFind As String, szRepl As String) As String
'-- This function replaces all occurances of szFind with szRepl within
          '   szText and returns the resulting string.

              Dim nThere As Long
              Dim szTemp As String
              Dim ll_begin
              '-- Copy the incoming text so that szText is not altered.
              szTemp = szText
              ll_begin = 1
              '-- Go into a loop
              Do
                  '-- Is szFind part of szTemp?
                  nThere = InStr(ll_begin, szTemp, szFind)
                  If nThere Then
                      '-- Yes. nThere is now the position of szFind within szTemp
                     
                      '        [---------- A ----------]   [-B -]   [------------- C ----------------]
                      szTemp = Left$(szTemp, nThere - 1) & szRepl & Mid$(szTemp, nThere + Len(szFind))
                      ll_begin = nThere + Len(szRepl)
                  Else
                      '-- No. There is nothing more to do, so exit the loop
                      Exit Do
                  End If
              Loop

              '-- Assign szReplace to the szTemp string, which contains the
              '   modified original text.
              szReplace = szTemp
End Function

0
All Courses

From novice to tech pro — start learning today.