Solved

Getting a CBitmap from a HBITMAP, using FromHandle()

Posted on 1998-07-09
4
4,438 Views
Last Modified: 2013-11-19
I need to get a CBitmap from a HBITMAP, and to be able to delete my CBitmap again, when I need to.

My code looks like this:

class SomeClass
{
   CBitmap *m_bmpBitmap;

   SomeFunction();
   ~SomeClass();
};


SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
m_bmpBitmap=new CBitmap();
m_bmpBitmap=CBitmap::FromHandle(hBitmap);
}

SomeClass::SomeClass()
{
   delete m_bmpBitmap;
}

My problem is that when I come to the Destructor, and want to delete the m_bmpBitmap again, my program crashes, becourse the CBitmap is attached to a HBITMAP, and I don't know how to detach it again.

How do delete my m_bmpBitmap in a proper way (So that it won't cause the program to crash) ?
0
Comment
Question by:Morten from Eliten
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
4 Comments
 
LVL 3

Expert Comment

by:Norbert
ID: 1318893
Not rearly clear what your problem is but
You should initialisize pointers to 'valid' value
Constructor:
SomeClass::SomeClass()
{
    m_bmpBitmap=NULL;
}
Destructor:
SomeClass::~SomeClass()
{
  if(m_bmpBitmap)
         delete m_bmpBitmap;
}
now SomeFunction
SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
//m_bmpBitmap=new CBitmap(); NOT NEEDED and Produces MEMORY LEAKS !!!!
if(m_bmpBitmap)
    delete m_bmpBitmap;
m_bmpBitmap=CBitmap::FromHandle(hBitmap);
}

Some OtherFunction
SomeClass::OtherFunction()
{
     if(bmpNoMoreNeeded)
    {
        if(m_bmpBitmap)
        {
            delete m_bmpBitmap
            m_bmpBitmap=NULL;
        }
    }
}

that should prevent double deleting the same pointer
0
 
LVL 23

Expert Comment

by:chensu
ID: 1318894
Regarding Norbert's code, don't delete m_bmpBitmap returned by CBitmap::FromHandle. It will be deleted automatically at idle time. So, the pointer returned by CBitmap::FromHandle may be invalid outside SomeClass::SomeFunction(). You can do it in this way.

class SomeClass
{
   CBitmap *m_bmpBitmap;

   SomeFunction();
   ~SomeClass();
};


SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
m_bmpBitmap=new CBitmap();
m_bmpBitmap->Attach(hBitmap);
}

SomeClass::~SomeClass()
{
   ::DeleteObject(m_bmpBitmap->Detach());
   delete m_bmpBitmap;
}

To be safer, remember to check the return value of each function called.
0
 

Author Comment

by:Morten from Eliten
ID: 1318895
Hey, chensu !
Propose that as an answer, and you've earned yourself 30 points.

That was great !
0
 
LVL 23

Accepted Solution

by:
chensu earned 30 total points
ID: 1318896
Thank you.
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
either24  challenge 19 110
sumHeights  challenge 17 83
Detect file exist or not 3 215
How do I get Window Title of all opened process? 4 60
Introduction: Database storage, where is the exe actually on the disc? Playing a game selected randomly (how to generate random numbers).  Error trapping with try..catch to help the code run even if something goes wrong. Continuing from the seve…
If you use Adobe Reader X it is possible you can't open OLE PDF documents in the standard. The reason is the 'save box mode' in adobe reader X. Many people think the protected Mode of adobe reader x is only to stop the write access. But this fe…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question