Solved

Getting a CBitmap from a HBITMAP, using FromHandle()

Posted on 1998-07-09
4
4,355 Views
Last Modified: 2013-11-19
I need to get a CBitmap from a HBITMAP, and to be able to delete my CBitmap again, when I need to.

My code looks like this:

class SomeClass
{
   CBitmap *m_bmpBitmap;

   SomeFunction();
   ~SomeClass();
};


SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
m_bmpBitmap=new CBitmap();
m_bmpBitmap=CBitmap::FromHandle(hBitmap);
}

SomeClass::SomeClass()
{
   delete m_bmpBitmap;
}

My problem is that when I come to the Destructor, and want to delete the m_bmpBitmap again, my program crashes, becourse the CBitmap is attached to a HBITMAP, and I don't know how to detach it again.

How do delete my m_bmpBitmap in a proper way (So that it won't cause the program to crash) ?
0
Comment
Question by:Morten from Eliten
  • 2
4 Comments
 
LVL 3

Expert Comment

by:Norbert
ID: 1318893
Not rearly clear what your problem is but
You should initialisize pointers to 'valid' value
Constructor:
SomeClass::SomeClass()
{
    m_bmpBitmap=NULL;
}
Destructor:
SomeClass::~SomeClass()
{
  if(m_bmpBitmap)
         delete m_bmpBitmap;
}
now SomeFunction
SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
//m_bmpBitmap=new CBitmap(); NOT NEEDED and Produces MEMORY LEAKS !!!!
if(m_bmpBitmap)
    delete m_bmpBitmap;
m_bmpBitmap=CBitmap::FromHandle(hBitmap);
}

Some OtherFunction
SomeClass::OtherFunction()
{
     if(bmpNoMoreNeeded)
    {
        if(m_bmpBitmap)
        {
            delete m_bmpBitmap
            m_bmpBitmap=NULL;
        }
    }
}

that should prevent double deleting the same pointer
0
 
LVL 23

Expert Comment

by:chensu
ID: 1318894
Regarding Norbert's code, don't delete m_bmpBitmap returned by CBitmap::FromHandle. It will be deleted automatically at idle time. So, the pointer returned by CBitmap::FromHandle may be invalid outside SomeClass::SomeFunction(). You can do it in this way.

class SomeClass
{
   CBitmap *m_bmpBitmap;

   SomeFunction();
   ~SomeClass();
};


SomeClass::SomeFunction()
{
HBITMAP hBitmap;

hBitmap=(HBITMAP) LoadImage(NULL, "BitmapName.Bmp", IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE | LR_CREATEDIBSECTION | LR_DEFAULTSIZE);
m_bmpBitmap=new CBitmap();
m_bmpBitmap->Attach(hBitmap);
}

SomeClass::~SomeClass()
{
   ::DeleteObject(m_bmpBitmap->Detach());
   delete m_bmpBitmap;
}

To be safer, remember to check the return value of each function called.
0
 

Author Comment

by:Morten from Eliten
ID: 1318895
Hey, chensu !
Propose that as an answer, and you've earned yourself 30 points.

That was great !
0
 
LVL 23

Accepted Solution

by:
chensu earned 30 total points
ID: 1318896
Thank you.
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

Suggested Solutions

Introduction: The undo support, implementing a stack. Continuing from the eigth article about sudoku.   We need a mechanism to keep track of the digits entered so as to implement an undo mechanism.  This should be a ‘Last In First Out’ collec…
Have you tried to learn about Unicode, UTF-8, and multibyte text encoding and all the articles are just too "academic" or too technical? This article aims to make the whole topic easy for just about anyone to understand.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
This video discusses moving either the default database or any database to a new volume.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now