Sorting in OWL implementation of ListView

Posted on 1998-08-14
Last Modified: 2008-02-01
I've a problem with sorting in OWL TListView. I've written my custom compare function. When I'm calling ListView->SortItems function for the first time, everything is OK. Items are sorted correctly. Buf the second call of SortItems func. gives items back to the state after initialization (same order as it was after adding in SetupWindow()). What's wrong ?
I'm using Borland BC5.02 compiler under WIN NT 4.0 Workstation.
Question by:petasf
  • 4
  • 3

Author Comment

ID: 1170274
Adjusted points to 100

Expert Comment

ID: 1170275
Could you show your custom compare function?

Author Comment

ID: 1170276
int CALLBACK CompareProc(LPARAM lparam1, LPARAM lparam2, LPARAM lparamSort)
int result;
char buf1[50];
char buf2[50];

   CmpStruct *cs = (CmpStruct*)lparamSort;


   result = lstrcmpi(buf1,buf2);


IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!


Expert Comment

ID: 1170277
I don't know the OWL very well but i would guess that it could help to reset the contents first
and call the SortItems() function after that.
Perhaps the SortItems() function sort relatively - so that the first call sorts the items, the next
call reverses the sort again, and so on ... (just guessing)
Do you have the source code of this SortItems() function - if yes, you could post it here to
let us take a look on it.

Author Comment

ID: 1170278
Yes it looks like you've said. - the naxt call the SortItems() really reverses order of items. But in my opinion it should work this way. The first call sorts items for example in the ascent order (it depends on your custom compare function, of course), the next call reverses sort, so after sort, items are in descent order. But it doesn't work like this.The next call of SortItems() gives items back to the state after initialization -my items are not sorted after initialization.
Here is source code of OWL::TListWindow::SortItems()

BOOL ListView_SortItems(
    HWND hwnd,       
    PFNLVCOMPARE pfnCompare,       
    LPARAM lParamSort      

// Sort the items within the List Window.
// TLwComparator is the base class for the comparison function
bool TListWindow::SortItems(const TLwComparator& comparator, uint32 lParam)
  TListCompareThunk ct;
  ct.This = &comparator;
  ct.ItemData = lParam;
  return ToBool(SendMessage(LVM_SORTITEMS, TParam1(&ct), TParam2(OwlListViewCompare)));


Accepted Solution

snoegler earned 100 total points
ID: 1170279
I think i got the solution :)
As you know, the comparison function are only given the lParam members of the both TV_ITEM
structures to compare. So the easiest solution - and i think you did that - is to set them equal
to the index of the TV_ITEM, because that's the value you need to get the texts of the items to
Now imagine that: If the comparison function returns a  '-1', this means for the sort function
to swap the both TV_ITEMs. So also the lParam members are swapped - do you know what
i mean?
The first call to the SortItems() function mixes your lParam's which were intended as an
index - and unfortunately they are set in a way so that the next sort function will reverse the
former result exactly to what it was before.
(because the sort order is totally wrong - you see that with your debugger)

I would suggest that you set the lParam member to the index of the TV_ITEM structure again
(for each item), so that the order is correct again and then it should work.
Hope that helped ;)


Author Comment

ID: 1170280
Thanks Snoegler
Functionality of ListView makes me sometimes crazy.

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
maze travler 6 47
Setting nameservers after res_init fails doing res_query 2 74
c++ syntax question 9 34
Header of docx file 17 58
Templates For Beginners Or How To Encourage The Compiler To Work For You Introduction This tutorial is targeted at the reader who is, perhaps, familiar with the basics of C++ but would prefer a little slower introduction to the more ad…
Written by John Humphreys C++ Threading and the POSIX Library This article will cover the basic information that you need to know in order to make use of the POSIX threading library available for C and C++ on UNIX and most Linux systems.   [s…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now