Solved

free nodes in a link list

Posted on 1998-08-14
5
178 Views
Last Modified: 2010-04-15
I am writting an appan I have to read info from a database so I am going to the info in a link list and right now I am just building my link list functions...well I can add info to the link list...but when it comes to free all the nodes in the link list when ever I go to free the "main_tail" node my program crashes...anyone have clue as to why this is happening??  The code I am using is below

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <malloc.h>

struct file_collection
{
      char *filename;
      char *dir;
      struct file_collection *prev, *next;
};

void addrec(struct file_collection **, struct file_collection**, char *, char *);
void allocspace(struct file_collection **, struct file_collection **, struct file_collection **);
void freeallnodes(struct file_collection **, struct file_collection **);

void main(void)
{
      struct file_collection *main_top, *main_tail;

      main_top=main_tail=NULL;
      addrec(&main_top, &main_tail, "this is a test", "this is a dir test");
      addrec(&main_top, &main_tail, "this is a test2", "this is a dir test2");
      freeallnodes(&main_top, &main_tail);
}


void addrec(struct file_collection **main_top, struct file_collection **main_tail, char *temp_filename, char *temp_dir)
{
      struct file_collection *curr, *top, *tail;
                 
                 top = *main_top;
      tail = *main_tail;

      allocspace(&top, &curr, &tail);
                  curr->filename = temp_filename;
      curr->dir = temp_dir;

      *main_top = top;
      *main_tail = tail;
}

void allocspace(struct file_collection **top, struct file_collection **curr, struct file_collection **tail)
{
      *curr = (struct file_collection *)malloc(sizeof(struct file_collection));
      (*curr)->prev=(*curr)->next=NULL;
      if (*top == NULL)
      {
            *top = *curr;
            *tail = *curr;
      }
      else
      {
            (*curr)->prev = *tail;
            (*tail)->next = *curr;
            (*tail) = (*curr);
      }
}

void freeallnodes(struct file_collection **main_top, struct file_collection **main_tail)
{
      struct file_collection *p, *curr;

      for(p=(*main_top);p != NULL; p=p->next)
      {
            curr = p->next;
            if (curr != NULL)
                  free(curr);
      }

      if (*main_top != NULL)
            free(*main_top);
      if (*main_tail != NULL)
            free(*main_tail);
}
0
Comment
Question by:meetze
  • 3
  • 2
5 Comments
 
LVL 4

Accepted Solution

by:
emmons earned 50 total points
Comment Utility
FreeAllNodes is releasing a piece of memory, and then dereferencing it in the for loop. You need to grab the "next" pointer before you free up the "curr" pointer.
0
 
LVL 4

Expert Comment

by:emmons
Comment Utility
Try something like:
for( p=(*main_top); p!= NULL; p=curr) {
      curr = p->next;
      if ( p != NULL)
            free( p);
}


0
 

Author Comment

by:meetze
Comment Utility
I did it like this

void freeallnodes(struct file_collection **main_top, struct file_collection **main_tail)
{
      struct file_collection *p, *curr;
      
      for(p=(*main_top);p != NULL;)
      {
            curr = p;
            if (curr != NULL)
            {
                  p=p->next;
                  free(curr);
            }
            
      }

      if (*main_top != NULL)
            free(*main_top);
      if (*main_tail != NULL)
            free(*main_tail);
}

but now even though my main_top is freed and I am checking to see if it is NULL it still falls through the statement...any reason for this??
0
 

Author Comment

by:meetze
Comment Utility
well i noticed that I do not need to free main_top or main_tail...thanks for the help..
0
 

Author Comment

by:meetze
Comment Utility
well i noticed that I do not need to free main_top or main_tail...thanks for the help..
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

This tutorial is posted by Aaron Wojnowski, administrator at SDKExpert.net.  To view more iPhone tutorials, visit www.sdkexpert.net. This is a very simple tutorial on finding the user's current location easily. In this tutorial, you will learn ho…
Summary: This tutorial covers some basics of pointer, pointer arithmetic and function pointer. What is a pointer: A pointer is a variable which holds an address. This address might be address of another variable/address of devices/address of fu…
The goal of this video is to provide viewers with basic examples to understand how to use strings and some functions related to them in the C programming language.
Video by: Grant
The goal of this video is to provide viewers with basic examples to understand and use nested-loops in the C programming language.

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now