Solved

implement it in elegant way

Posted on 1998-08-17
3
182 Views
Last Modified: 2011-09-20
Suppose I want to scan a set of files and see if each of them contains certain patterns
26 patterns altogether).
Finally print the all name of files containing pattern_a,all name of file containing file_b etc...

My stupid program is like:

.......

foreach $f (@files){
  $name=$f;
  $open(FILE,$f)|| die "cannot open";

  while (<FILE>){
     if ($_ eq /pattern_a/){
       push(@list_a,$name);
     }elsif($_ eq /pattern_b){
       push(@list_b,$name);
     }elsif($_ eq /pattern_c){
       push(@list_c,$name);
     }elsif   ....
            .....

     }elsif($_ eq /pattern_z){
       push(@list_z,$name);
     }

  }
}

  printf "files containing pattern_a: @list_a\n";
  printf "files containing pattern_b: @list_b\n";
   ......
   ......
  printf "files containing pattern_z: @list_z\n";

-----------------------------------------------------------
However, I would like to implement it like
   
         ........
       foreach $f (@files){
          $name=$f;
          $open(FILE,$f)|| die "cannot open";

          while (<FILE>){
            if (exists $pattern{$_}{
                push(@list($_),$name)  ## This is illegal!!!
            }      ## or append filename to $pattern{$_},                     ###but how to do it
         }
       }
          ........

Can anyone there enlighten me or provide more elegant code? Thank you in advance.
0
Comment
Question by:tian
  • 2
3 Comments
 
LVL 84

Expert Comment

by:ozo
ID: 1203803
push @{$list{$_}},$name;

0
 
LVL 5

Accepted Solution

by:
b2pi earned 100 total points
ID: 1203804
Essentially, you want @list to be a list of lists, yes?  The following may work for you...


push(@$list{$_}, $name);

Alternatively, if you want to add the list of files containing a pattern to %patterns, you could do

push(@{$patterns{$_}}, $f);

0
 
LVL 84

Expert Comment

by:ozo
ID: 1203805
## or append filename to $pattern{$_},
$pattern{$_}.=$f;
0

Featured Post

Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

Join & Write a Comment

A year or so back I was asked to have a play with MongoDB; within half an hour I had downloaded (http://www.mongodb.org/downloads),  installed and started the daemon, and had a console window open. After an hour or two of playing at the command …
Checking the Alert Log in AWS RDS Oracle can be a pain through their user interface.  I made a script to download the Alert Log, look for errors, and email me the trace files.  In this article I'll describe what I did and share my script.
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
Excel styles will make formatting consistent and let you apply and change formatting faster. In this tutorial, you'll learn how to use Excel's built-in styles, how to modify styles, and how to create your own. You'll also learn how to use your custo…

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now