Solved

implement it in elegant way

Posted on 1998-08-17
3
183 Views
Last Modified: 2011-09-20
Suppose I want to scan a set of files and see if each of them contains certain patterns
26 patterns altogether).
Finally print the all name of files containing pattern_a,all name of file containing file_b etc...

My stupid program is like:

.......

foreach $f (@files){
  $name=$f;
  $open(FILE,$f)|| die "cannot open";

  while (<FILE>){
     if ($_ eq /pattern_a/){
       push(@list_a,$name);
     }elsif($_ eq /pattern_b){
       push(@list_b,$name);
     }elsif($_ eq /pattern_c){
       push(@list_c,$name);
     }elsif   ....
            .....

     }elsif($_ eq /pattern_z){
       push(@list_z,$name);
     }

  }
}

  printf "files containing pattern_a: @list_a\n";
  printf "files containing pattern_b: @list_b\n";
   ......
   ......
  printf "files containing pattern_z: @list_z\n";

-----------------------------------------------------------
However, I would like to implement it like
   
         ........
       foreach $f (@files){
          $name=$f;
          $open(FILE,$f)|| die "cannot open";

          while (<FILE>){
            if (exists $pattern{$_}{
                push(@list($_),$name)  ## This is illegal!!!
            }      ## or append filename to $pattern{$_},                     ###but how to do it
         }
       }
          ........

Can anyone there enlighten me or provide more elegant code? Thank you in advance.
0
Comment
Question by:tian
  • 2
3 Comments
 
LVL 84

Expert Comment

by:ozo
ID: 1203803
push @{$list{$_}},$name;

0
 
LVL 5

Accepted Solution

by:
b2pi earned 100 total points
ID: 1203804
Essentially, you want @list to be a list of lists, yes?  The following may work for you...


push(@$list{$_}, $name);

Alternatively, if you want to add the list of files containing a pattern to %patterns, you could do

push(@{$patterns{$_}}, $f);

0
 
LVL 84

Expert Comment

by:ozo
ID: 1203805
## or append filename to $pattern{$_},
$pattern{$_}.=$f;
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

There are many situations when we need to display the data in sorted order. For example: Student details by name or by rank or by total marks etc. If you are working on data driven based projects then you will use sorting techniques very frequently.…
In the distant past (last year) I hacked together a little toy that would allow a couple of Manager types to query, preview, and extract data from a number of MongoDB instances, to their tool of choice: Excel (http://dilbert.com/strips/comic/2007-08…
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
This tutorial gives a high-level tour of the interface of Marketo (a marketing automation tool to help businesses track and engage prospective customers and drive them to purchase). You will see the main areas including Marketing Activities, Design …

896 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now