Solved

simple problem

Posted on 1998-09-13
11
214 Views
Last Modified: 2010-04-02
this is a simple problem
I need to find the highest and lowest number of the numbers that have been entered.

#include <iostream.h>

int main(void)
{
       int n = 0;
       int high=0;
       int low =0;

       while(!cin.eof())
       {
              int x = 0;
              cin >> x;

              if(x>high)
                   high=n; //this works fine

              if(x<low)
             low=n;  // I always get a 0
              n += x;
       }
       cout << n << endl;
       cout << high<< endl;
       cout << low << endl;
       return 0;
any help would be great.
}
0
Comment
Question by:strmtrpr
  • 6
  • 5
11 Comments
 
LVL 2

Accepted Solution

by:
prasanth earned 120 total points
ID: 1172608
try

#include <iostream.h>

int main(void)
{
int n = 0;
int high=0;
int low =0;
int highidx = 0;
int lowidx = 0;

while(!cin.eof())
{
  int x = 0;
  cin >> x;

  if(x>high)
  {
    high=x;
    highidx = n;
  }
  if(x<low)
  {
    low=x;
    lowidx = n;
  }
  n++;
}
cout << n << endl;
cout << highidx << ":" << high << endl;
cout << lowidx << ":" low << endl;
return 0;
}
0
 

Author Comment

by:strmtrpr
ID: 1172609
if(x<low)
      {
        low=x;
        lowidx = n;
      } // still  getting a zero on the output;
 
0
 
LVL 2

Expert Comment

by:prasanth
ID: 1172610
did you enter any negative numbers? If not, 0 (the initial value of low) will end up being the lowest number.
0
ScreenConnect 6.0 Free Trial

Want empowering updates? You're in the right place! Discover new features in ScreenConnect 6.0, based on partner feedback, to keep you business operating smoothly and optimally (the way it should be). Explore all of the extras and enhancements for yourself!

 

Author Comment

by:strmtrpr
ID: 1172611
the program is supposed to accept numbers until cin.eof() is encountered
then  display  the higest lowest and sum of the numbers entered
then only reason I am asking for help is because I am out of Ideas, I really think that I am
trying to make this to difficult.
thank you for your help.
how do I find the lowest number entered.
I would think that it would be the opposite of the high but that isn,t working.

thank you for your time

0
 
LVL 2

Expert Comment

by:prasanth
ID: 1172612
this should do it

#include <iostream.h>

int main(void)
{
int n = 0;
int high=0;
bool highn = false;
int low =0;
bool lown = false;

while(!cin.eof())
{
  int x = 0;
  cin >> x;

  if(x>high || !highn)
  {
     high=n;
     highn = true;
  }

  if(x<low || !lown)
  {
     low=n;
     lown = true;
  }
  n += x;
}
cout << n << endl;
cout << high<< endl;
cout << low << endl;
return 0;

0
 

Author Comment

by:strmtrpr
ID: 1172613
thanks for the help
the last code you sent wouldn't compile under borland c++ 4.0 or g++under linux.
thanks anyway. I am not sure why this is so hard for me to figure out.
thanks for your time anyway.

0
 
LVL 2

Expert Comment

by:prasanth
ID: 1172614
replace

bool with int
true with 1
false with 0

and it should compile.
0
 

Author Comment

by:strmtrpr
ID: 1172615
it compiles but stilling getting a zero for the output of low

0
 
LVL 2

Expert Comment

by:prasanth
ID: 1172616
I tried this and it works:

#include <iostream.h>

int main(void)
{
int n = 0;
int high=0;
bool highn = false;
int low =0;
bool lown = false;

while(!cin.eof())
{
  int x = 0;
  cin >> x;

  if (!cin.eof())
  {
  if(x>high || !highn)
  {
     high=x;
     highn = true;
  }

  if(x<low || !lown)
  {
     cout << "here" << x <<endl;
     low=x;
     lown = true;
  }
  n += x;
  }
}
cout << n << endl;
cout << high<< endl;
cout << low << endl;
return 0;
}


basically what was happening was that when you pressed CTRL+Z to do eof, the character read was EOF which isn't a number and was being translated to 0.
0
 

Author Comment

by:strmtrpr
ID: 1172617
I owe you  big time
thanks very much now I can get some sleep.

0
 

Author Comment

by:strmtrpr
ID: 1172618
if you ever run into this  again try this instead
while(!(cin>>x).eof)
this fixed the original code the funny thing I had the answer sitting in front of the whole time
ans over looked it
0

Featured Post

Is Your AD Toolbox Looking More Like a Toybox?

Managing Active Directory can get complicated.  Often, the native tools for managing AD are just not up to the task.  The largest Active Directory installations in the world have relied on one tool to manage their day-to-day administration tasks: Hyena. Start your trial today.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Article by: SunnyDark
This article's goal is to present you with an easy to use XML wrapper for C++ and also present some interesting techniques that you might use with MS C++. The reason I built this class is to ease the pain of using XML files with C++, since there is…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.

809 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question