finding high and low of numbers.

Posted on 1998-09-13
Last Modified: 2010-04-02
I have a little problem with this little program
all I have to do is accept numbers from the user
have a running total and then print to screen
the sum, the highest and lowest of the numbers entered.
using cin>>  and cout<<  
if anyone has an idea please help.
this is what I have so far  #include<iostream.h>
 void main()
      int n =0;
      int high=0;
      int low =0;

      while (!cin.eof())
        int x=0;
        if (x>high)


        if (x>high)  //this is where the problem is
      {              // it is always zero
          n +=x;

              cout << n << endl;
              cout << high<< endl;
              cout << low << endl;
Question by:strmtrpr
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2

Accepted Solution

faster earned 100 total points
ID: 1172622
 if (x>high)  //this is where the problem is
   {              // it is always zero
It should be

  if (x<low)  //this is where the problem is
   {              // it is always zero

Besides. you have to set the init value of low and high correctly.  For example, if you only expect  x to be from 0 - 10, set high low than 0 and low greater than 10.

Author Comment

ID: 1172623
I must have missed typed the code on here the actual code reads (x<low)
you made a light bulb go off when you wrote set int high less than zero.
so I tried
int high -999;
int low 1000;
 still getting a zero for low.
thanks for the help
LVL 84

Expert Comment

ID: 1172624
Is there anything in the input after the last non-zero number?
(what happens if you change
  int x=0;
  int x=low;

Author Comment

ID: 1172625
I figured it out with some help  you got me thinking and prasanth help with some code he sent
the problem  he figured  was that EOF was sending a zero .
his code worked in a round about way
I started thinking and figurred it out
it was this simple
thanks for your help now I can get some sleep.

Expert Comment

ID: 1172626
as ozo said, you probably have a blank line or something, but not necessarily after your last non-zero number.

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generat…
Article by: SunnyDark
This article's goal is to present you with an easy to use XML wrapper for C++ and also present some interesting techniques that you might use with MS C++. The reason I built this class is to ease the pain of using XML files with C++, since there is…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

688 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question