Null pointer assignment

Posted on 1998-09-24
Medium Priority
Last Modified: 2012-05-04

/***** Program Merge many files to one file *****/

#include <fcntl.h>
#include <sys\stat.h>

#define BUFSIZE 54

int main(int argc,char *argv[])
  extern int errno;
  void *point;
  FILE *fpw,*fpr;
  int  count;
  int  handle;
  int  errchk;
  long  filesize;

    handle = open(argv[count],O_RDONLY|O_TEXT);
    filesize = filelength(handle)-3;
    if((point = malloc(filelength(handle))) == NULL)
      printf("Not enough memory to allocate buffer\n");
      exit(1);  /* terminate program if out of memory */

    /****** READ FROM SOURCE FILE ******/
    if((errchk = read(handle,point,filelength(handle))) == -1)
      printf("Read Failed.\n ----%d",errno);

 /****** WRITE TO TARGET FILE ******/

    if((fpw = fopen(argv[argc-1],"a+t")) == NULL)
      fprintf(stderr, "Cannot open input file.\n");
 Above is my merging program source code for merge detail in many files to one file.It work completely but after close target file appear message "Null pointer assignment" on screen.Can you correct this error message or any error may have on source code ?.

Question by:dissathep
1 Comment

Accepted Solution

JYoungman earned 150 total points
ID: 1253025
You've made several mistakes.  The "null pointer assignment" is just the most obvious symtom of the bugs.  

You do free(point) twice with the same value.  Doing this a second time is a bug.  The first time round your main loop, you do free(point) without initialising point to anything other than its default random value.   This will be what causes that message.

There are other problems with this code, too.

You didn't check the return value of filelength() for a failure status (it can fail, can't it?)

>> printf("\n%d----%d\n",handle,filelength(handle));

If filelength() returns a long, the second format should be %ld.
If it does return a long and a negative value means failure,
you should not pass this value directly to malloc(), because the argument of malloc() is an unsigned quantity.

You do not need to include <conio.h>, nor <io.h>, and probably not <dos.h>.

>>  printf("\n%d----%d\n",handle,filelength(handle));

Use perror() instead.

Lastly, there is no reason to malloc() a buffer big enough to read the whole input file into, you could just read it in piecewise, appending data to the output file as you go. There is no need to reopen the output file once each time round the loop.  You could just open it once at the start and close it at the end.


Featured Post

We Need Your Input!

WatchGuard is currently running a beta program for our new macOS Host Sensor for our Threat Detection and Response service. We're looking for more macOS users to help provide insight and feedback to help us make the product even better. Please sign up for our beta program today!

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Summary: This tutorial covers some basics of pointer, pointer arithmetic and function pointer. What is a pointer: A pointer is a variable which holds an address. This address might be address of another variable/address of devices/address of fu…
Examines three attack vectors, specifically, the different types of malware used in malicious attacks, web application attacks, and finally, network based attacks.  Concludes by examining the means of securing and protecting critical systems and inf…
The goal of this video is to provide viewers with basic examples to understand how to use strings and some functions related to them in the C programming language.
The goal of this video is to provide viewers with basic examples to understand and use switch statements in the C programming language.

627 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question