Solved

Error handling ... how to improve it?

Posted on 1998-11-03
4
167 Views
Last Modified: 2010-04-30
Hi,
  I am reading a list of files from a listbox and then printing each one. I added some error handling to handle missing files, which will continue with the next file to print. However, I am not very clear with the error handling of VB and it seems my code can be improved.
Soemtimes, when there is a error (listbox is empty), if I press Print again, there is a error "For loop not initialised". I know it has to do the 'nextF' statement but I am not sure how to improve/ correct it.
I provided main parts of my print function...
sorry, I don't have much points left... :(
Thanks a lot!

David

Private Sub Print_Click()
' declarations

On Error GoTo handleErr
    For i = 0 To (List1.ListCount - 1) ' read from list1
    On Error Resume Next

    Open (list1.text) For Input As #1 ' Open file.
 
    Do While Not EOF(1) ' Loop until end of file.
      ' print line      
    Loop
   
nextF:
    ' close file      
    Next i

End If ' response = vbyes
Exit Sub 'avoid error handler

handleErr:
    Select Case Err.Number  ' Evaluate error number.
        Case 32755 ' printer error
            MsgBox ("Error printing. Printing aborted.")
            Exit Sub
        Case 53: ' file not found
            MsgBox ("File " & ToPrint & " not found. Continuing with next file.")
            GoTo nextF
   
    End Select
    Err.Clear

End Sub
0
Comment
Question by:Haho
4 Comments
 
LVL 1

Expert Comment

by:powlin
ID: 1443031
to check if the listbox is empty you can use the if list1.listcount  = 0 then exit sub
for the error handling you can use Err.description and err.number to know all the error posible without a huge Select case with all the error you can check if list1.listindex = -1 if there's no item selected
0
 
LVL 4

Expert Comment

by:CraigLazar
ID: 1443032
HI
Maybe create a sub funcion that calls the error handler every time there is an error
on error goto eh:
..
..
..
..
eh:
 'call your function and in your function make sure you have the resume next statement

hope this helps
craig

0
 
LVL 13

Accepted Solution

by:
Mirkwood earned 20 total points
ID: 1443033
Improved code

Private Sub Print_Click()
' declarations

if (list1.listcount > 0) then
    For i = 0 To (List1.ListCount - 1) ' read from list1
      on error resume next
      Open (list1.List(i)) For Input As #1 ' Open file.
      if (err.number <> 0) then
           on error goto error_readfile
           Do While Not EOF(1) ' Loop until end of file.
               ' print line
           Loop
:error_skipfile
          ' close file
       end if
    Next i
End If

Exit Sub 'avoid error handler

Error_readfile:
    Select Case Err.Number  ' Evaluate error number.
        case 0
        Case 32755 ' printer error
            MsgBox ("Error printing. Printing aborted.")
           'close file
           exit sub
        case else
            msgbox Err.desc & " skipping file"
            resume error_skipfile  
    End Select
End Sub
0
 
LVL 1

Author Comment

by:Haho
ID: 1443034
thanks !!! For the time being I am doing:
for i ...
 open file
 if err.number <> 0 then
   err msgbox
 else
  printing code
 end if
next i

0

Featured Post

Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction I needed to skip over some file processing within a For...Next loop in some old production code and wished that VB (classic) had a statement that would drop down to the end of the current iteration, bypassing the statements that were c…
This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

786 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question