Solved

Error handling ... how to improve it?

Posted on 1998-11-03
4
165 Views
Last Modified: 2010-04-30
Hi,
  I am reading a list of files from a listbox and then printing each one. I added some error handling to handle missing files, which will continue with the next file to print. However, I am not very clear with the error handling of VB and it seems my code can be improved.
Soemtimes, when there is a error (listbox is empty), if I press Print again, there is a error "For loop not initialised". I know it has to do the 'nextF' statement but I am not sure how to improve/ correct it.
I provided main parts of my print function...
sorry, I don't have much points left... :(
Thanks a lot!

David

Private Sub Print_Click()
' declarations

On Error GoTo handleErr
    For i = 0 To (List1.ListCount - 1) ' read from list1
    On Error Resume Next

    Open (list1.text) For Input As #1 ' Open file.
 
    Do While Not EOF(1) ' Loop until end of file.
      ' print line      
    Loop
   
nextF:
    ' close file      
    Next i

End If ' response = vbyes
Exit Sub 'avoid error handler

handleErr:
    Select Case Err.Number  ' Evaluate error number.
        Case 32755 ' printer error
            MsgBox ("Error printing. Printing aborted.")
            Exit Sub
        Case 53: ' file not found
            MsgBox ("File " & ToPrint & " not found. Continuing with next file.")
            GoTo nextF
   
    End Select
    Err.Clear

End Sub
0
Comment
Question by:Haho
4 Comments
 
LVL 1

Expert Comment

by:powlin
Comment Utility
to check if the listbox is empty you can use the if list1.listcount  = 0 then exit sub
for the error handling you can use Err.description and err.number to know all the error posible without a huge Select case with all the error you can check if list1.listindex = -1 if there's no item selected
0
 
LVL 4

Expert Comment

by:CraigLazar
Comment Utility
HI
Maybe create a sub funcion that calls the error handler every time there is an error
on error goto eh:
..
..
..
..
eh:
 'call your function and in your function make sure you have the resume next statement

hope this helps
craig

0
 
LVL 13

Accepted Solution

by:
Mirkwood earned 20 total points
Comment Utility
Improved code

Private Sub Print_Click()
' declarations

if (list1.listcount > 0) then
    For i = 0 To (List1.ListCount - 1) ' read from list1
      on error resume next
      Open (list1.List(i)) For Input As #1 ' Open file.
      if (err.number <> 0) then
           on error goto error_readfile
           Do While Not EOF(1) ' Loop until end of file.
               ' print line
           Loop
:error_skipfile
          ' close file
       end if
    Next i
End If

Exit Sub 'avoid error handler

Error_readfile:
    Select Case Err.Number  ' Evaluate error number.
        case 0
        Case 32755 ' printer error
            MsgBox ("Error printing. Printing aborted.")
           'close file
           exit sub
        case else
            msgbox Err.desc & " skipping file"
            resume error_skipfile  
    End Select
End Sub
0
 
LVL 1

Author Comment

by:Haho
Comment Utility
thanks !!! For the time being I am doing:
for i ...
 open file
 if err.number <> 0 then
   err msgbox
 else
  printing code
 end if
next i

0

Featured Post

Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

Join & Write a Comment

Suggested Solutions

This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
Since upgrading to Office 2013 or higher installing the Smart Indenter addin will fail. This article will explain how to install it so it will work regardless of the Office version installed.
Get people started with the process of using Access VBA to control Outlook using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Microsoft Outlook. Using automation, an Access applic…
Show developers how to use a criteria form to limit the data that appears on an Access report. It is a common requirement that users can specify the criteria for a report at runtime. The easiest way to accomplish this is using a criteria form that a…

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now