Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 353
  • Last Modified:

dynamic popupmenu creation

I need to create a popup menu dynamicly. It has to change the number of items in it, every time it loads. I have been having a lot of trouble with it because if it has a number of items; the next time it loads, if it has less items, it has the first number of items, it just show the new items in the bottom slots with the old items on top.

Here is the procedure I have right now:

procedure TMainfrm.MenuChange;
var
  PopUpItems: array[0..99] of TMenuItem;
  i: integer;
begin
 for i := 1 to {always changing variable} do begin
    popupitems[i].free;
    PopUpItems[i] := TMenuItem.Create(Self);
    PopUpItems[i].Caption := IntToStr(i);
    PopUpItems[i].Tag := i;
    PopupItems[i].hint := popupitems[i].caption;  
    Popupitems[i].Radioitem := true;
    popupItems[i].OnClick := PopUpevent;
    PopUpMenu1.Items.add(PopUpItems[i]);
  end;
end;

A solution to this problem is greatly appreciated.
thanks
spat  
0
spat
Asked:
spat
  • 4
  • 3
  • 2
  • +4
1 Solution
 
spatAuthor Commented:
Edited text of question
0
 
spatAuthor Commented:
Edited text of question
0
 
rwilson032697Commented:
The solution is to clear the list of items before added them. Do this before your main loop:

 popupitems.items.clear;

or this if clear does not compile:

     for I := 1 to popupitems.items.count do
        popupitems.items.remove(0);    // remove may need to be delete

cheers,

Raymond.
 
0
Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
spatAuthor Commented:
I have tried to delete the items but i recieve an error message that says the menu index is out of range
0
 
kretzschmarCommented:
hi spat,

use this to delete the items:

while popupitems.Items.Count > 0 do
          popupitems.Items.Delete(0);


meikl
0
 
Gerhard100198Commented:
for I := 1 to popupitems.items.count do
       popupitems.items.remove(0);    // remove may need to be delete

You will receive a "menu index is out of range" error when trying to run the above code.

Try the following which should do the job:

 for I := 0 to popupitems.items.count - 1 do

Here is something else you might want to consider:

There is no reason to store the created menu items into an array (well there is one small situation where you would need to do it which I'll get to a bit later).

You could use the following code and it will work fine:


     var
       i: integer;
     begin
      for i := 1 to {always changing variable} do begin
        With TMenuItem.Create(Self) do begin
           //Though you don't need to assign a name I like to do it anyway since you
           //might want to access the object at a later stage
           Name := 'mi_' + IntToStr(i);
           Caption := IntToStr(i);
           PopUpItems[i].Tag := i;
           PopupItems[i].hint := popupitems[i].caption;  
           Popupitems[i].Radioitem := true;
           popupItems[i].OnClick := PopUpevent;
       end;
      end;

       //If you would like to change any of the meny item's properties at a later stage
       //you can get access to it's properties in the following way. This is the reason
       //I assigned my own component name earlier so that I can reference them by name
       //when needed. The FindComponent function is extremely handy since you can pass
       //it a component's name as a string and it will return the TObject (just remember to
       //typecast to TMenuItem since you received a TObject.
       With TMenuItem(FindComponent('mi_1')) do Enabled := False;
       With TMenuItem(FindComponent('mi_3')) do Visible := False;
       ...etc.
     end;

0
 
ZifNabCommented:
gerhard is correct,

your items start from index 0!!!!!!!

thus you need to iterate like : for i := 0 to popitems.items.count-1

Zif.
0
 
BlackManCommented:
Hmm, it shouldn't make any difference, as Raymond goes from 1 to count and allways are deleting entry 0..
(1 to count = 0 to count-1 :-)
0
 
ZifNabCommented:
? Blackman,

let say count = 5

 if you go from i = 1 to 5

 or from i = 0 to 4

and use remove(i)

Then remove(5) will give a problem! Because i=5 doesn't exist! the list goes till i=4!! Or am I not awake enough?

Zif.
0
 
BlackManCommented:
That's right, but Raymond is allways deleting item 0!, so all he wants, is to iterate 5 times...
0
 
ZifNabCommented:
:-) Yes, now I see it too. Possibly a typo-error? :-))))

0
 
Ronald BusterOwnerCommented:
I just used a similar function a month ago here is how I did this :

add following to tmainfrm private section

fPopUpMenu : TPopUpMenu

your procedure

procedure TMainfrm.MenuChange;
var tm : tmenuitem;
      i   : integer;
begin
   if assigned(fPopUpMenu) then
     fPopUpMenu.Free;

   fPopUpMenu := TPopUpMenu.Create(Self);
   for i := 1 to {always changing value}  do
     begin
         tm  := TMenuItem.Create(Self);
         tm.Caption := IntToStr(i)];
         tm.Tag     := i;
         tm.OnClick := PopUpEvent;
         fPopUpMenu.Items.Add(tm);
     end;
end;

This should work regards,

Cono



0
 
rwilson032697Commented:
Thanks Blackman - after reading half a dozen comments regarding how it should be 0 to count -1 I was going to post a sarcastic comment regarding whether anybody bothered to read the code!

ZifNab: Nope, not a typo, just an alternative form of while popupitems.items.count >0 do popupitems.items.delete(0) (though I admit the while loop is a little cleaner!)

spat: Did you try the code I suggested (with delete in place of remove in the loop)?

Cheers,

Raymond.
0
 
spatAuthor Commented:
I tried Gerhard's code, it worked perfect. Thank you for all of your assistance.

rwilson, I did try your code with delete instead of remove. Thanks anyway
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

  • 4
  • 3
  • 2
  • +4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now