• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 382
  • Last Modified:

changing background colour

I want to change details from a window class before it is created, such as background colour of the window. It seems I can only get a pointer to the class name (a string). I am currently using this code

CRect rect;
GetClientRect( rect );
pDC->FillSolidRect( rect, RGB( 0, 0xbb, 0 ) );

in the OnDraw function but this is highly inefficient. How can I do better?

Also, a trivial but annoying thing (not worth points but bugging me all the same) I have edited the document icon in my application but windows continues to use the old one on my system (I have not tried distributing the app yet). I have tried importing the .reg file but still no good. I guess this must be a windows thing because the application definitely recognises the new icon.
  • 3
  • 3
1 Solution
Before the class is registered, your app has a WNDCLASS structure, it contains members like hbrBackground which is an HBRUSH used to erase the background, if you fill it in then it will be used by every window of the class.

After the class is created, you can use SetClassLong to change the properties of a class.  The change will only affect new windows, not existing ones.

Since you use MFC, you might want to use AfxRegisterWndClass to get exactly the class you want.

Create a solid brush in your init code :
CBrush  BackgroundBrush ;
BackgroundBrush.CreateSolidBrush(RGB(0,0xbb,0)) ;

Then, when you want to change the background color for the window, use :
SetClassLong(m_hWnd,GCL_HBRBACKGROUND,(LONG)HBRUSH(BackgroundBrush)) ;

Don't forget to destroy the brush in your exit code :
BackgroundBrush.DeleteObject() ;

About your icon problem, is it an icon you associate with files having a particular extension or what is it associated with ?

agrillageAuthor Commented:
The icon is associated with the document ( the only document ) class for the application. It is the default from the app wizard. All I did was edit it.

I am trying the SetClassLong Function in the meantime.

Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

For the icon problem, I think you have edited the 32x32 version of the icon, but not the 16x16 version, which is used to display the document icon in MFC.
WHen you edit the icon in Visual C++, you have a combobox where you can choose between the 32x32 version and the 16x16 version to edit.

agrillageAuthor Commented:
Points are for the background colour. I edited both icons and niether comes through correctly. I think it must be a bug but I would be interested to hear any more thoughts you might have.
Which version of Visual C++ do you use ?
Is your MFC application SDI or MDI ?

Try to open your application .EXE with Visual C++
using "Open as : resource" and tell me if the icon
in the .EXE appears as you modified it or as the default.
agrillageAuthor Commented:
Visual C++ 5.0 Enterprise
The icons appear as I want, correctly modified.

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

  • 3
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now