changing background colour

Posted on 1998-12-30
Medium Priority
Last Modified: 2010-04-01
I want to change details from a window class before it is created, such as background colour of the window. It seems I can only get a pointer to the class name (a string). I am currently using this code

CRect rect;
GetClientRect( rect );
pDC->FillSolidRect( rect, RGB( 0, 0xbb, 0 ) );

in the OnDraw function but this is highly inefficient. How can I do better?

Also, a trivial but annoying thing (not worth points but bugging me all the same) I have edited the document icon in my application but windows continues to use the old one on my system (I have not tried distributing the app yet). I have tried importing the .reg file but still no good. I guess this must be a windows thing because the application definitely recognises the new icon.
Question by:agrillage
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 3

Expert Comment

ID: 1181328
Before the class is registered, your app has a WNDCLASS structure, it contains members like hbrBackground which is an HBRUSH used to erase the background, if you fill it in then it will be used by every window of the class.

After the class is created, you can use SetClassLong to change the properties of a class.  The change will only affect new windows, not existing ones.

Since you use MFC, you might want to use AfxRegisterWndClass to get exactly the class you want.


Accepted Solution

stsanz earned 200 total points
ID: 1181329
Create a solid brush in your init code :
CBrush  BackgroundBrush ;
BackgroundBrush.CreateSolidBrush(RGB(0,0xbb,0)) ;

Then, when you want to change the background color for the window, use :
SetClassLong(m_hWnd,GCL_HBRBACKGROUND,(LONG)HBRUSH(BackgroundBrush)) ;

Don't forget to destroy the brush in your exit code :
BackgroundBrush.DeleteObject() ;

About your icon problem, is it an icon you associate with files having a particular extension or what is it associated with ?


Author Comment

ID: 1181330
The icon is associated with the document ( the only document ) class for the application. It is the default from the app wizard. All I did was edit it.

I am trying the SetClassLong Function in the meantime.

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!


Expert Comment

ID: 1181331
For the icon problem, I think you have edited the 32x32 version of the icon, but not the 16x16 version, which is used to display the document icon in MFC.
WHen you edit the icon in Visual C++, you have a combobox where you can choose between the 32x32 version and the 16x16 version to edit.


Author Comment

ID: 1181332
Points are for the background colour. I edited both icons and niether comes through correctly. I think it must be a bug but I would be interested to hear any more thoughts you might have.

Expert Comment

ID: 1181333
Which version of Visual C++ do you use ?
Is your MFC application SDI or MDI ?

Try to open your application .EXE with Visual C++
using "Open as : resource" and tell me if the icon
in the .EXE appears as you modified it or as the default.

Author Comment

ID: 1181334
Visual C++ 5.0 Enterprise
The icons appear as I want, correctly modified.

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article shows you how to optimize memory allocations in C++ using placement new. Applicable especially to usecases dealing with creation of large number of objects. A brief on problem: Lets take example problem for simplicity: - I have a G…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.
Suggested Courses
Course of the Month12 days, 15 hours left to enroll

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question