asked on

Help With Fine Tuning Some Code

I am working on a program for a corespondence course and I can not get it work properly. It needs to take input from a user and write that inpu to an array of structs via a function. Then I need a function to printf what's in the array of structs. I can not seem to get it to work right. What am I missing here?

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX_TITLE 255
#define MAX_TYPE 255
#define MAX_ACTOR 255
#define MAX_VIDEOS 8192

typedef struct videos
{
      char title [ MAX_TITLE ];
      char type [ MAX_TYPE ];
      char actor [ MAX_ACTOR ];
};

void find(void);
void check_out(void);
void return_videos(void);
void find_videos(void);
void add_videos(struct videos *new_videos);
void print_inventory(struct videos MAX_VIDEOS[]);
void menu_header(void);

struct videos new_videos[MAX_VALUE];

int main(void)
{
      int menu_val;

      while ((menu_val = getchar()) != 0)
      {
      printf( "SCHLOCKLUSTER VIDEO - Main Menu: \n\n");
      printf( "DESCRIPTION/FUNCTION: ENTER NUMBER: \n");
      printf( "Find video(s) (by title, type, or actors) - 1 \n");
      printf( "Check out video(s) - 2 \n");
      printf( "Return video(s) - 3 \n");
      printf( "Find all videos out to a customer - 4 \n");
      printf( "Add new video(s) - 5 \n");
      printf( "Print inventory list (sorted by...) - 6 \n");
      printf( "Reprint the menu options - 7 \n\n");

      getchar();
      menu_val -= 48;
      switch (menu_val)
{
case 1:
find();
break;

case 2:
check_out();
break;

case 3:
return_videos();
break;

case 4:
find_videos();
break;

case 5:
add_videos(new_videos);
break;

case 6:
print_inventory();
break;

default:
printf("Your selection did not match one of the menu options.\n Please enter a valid option. \n");
break;
}
}
      return(0);

}

void find(void)
{
printf("This option not available yet. It is still in development process. \n");
}

void check_out(void)
{
printf("This option not available yet. It is still in development process. \n");
}

void return_videos(void)
{
printf("This option not available yet. It is still in development process. \n");
}

void find_videos(void)
{
printf("This option not available yet. It is still in development process. \n");
}

void add_videos(struct videos new_videos)
{
int i;
fflush(stdin);
printf("\nEnter the title of the video? ");
gets(new_videos[i].title);

for (i=0; i<255; i++) {
strcpy("title", new_videos[i].title);
}

printf("\nWhat genre is the video? ");
gets(new_videos[i].type);

for (i=0; i<255; i++) {
strcpy("type", new_videos[i].type);
}

printf("\nEnter upto three actors seperated by spaces: ");
gets(new_videos[i].actor);

for (i=0; i<255; i++) {
strcpy("actor", new_videos[i].actor);
}

}

void print_inventory(struct videos MAX_VIDEOS[])
{
int i;
for(i = 0; i < MAX_VIDEOS; i++)
{
printf("Title of movie: %s\n", MAX_VIDEOS[i].title);
printf("Type of move: %s\n", MAX_VIDEOS[i].type);
printf("Actors in movie: %s\n", MAX_VIDEOS[i].actor);
}
}

Any help would be greatly appreciated.

Thanks,

maplah

sreenathk

Hi Maplah,
There are some doubts in your code.
1. When you are declaring the functions in the beginning, for function void add_video(struct videos *new_video);
The parameter passed is a global variable and this may create some problem in resolving. So you just mention void add_video(struct video *);

2. For the function declaration voice print_inventory(struct videos MAX_VIDEOS[]);
there is a parameter present and when you call the function in main() you did not pass any parameter. More over MAX_VIDEOS is a constant and will be replaced by the value in parsing. So better declaring it as void print_inventory();
So that the global variable new_videos you can use for printing inventory.

3. In function definition of add_videos(), you have declared a variable int i, which is not initialised. Depending on the OS you are using it may got initialized but it is not good to use a variable without initializing. Remeber that you are using the varable i before for loop.
4. Your add_videos function is not proper as it writes 255 strings "title" into into the structure member title. the function strcpy you are using incorrectly. it is in a for loop. That mean you are getting one title and filling it in all the variables.

5. First correct the above corrections. Revert if this is not the solution you are expecting. One more suggestion to you is increase the points for this question as it is complex and that attracts many people around.

Sreenath
sreenath.reddy@philips.com

ASKER CERTIFIED SOLUTION

Ready4Dis

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.