Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
Solved

# Random number generator in (Linux with g++)

Posted on 2000-02-18
Medium Priority
681 Views
I have just discovered an anamoly in a pece of code I wrote to rearrange a list of 1245 numbers from 1 to 1245 in a random order - even though there is no "0" in the list, the random number generator keeps giving me one. Otherwise it looks alright except that there is also a 1245 and so some number in the middle is being lost. Can anyone see a problem with this code, as I can't. I am a relatively new programmer using g++ under Linux. Thanks in advance.
Heres the code (the header files are from the main program):

#include <iostream>
#include <cmath>
#include <fstream>
#include <iostream>
#include <stdio.h>
#include <stdlib.h>

int seed, a, j, np = 1245, index;

double randomNumber, ordered[1245], ordered_store[1245], random_order[1245];

void random_number_generator()

{
double ran;
srand (seed);
ran = rand();
randomNumber = ran / RAND_MAX;
seed++;
}

void random_sequence()

{
double temp;
for (a = 1; a <= np; a++)
{
ordered[a - 1] = a;
ordered_store[a - 1] = a;
random_order[a - 1] = 0;
}
int range = int(np);
for (a = 0; a < np; a++)
{
random_number_generator();
temp = randomNumber * range;
index = int(temp) + 1;
random_order[a] = ordered[index];
for (j = index; j < np - a; j++)
{
ordered[j] = ordered[j + 1];
}
range--;
}
}

void test_3()
{
fstream fileout ("random_order", ios::out);
for (a = 0; a < np; a++)
{
fileout << " " << random_order[a] << "   " << ordered_store[a] << endl;
}
}

main()
{
random_sequence();
test_3();
return 0;
}

0
Question by:bobhope021500
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points

LVL 1

Expert Comment

ID: 2534493
always add 1 to the result of the random number
0

Author Comment

ID: 2534494
Edited text of question.
0

LVL 7

Expert Comment

ID: 2534521
Please do not edit the text of the question, rather use comments. Changing the question text may produce strange looking comment threads. Thank you.
0

LVL 22

Accepted Solution

nietod earned 400 total points
ID: 2534545
You should not keep seeding the random number generator.  Just seed 1 time, at the start of the program.

the random_number_generator() function should return a random number rather than placing the result in a global varaible.  Using a global variable in this way is a very bad idea.  It can lead to many problems and can make a program hard to debug.  whenever possible, return information through a return value, or perhaps through a reference parameter, not through "invisible" means.

The line
randomNumber = ran / RAND_MAX;

will generate a number between 0 and 1 inclusive.  (0 and 1 are possible).

Byt then you convert that number bacj to an integer.  Why not just keep it an integer?

for (a = 0; a < np; a++)
{
index = rand() % range;
// index is now from 0 to range -1  (is it supposed to go to range?  I'm not sure.  If so mode by range+1)
random_order[a] = ordered[index];
}
0

Author Comment

ID: 2534605
Thanks, that sorted it out. I included the seed incrementation in order to increase the element of randomness - I am developing neural network software which relies on the random order of the input data to emphasise the characteristics of the data rather than the way it is presented. But I'm sure this won't be a problem and if it is I may be back! Thank you.
0

LVL 22

Expert Comment

ID: 2534974
>> I included the seed incrementation in order to
>> increase the element of randomness
But it doesn't.  You are seeding with sequential numbers, that is no more random than not reseeding.  I fact it may be far less random (It may cause sequences of repeated numbers).  Your best bet is to seed with a single psuedo-random number one time, like the current time.  Then let the sequence proceed unaltered (un-reseeded) from there.
0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generatâ€¦
This article will show you some of the more useful Standard Template Library (STL) algorithms through the use of working examples.  You will learn about how these algorithms fit into the STL architecture, how they work with STL containers, and why tâ€¦
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.
###### Suggested Courses
Course of the Month9 days, 23 hours left to enroll