TrEaSoN
asked on
Optimizing Code - please help
Experts,
I've been writing some code with my friend for a program (not school related!) we are working on. Unfortunately, the code that we pumped out does not quite go as fast as what we would like. We tried converting it to C++ code but we aren't that great with the language so it didn't exactly run much faster. So if any some experts could help get either this VB code to run really fast or to help us out with writing a faster routine in C++ i would greatly appreciate it! THANKS!
The code is as follows:
'------------
Dim len1 As Double
Dim ival As Double
Dim string1(10000) As String
Dim tst As Byte
Dim numoftimes As Long
Open "c:\windows\desktop\test.e
'Input
For len1 = 0 To 200000000 Step 3000 'input file
For z = 1 To 3000 'for every 3000 bytes
Get #1, len1 + z, tst 'input byte
ival = (len1 + z - 1) / 3000
string1(ival) = string1(ival) & Fill(CStr(tst), 3)'tack onto string
If EOF(1) Then Exit For
Next z
numoftimes = (len1 + z - 1)
If EOF(1) Then Exit For
Next len1
Close #1
'----
Private Function Fill(ByVal data As String, ByVal length As Integer) As String
Fill = data
If Len(data) < length Then Fill = String(length - Len(data), "0") & Fill
End Function
'----
I've been writing some code with my friend for a program (not school related!) we are working on. Unfortunately, the code that we pumped out does not quite go as fast as what we would like. We tried converting it to C++ code but we aren't that great with the language so it didn't exactly run much faster. So if any some experts could help get either this VB code to run really fast or to help us out with writing a faster routine in C++ i would greatly appreciate it! THANKS!
The code is as follows:
'------------
Dim len1 As Double
Dim ival As Double
Dim string1(10000) As String
Dim tst As Byte
Dim numoftimes As Long
Open "c:\windows\desktop\test.e
'Input
For len1 = 0 To 200000000 Step 3000 'input file
For z = 1 To 3000 'for every 3000 bytes
Get #1, len1 + z, tst 'input byte
ival = (len1 + z - 1) / 3000
string1(ival) = string1(ival) & Fill(CStr(tst), 3)'tack onto string
If EOF(1) Then Exit For
Next z
numoftimes = (len1 + z - 1)
If EOF(1) Then Exit For
Next len1
Close #1
'----
Private Function Fill(ByVal data As String, ByVal length As Integer) As String
Fill = data
If Len(data) < length Then Fill = String(length - Len(data), "0") & Fill
End Function
'----
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
What are you trying to do? I've looked over the code (and even tried it) but I can't find a single reason for it. Speeding it up is probably quite easy, but I don't know what you want it to do.
I guess I was right, since vbmaster posted twice while I was still looking at it. ;-)
To me it looks like the code extracts the ascii code of all the bytes inside a file, and adds it to a string value like 065066067068 for a file containing the text "ABCD"...
Perhaps this function is used in some kind of editor or perhaps Treason needs to know the ascii code for something else.
Perhaps this function is used in some kind of editor or perhaps Treason needs to know the ascii code for something else.
That's kinda what it looked like, but what got me was this:
ival = (len1 + z - 1) / 3000
string1(ival) =
ival SEEMED to me to be a useless procession of values (1,6,3,0,0... or something like that) when I stepped through the code. Maybe I'm missing something...(again!).
Later,
ival = (len1 + z - 1) / 3000
string1(ival) =
ival SEEMED to me to be a useless procession of values (1,6,3,0,0... or something like that) when I stepped through the code. Maybe I'm missing something...(again!).
Later,
ASKER
thanks for your help!
Dim a As Long
Dim ByteSize As Long
Dim ByteArray() As Byte
Dim StringCount As Long
Dim StringArray() As String
ByteSize = 3000
ReDim ByteArray(0 To ByteSize - 1)
Open "c:\windows\desktop\test.e
ReDim StringArray(LOF(1) \ ByteSize + IIf(LOF(1) Mod ByteSize = 0, -1, 0))
Do Until EOF(1)
If ((LOF(1) - Seek(1) + 2) <= ByteSize) Then
ByteSize = LOF(1) - Seek(1) + 2
ReDim ByteArray(0 To ByteSize - 1)
End If
Get #1, , ByteArray
StringCount = StringCount + 1
StringArray(StringCount - 1) = Space$(3 * ByteSize)
For a = 1 To ByteSize
Mid$(StringArray(StringCou
Next
Loop