Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 259
  • Last Modified:

Thread nerver returns from WaitForSingleObject() !!!

I've a Mutex and 3 threads like below

HANDLE HMutex;  
bool   End = false;
//////
/////
void Thread_Running_1()
{
  do
  {
     WaitForSingleObejct( HMutex, INFINITE );
     // ..... do something important
  }
  while( ! End );
}  
//////
/////
void Thread_Running_2()
{
  do
  {
     WaitForSingleObejct( HMutex, INFINITE );
     // ..... do something important
  }
  while( ! End );
}  
//////
//////   The main() function is only a case school
//////
void main()
{
   // I create and lock the mutex

   HMutex = CreateMutex( ..... );
   WaitForSingleObejct( HMutex, INFINITE );

   // I create 2 threads and i start these threads

   CreateThread( ...., Thread_Running_1, ..... );
   CreateThread( ...., Thread_Running_2, ..... );

   // At this time, Thread 1 and 2 are in a wait state.
   // Now, We release and close the Mutex

   End = true;
   ReleaseMutex( HMutex );
   CloseHandle( HMutex );
   
   // At this time, the HMutex is REALLY DESTROYED
}  


The trouble is when i release and close the Mutex handle,
only one thread will continue running. The other thread is
DEFINITELY lost. You can see the thread in "perfmon.exe".
You must call TerminateThread() api to shutdown the thread,
because the thread never returns from WaitForSingleObject().

When i close the Mutex handle, i do not know how many threads
are awaiting the mutex to be released. We could think that
the CloseHandle() will cease the WaitForSingleObject() execution
by returning WAIT_FAILED to threads but it DOES NOT.

This is same thing for Critical Section, Event, Semaphore.

MY QUESTION :
How to prevent the thread from being lost ?
 
0
mars
Asked:
mars
  • 2
1 Solution
 
nietodCommented:
First of all, you really shoudl be using critical sections for this, not mutexes.

next you need to declare end as volatile, otherwise it may be optimized out of existance, preventing the threads from ending.  (VERY likely.)

Finally  you should not close the mutex handle unil the other threads finish.  To do this you can wait on the thread handles with WaitForSingleObject().  The wait function will return when the thread ends.  So use this to wait until two the additional threads are done, then close the mutex handle

let me know if you have any quesitons.
0
 
nietodCommented:
One more thing the threads that lock the mutex never release it.  You should have them release the mutex before then terminate.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now