CListBox ownerdraw

Posted on 2000-04-05
Last Modified: 2013-11-20
I'm writing a VC++ Dialog type application. Since I want to have some listbox with black background and white text, I created my own class  CModListBox which is based on CListBox.

so.. the followng listed what I did:
1. Create a class:  Class CModListBox : public CListBox
2. Add virtual function Drawitem and I use exactly the same code list in MSDN:
void CModListBox::DrawItem(LPDRAWITEMSTRUCT lpDrawItemStruct)
      // TODO: Add your code to draw the specified item
   //ASSERT(lpDrawItemStruct->CtlType == ODT_LISTBOX);
   LPCTSTR lpszText = (LPCTSTR) lpDrawItemStruct->itemData;
   //ASSERT(lpszText != NULL);  
   CDC dc;
   // Save these value to restore them when done drawing.
   COLORREF crOldTextColor = dc.GetTextColor();
   COLORREF crOldBkColor = dc.GetBkColor();
   // If this item is selected, set the background color
   // and the text color to appropriate values. Also, erase
   // rect by filling it with the background color.
   if ((lpDrawItemStruct->itemAction | ODA_SELECT) &&
      (lpDrawItemStruct->itemState & ODS_SELECTED))  
   // If this item has the focus, draw a red frame around the   // item's rect.
   if ((lpDrawItemStruct->itemAction | ODA_FOCUS) &&
      (lpDrawItemStruct->itemState & ODS_FOCUS))  
      CBrush br(RGB(255, 0, 0));
      dc.FrameRect(&lpDrawItemStruct->rcItem, &br);  
   }   // Draw the text.
   dc.DrawText(      lpszText,      strlen(lpszText),
      &lpDrawItemStruct->rcItem,      DT_CENTER|DT_SINGLELINE|DT_VCENTER);
   // Reset the background color and the text color back to their
   // original values.   dc.SetTextColor(crOldTextColor);

3. Add a variable CModListBox m_ctlScheme in my main dialog box

4. Add this line in the OnCreate() (of main dialog box)


Then whenever I try to click on the listbox, or try to use "addstring" to do something to the listbox, it gives an error msg to me.
Is there anything else I need to do ??  This is the first time I create a class to use the ownerdraw function so... :)
Question by:rw8
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 5
LVL 10

Accepted Solution

RONSLOW earned 100 total points
ID: 2688415
don't create it like that.

Put a normal listbox in your dialog (make sure it is owner-drawn etc).

Then use DDX_Control to subclass it.  Alternatively, use SubclassWindow if you don't like MFC's easy dataexchange and ClassWizard

Then that listbox in the dialog will be associated with you m_ctlScheme and m_ctlScheme will get the message etc.

BTW: instead of attaching and detaching from a DC, use this...

CDC* pDC = CDC::FromHandle(lpDIS->hDC);

then use pDC-> and no need to detatch, delete etc the pDC.

LVL 10

Expert Comment

ID: 2688416
You _could_ use OnCtlColor to change the colour (background and text) instead.  Then you don't need to make it owner drawn.


Author Comment

ID: 2688714
can you give me an example of how to use OnCtlColor to change the colour? Do I need to derive a new class?
Do you have a plan for Continuity?

It's inevitable. People leave organizations creating a gap in your service. That's where Percona comes in.

See how relies on Percona to:
-Manage their database
-Guarantee data safety and protection
-Provide database expertise that is available for any situation


Expert Comment

ID: 2688946
Hi rw8
   RONSLOW is right. Just for changing the text and background color you need not make is owner drawn. OnCtlColor works but if I am right, text color and only background color of the text changes and not the background color of the control.
   Take a look at the Technical article 62(TN062) in MSDN. You will find a step by step procedure to change the text and bkground color of an edit box. Just apply it for the list box.

All the best.


Author Comment

ID: 2691571
Yes. It works! But I have a problem... the listbox remains the default colour (black text over white background) unless I put "invalidate" in the CtlColor function..  however, if I do this.. the listbox keeps on redrawing itself ..
should I put Invalidate() in somewhere else?
LVL 10

Expert Comment

ID: 2691729
show us your code .. that behaviour shouldn't be happening

Author Comment

ID: 2691776
this is the class I created (base on CListBox)

      m_text = RGB(255, 0, 0 );
    m_background = RGB( 0, 255, 0 );
    m_brBkgnd.CreateSolidBrush( m_background );



// CBlackListBox message handlers

HBRUSH CBlackListBox::CtlColor(CDC* pDC, UINT nCtlColor)
      // TODO: Change any attributes of the DC here
     pDC->SetTextColor( m_text );    // text
     pDC->SetBkColor( m_background );    // text bkgnd
     return m_brBkgnd;                // ctl bkgnd
      // return NULL;


and I add a ListBox in my main dialog box and attach a CBlacklistbox ctl varible to it.. and I didn't change any settings of the the listbox.
LVL 10

Expert Comment

ID: 2691792
On first inspection it looks ok .. I'll give it a try when I havea few mintes.


Author Comment

ID: 2691815
wait ronslow, I just created another listbox and it seems ok now. I'll do some more tests now
LVL 10

Expert Comment

ID: 2691832
the plot thickens....

Author Comment

ID: 2691976
Thanx RONSLOW. It's working now. And thanx  V Bapat too. :)

Featured Post

Want Experts Exchange at your fingertips?

With Experts Exchange’s latest app release, you can now experience our most recent features, updates, and the same community interface while on-the-go. Download our latest app release at the Android or Apple stores today!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: Dialogs (1) modal - maintaining the database. Continuing from the ninth article about sudoku.   You might have heard of modal and modeless dialogs.  Here with this Sudoku application will we use one of each type: a modal dialog …
If you use Adobe Reader X it is possible you can't open OLE PDF documents in the standard. The reason is the 'save box mode' in adobe reader X. Many people think the protected Mode of adobe reader x is only to stop the write access. But this fe…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
Visualize your data even better in Access queries. Given a date and a value, this lesson shows how to compare that value with the previous value, calculate the difference, and display a circle if the value is the same, an up triangle if it increased…

623 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question