Solved

CString.Format()

Posted on 2000-04-27
8
519 Views
Last Modified: 2013-11-20
When using a CString, it appears to truncate a 255 chars.  How do you control this?

TIA
Pat...
0
Comment
Question by:patrickm
8 Comments
 
LVL 3

Expert Comment

by:mnewton022700
ID: 2754961
Can you show me the code in which the truncating takes place. CString doesn't truncate. I was able to use a string of over 300 characters without any problems using the CString::Format method.
0
 
LVL 10

Expert Comment

by:RONSLOW
ID: 2755006
Trace output certainly has this problem

Also output in the debug window has similar limitations.

Perhap-s this is what you are observing?
0
 
LVL 1

Expert Comment

by:Mensana
ID: 2757049
According to the MSDN: "A CString object can store up to INT_MAX (2,147,483,647) characters.". Your problem must be elsewhere. Where you try to see the string with the trace output/watch utility try to issue a command:

AfxMessageBox(strYourString);

This will display a message box that can accomodate far bigger strings that 255 chars.
0
 

Expert Comment

by:khyatt
ID: 2757350
You may have a "\0" character in there. What are you trying to do? Sometimes you need a string with embedded "\0"s, but then you need to treat it differently if you want to print it out.
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 3

Expert Comment

by:GlennDean
ID: 2757539
khyatt has a good point.  If you need the buffer for the CString and you suspect there may be \0 in there, you can "manually" check by calling GetBuffer("some large number");  
Simply analyze the returned buffer and check for \0.  Don't forget to call ReleaseBuffer after you're done.
   Glenn
0
 
LVL 2

Expert Comment

by:freshmeat
ID: 2757968
from MSDN:


CString::Format
void Format( LPCTSTR lpszFormat, ... );

void Format( UINT nFormatID, ... );

Parameters

lpszFormat

A format-control string.

nFormatID

The string resource identifier that contains the format-control string.

Remarks

Call this member function to write formatted data to a CString in the same way that sprintf formats data into a C-style character array. This function formats and stores a series of characters and values in the CString. Each optional argument (if any) is converted and output according to the corresponding format specification in lpszFormat or from the string resource identified by nFormatID.

The call will fail if the string object itself is offered as a parameter to Format. For example, the following code:

CString str = "Some Data";
str.Format("%s%d", str, 123);   // Attention: str is also used in the parameter list.

will cause unpredictable results.

When you pass a character string as an optional argument, you must cast it explicitly as LPCTSTR. The format has the same form and function as the format argument for the printf function. (For a description of the format and arguments, seeprintf in the Run-Time Library Reference.) A null character is appended to the end of the characters written.

For more information, seesprintf in the Run-Time Library Reference.

Example

CString str;

str.Format(_T("Floating point: %.2f\n"), 12345.12345);
_tprintf("%s", (LPCTSTR) str);

str.Format(_T("Left-justified integer: %.6d\n"), 35);
_tprintf("%s", (LPCTSTR) str);

str.Format(IDS_SCORE, 5, 3);
_tprintf("%s", (LPCTSTR) str);
   

Output

If the application has a string resource with the identifier IDS_SCORE that contains the string "Penguins: %d\nFlyers  : %d\n", the above code fragment produces this output:

Floating point: 12345.12
Left-justified integer: 000035
Penguins: 5
Flyers  : 3

0
 

Author Comment

by:patrickm
ID: 2758735
Thank you all for your suggestions.

szQuery is truncated to 255 chars after assignment when viewd in the debugger, so RONSLOW may be correct, except for the fact I receive an error "error retrieving record" when executed
Here's a snippet of the offending code:


      CString strFromDate,strToDate;
      CString strOut("");
      strFromDate = dlg.m_pszLowRange;
      strToDate = dlg.m_pszHighRange;
      DWORD dwERROR = GetLastError();
      // Get Recordset
      CItemSet m_pItemSet;
      CInvoiceDetailSet m_pSet;
      CString szQuery("");
      CString szQuery1("");
      CString szQuery2("");
      szQuery.Format("SELECT D.INVOICE_NO,D.LINE_SEQ,D.LINE_TYPE,D.ITEM_NUMBER,D.WAREHOUSE_CODE,D.PRODUCT_LINE,D.ITEM_DESC,D.COGS_ACCOUNT,D.OriginalPrice,D.QTY_SHIPPED,D.UNIT_PRICE,D.EXTENSION,D.UNIT_COST,D.GL_SALES_ACCT,H.INVOICE_NO,H.INVOICE_DATE from InvoiceDetail D,InvoiceHeader H WHERE H.INVOICE_NO = D.INVOICE_NO AND INVOICE_DATE BETWEEN #%s# AND #%s# ORDER BY H.INVOICE_NO,D.LINE_SEQ",strFromDate,strToDate) ;
      m_pSet.Open(AFX_DB_USE_DEFAULT_TYPE,szQuery);
      if( m_pSet.IsBOF())  // Test for empty record set
      {
            strOut.Format("There are No Sales on File for %s",dlg.m_pszRange);
            AfxMessageBox(strOut,MB_OK);
            return;    // The recordset is empty
      }

0
 
LVL 10

Accepted Solution

by:
RONSLOW earned 50 total points
ID: 2761868
This could be a SQL restriction.  Perhaps the ## strings are to big?

If you want to see if the string is truncated, print out the length of the string and (say) the last few characters (use the 'Right' function).

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
ADO Memory leak with DELPHI 2007 37 170
Strange date stored 22 106
no14 challenge 14 62
Not needed 13 92
Here is how to use MFC's automatic Radio Button handling in your dialog boxes and forms.  Beginner programmers usually start with a OnClick handler for each radio button and that's just not the right way to go.  MFC has a very cool system for handli…
Introduction: Dialogs (1) modal - maintaining the database. Continuing from the ninth article about sudoku.   You might have heard of modal and modeless dialogs.  Here with this Sudoku application will we use one of each type: a modal dialog …
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
I designed this idea while studying technology in the classroom.  This is a semester long project.  Students are asked to take photographs on a specific topic which they find meaningful, it can be a place or situation such as travel or homelessness.…

932 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now