Solved

Strings

Posted on 2000-05-01
8
505 Views
Last Modified: 2008-03-03
I am having problems converting a string that has uppercase letters to all lower case. this is my program. it is for a cgi application:




#include<iostream>

#include<string>

#include<fstream>



//ADDED

#include "libcgi++.h"

// this is a good cgi form parsing class, compliant with the program
and Unix systems





//This program is in charge of the search done by location.

//What it does is that if the user enters the name of the town

//it open that town file,if that file exists it outputs all

//the info in that file.[ Complexity is O(1)]







void main()

{


//ADDED

cout << "Content-type: text/html\n\n"; // because we will generate HTML

cout << "<HTML><HEAD></HEAD><BODY>"; // start of the HTML page

Cgi *input = new Cgi();

// it uses exceptions

try

{

  input = new Cgi();

}

catch (Cgi::CgiException& e)

{

   cerr << "Error while decoding" << endl << "(maybe called from
command-line?)." << endl;

   // do some other error processing

}

// here: instead of using cin, now you read from the form

// LOOK at the access to input[]: IT MEANS THAT THE VARIABLE NAME IN
FORM.HTML IS "town"



string townName = (*input)["town"];



string x("mayaguez"), y("aguada"), z("aguadilla"), a("rincon"), b("cabo
rojo"), c("san juan");





getline(cin,townName);



strlwr( (char *)townName.c_str());



if
(townName==x||townName==y||townName==z||townName==a||townName==b||townName==c)

{



townName+=string(".txt");





fstream in(townName.c_str(),ios::in);

    if(!in)

    {

       //if this happens the user should be sent to a page

       //that tells to hit back button and start search again



       cout<<"Hit back button"<<"<BR>";

           cout<<"Place not found"<<"<BR>";

       return 0;

    }

    string read;

    while(!in.eof())

    {

       getline(in,read);



       //This are the results of this search which have to

       //be output to the screen.If possible a link should be

       //provided to a page with restaurant menu*/

       

        // Ok, here I have put the "<BR>" linebreak instead of "\n" because we
are writing HTML!!!

        cout<<read<<"<BR>";

        // if you want to have a link, just output this commented line instead

        // note that I have to double the HTML quotes (to get them in the
HTML)

        //cout << "<a href=""http://www.yourlink.here"">" << read <<
"</a><BR>";

    }

}



cout << "</BODY></HTML>"; // ends the HTML page properly



}



I am using this to change it to lowercase but I am getting and error when I compile it in g++. I am using Unix:


strlwr( (char *)townName.c_str());

what I am doing wrong?
0
Comment
Question by:milalik
  • 3
  • 3
  • 2
8 Comments
 
LVL 14

Expert Comment

by:AlexVirochovsky
Comment Utility
0
 
LVL 22

Expert Comment

by:nietod
Comment Utility
The code

strlwr( (char *)townName.c_str());

is very dangerious.  The pointer returned by c_str() is a constant character pointer.  That is, it is a pointer to characters that must not be changed!  The reason you have to perform that cast (the "(char *)") is that the compiler won't allow you to change those characters because it is unsafe.

A quick fix is to just do

townName = strlwr(townName.c_str());
0
 
LVL 22

Expert Comment

by:nietod
Comment Utility
Opps that fix is not good.  No you have to use tolower().  But I see Alex has already answered....
0
 

Author Comment

by:milalik
Comment Utility
std::transform(s.begin(), s.end(), s.begin(), ::tolower); ???

what does that means? and where should it be placed?
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 
LVL 14

Expert Comment

by:AlexVirochovsky
Comment Utility
instead of
>>strlwr( (char *)townName.c_str());
set
std::transform(townName.begin(), townName.end(), townName.begin(), ::tolower);

That meebs: make some function (tolower)
from begin to end and store result
from begin od townName

Next is text from BC Help:

transform

      Algorithm

Applies an operation to a range of values in a collection and stores the result.

Syntax

#include <algorithm>
template <class InputIterator,

          class OutputIterator,
          class UnaryOperation>
OutputIterator transform (InputIterator first,
                          InputIterator last,
                          OutputIterator result,

                          UnaryOperation op);

template <class InputIterator1,

          class InputIterator2,
          class OutputIterator,
          class BinaryOperation>
OutputIterator transform (InputIterator1 first1,
                          InputIterator1 last1,
                          InputIterator2 first2,
                          OutputIterator result,

                          BinaryOperation binary_op);

Description

The transform algorithm has two forms. The first form applies unary operation op to each element of the range [first,last), and sends the result to the output iterator result. For example, this version of transform, could be used to square each element in a vector. If the output iterator (result) is the same as the input iterator used to traverse the range, transform, performs its transformation inplace.
The second form of transform applies a binary operation, binary_op, to corresponding elements in the range [first1, last1) and the range that begins at first2, and sends the result to result. For example, transform can be used to add corresponding elements in two sequences, and store the set of sums in a third. The algorithm assumes, but does not check, that the second sequence has at least as many elements as the first sequence. Note that the output iterator result can be a third sequence, or either of the two input sequences.

Formally, transform assigns through every iterator i in the range [result, result + (last1 - first1)) a new corresponding value equal to:

op(*(first1 + (i - result))

or

binary_op(*(first1 + (i - result), *(first2 + (i - result)))

transform returns result + (last1 - first1). op and binary_op must not have any side effects. result may be equal to first in case of unary transform, or to first1 or first2 in case of binary transform.
Exactly last1 - first1 applications of op or binary_op are performed.

Example

 #include<functional>

 #include<deque>
 #include<algorithm>

 #include<iomanip.h>
 using namespace std;

 int main()

 {
   //Initialize a deque with an array of ints
   int arr1[5] = {99, 264, 126, 330, 132};
   int arr2[5] = {280, 105, 220, 84, 210};

   deque<int> d1(arr1, arr1+5), d2(arr2, arr2+5);

   //Print the original values

   cout << "The following pairs of numbers: "
        << endl << "     ";
   deque<int>::iterator i1;
   for(i1 = d1.begin(); i1 != d1.end(); i1++)
      cout << setw(6) << *i1 << " ";
   cout << endl << "     ";
   for(i1 = d2.begin(); i1 != d2.end(); i1++)

      cout << setw(6) << *i1 << " ";

   // Transform the numbers in the deque to their

   // factorials and store in the vector
   transform(d1.begin(), d1.end(), d2.begin(),

             d1.begin(), times<int>());

   //Display the results

   cout << endl << endl;
   cout << "Have the products: " << endl << "     ";
   for(i1 = d1.begin(); i1 != d1.end(); i1++)

     cout << setw(6) << *i1 << " ";

   return 0;

 }

Rogue Wave Standard C++ Library User's Guide and Tutorial
0
 

Author Comment

by:milalik
Comment Utility
thanx
0
 
LVL 14

Accepted Solution

by:
AlexVirochovsky earned 50 total points
Comment Utility
If the discussion helps you, i am very glad.
Alex
0
 

Author Comment

by:milalik
Comment Utility
Yes it does help.
=)
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

This article will show you some of the more useful Standard Template Library (STL) algorithms through the use of working examples.  You will learn about how these algorithms fit into the STL architecture, how they work with STL containers, and why t…
Go is an acronym of golang, is a programming language developed Google in 2007. Go is a new language that is mostly in the C family, with significant input from Pascal/Modula/Oberon family. Hence Go arisen as low-level language with fast compilation…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now