• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 146
  • Last Modified:

Stupid Newbie Question

Ok, I feel really dumb about asking this one, but I just can't seem to figure it out, so here it goes.

I have two strings:
STRING1 = 5182000
STRING2 =  532000

then, I compare them like so:
if string1 < string2 then msgbox "do something"

Now, obviously, string1 is not less than string2, yet vb tells me it is.

I realize that I should be comparing integers, however, they are strings that I am getting, and when I try to convert them to integers, I get an "Overflow" error.

I guess, if I could just somehow convert a string to an integer, I think my problems would be solved.... Help!
0
cantrell
Asked:
cantrell
1 Solution
 
JagarCommented:
Do this
if CInt(String1) < CInt(String2) then msgbox "Do Something"

CInt is a function that will convert the parameter to an Integer.  There is also CLng, CDbl, CSng, etc.
0
 
deshmukhnCommented:
VB is doing string comparison hence string1 is less than string2. Use CLng and then Compare.
0
 
wsh2Commented:
String comparisons in VB are from Left to Right.. numeric comparisons the opposite.

The CInt function that Jagr gave you above will convert the string to Integer.. BUT it will also Error Out because your numbers are larger than 32k (the limit for Integers). The better function to use is Val(String) as it is Int, Lng, Dbl, Sng insensitive.. and will automatically type the string for your comparison. In effect, you would then change your IF statement to read:

If Val(String1) < Val(String2) Then ...





0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
Erick37Commented:
Or use CDec to convert to the Decimal data type:

Private Sub Command1_Click()
    Dim s1 As String, s2 As String
    s1 = "5182000"
    s2 = "532000"
    If CDec(s1) < CDec(s2) Then
        MsgBox s1 & " < " & s2
    End If
End Sub
0
 
BarryTiceCommented:
The overflow error is because integers can only handle numbers up to 32767.

If you convert the numbers to longs, rather than integers, things will be hunky dory.


Dim String1 As String
Dim String2 As String
Dim Long1 As Long
Dim Long2 As Long

String1 = "5182000"
String2 = "532000"

Long1 = CLng(String1)
Long2 = CLng(String2)

If Long1 < Long2 Then
    ' Do somthing
    MsgBox True
Else
    ' Do something else
    MsgBox False
End If

Hope this helps -- b.r.t.
0
 
BarryTiceCommented:
Oops. I didn't see deshmukhn's response.
0
 
BarryTiceCommented:
That's what I get for skimming other posts before responding. Sorry guys!
0
 
cantrellAuthor Commented:
everyone seems to have good answers/comments. However, the proposed answer had problems (as stated by 'wsh2') and "wsh2's" comment was the first one in the list that worked for what I needed it to do - otherwise, I would give everyone the points.

Thank you all.
0

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now