Solved

Stupid Newbie Question

Posted on 2000-05-03
8
139 Views
Last Modified: 2010-05-02
Ok, I feel really dumb about asking this one, but I just can't seem to figure it out, so here it goes.

I have two strings:
STRING1 = 5182000
STRING2 =  532000

then, I compare them like so:
if string1 < string2 then msgbox "do something"

Now, obviously, string1 is not less than string2, yet vb tells me it is.

I realize that I should be comparing integers, however, they are strings that I am getting, and when I try to convert them to integers, I get an "Overflow" error.

I guess, if I could just somehow convert a string to an integer, I think my problems would be solved.... Help!
0
Comment
Question by:cantrell
8 Comments
 
LVL 2

Expert Comment

by:Jagar
ID: 2774586
Do this
if CInt(String1) < CInt(String2) then msgbox "Do Something"

CInt is a function that will convert the parameter to an Integer.  There is also CLng, CDbl, CSng, etc.
0
 

Expert Comment

by:deshmukhn
ID: 2774626
VB is doing string comparison hence string1 is less than string2. Use CLng and then Compare.
0
 
LVL 14

Accepted Solution

by:
wsh2 earned 50 total points
ID: 2774628
String comparisons in VB are from Left to Right.. numeric comparisons the opposite.

The CInt function that Jagr gave you above will convert the string to Integer.. BUT it will also Error Out because your numbers are larger than 32k (the limit for Integers). The better function to use is Val(String) as it is Int, Lng, Dbl, Sng insensitive.. and will automatically type the string for your comparison. In effect, you would then change your IF statement to read:

If Val(String1) < Val(String2) Then ...





0
 
LVL 32

Expert Comment

by:Erick37
ID: 2774633
Or use CDec to convert to the Decimal data type:

Private Sub Command1_Click()
    Dim s1 As String, s2 As String
    s1 = "5182000"
    s2 = "532000"
    If CDec(s1) < CDec(s2) Then
        MsgBox s1 & " < " & s2
    End If
End Sub
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 7

Expert Comment

by:BarryTice
ID: 2775452
The overflow error is because integers can only handle numbers up to 32767.

If you convert the numbers to longs, rather than integers, things will be hunky dory.


Dim String1 As String
Dim String2 As String
Dim Long1 As Long
Dim Long2 As Long

String1 = "5182000"
String2 = "532000"

Long1 = CLng(String1)
Long2 = CLng(String2)

If Long1 < Long2 Then
    ' Do somthing
    MsgBox True
Else
    ' Do something else
    MsgBox False
End If

Hope this helps -- b.r.t.
0
 
LVL 7

Expert Comment

by:BarryTice
ID: 2775455
Oops. I didn't see deshmukhn's response.
0
 
LVL 7

Expert Comment

by:BarryTice
ID: 2775458
That's what I get for skimming other posts before responding. Sorry guys!
0
 
LVL 2

Author Comment

by:cantrell
ID: 2775767
everyone seems to have good answers/comments. However, the proposed answer had problems (as stated by 'wsh2') and "wsh2's" comment was the first one in the list that worked for what I needed it to do - otherwise, I would give everyone the points.

Thank you all.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction While answering a recent question (http://www.experts-exchange.com/Q_27402310.html) in the VB classic zone, I wrote some VB code in the (Office) VBA environment, rather than fire up my older PC.  I didn't post completely correct code o…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
Get people started with the process of using Access VBA to control Excel using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Excel. Using automation, an Access application can laun…

861 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

23 Experts available now in Live!

Get 1:1 Help Now