Solved

Dynamically creating an array of structures

Posted on 2000-05-05
5
137 Views
Last Modified: 2013-11-20
Hi all
Win 95; VC 5.0 SP3

I am trying to create an array dynamically. this sort of works but I am
having trouble with memory leaks when destrying the array. any ideas.

CScaleThread **  ScThread;

in OnInitialUpdate()
{
....
 if (pDoc->iNumScales)
  {
  ScThread = new CScaleThread *[pDoc->iNumScales];
  }

 for (int y = 0; y < pDoc->iNumScales; y++)
  {
  ScThread[y] = 0;
  }
....
 for (int x =0; x < pDoc->iNumScales; x++)
  {
  GetDialogSize(&R);
  ScThread[x] = new CScaleThread;
  ScThread[x]->CreateThread(CREATE_SUSPENDED);
// Other stuff here
  ScThread[x]->ResumeThread();
  }
...
}

In OnDestroy()
{
 CTestscrollDoc* pDoc = GetDocument();
 if (ScThread)
  {
  for (int x =0; x < pDoc->iNumScales; x++)
   {
   if (ScThread[x])
    delete ScThread[x];
   }
  delete [] ScThread;
  }
 ScThread = 0;
}

This leaves me with a whole host of memory leaks. Why?
0
Comment
Question by:tcss
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
5 Comments
 
LVL 49

Expert Comment

by:DanRollins
ID: 2784646
You did not provide the definition of a CScaleThread.  It is possible that the ctor of this object allocates but the dtor does not free.

Also make sure that your OnDestroy() is in fact being called and when (put a break point there).  If it is not being called, put the delete stuff in the the dtor of the window object or call it from some other point in the program.

0
 
LVL 1

Author Comment

by:tcss
ID: 2787223
Hi Dan
Thank you for your input. By commenting you "took the blinkers" off my thinking. I found that the memory leak is comming from a "tested and working" portion of the code.

Though you did not answer the question directly (because the answer lay beyound the question asked) your invaluble comment helped be find the problem. Should you want the points, please replay with an answer indicating so. If not comment as such and I can delete the question.

Many thanks
Hylton
0
 
LVL 1

Author Comment

by:tcss
ID: 2797690
This question has a deletion request Pending
0
 
LVL 49

Expert Comment

by:DanRollins
ID: 2797733
This question no longer is pending deletion
0
 
LVL 49

Accepted Solution

by:
DanRollins earned 100 total points
ID: 2797734
Yes, I want points otherwise I would not bother answering questions.
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
sumNumber challenge 16 147
format the code in java 6 116
mapBully challenge 6 198
Detect file exist or not 3 215
Here is how to use MFC's automatic Radio Button handling in your dialog boxes and forms.  Beginner programmers usually start with a OnClick handler for each radio button and that's just not the right way to go.  MFC has a very cool system for handli…
This is to be the first in a series of articles demonstrating the development of a complete windows based application using the MFC classes.  I’ll try to keep each article focused on one (or a couple) of the tasks that one may meet.   Introductio…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
Finding and deleting duplicate (picture) files can be a time consuming task. My wife and I, our three kids and their families all share one dilemma: Managing our pictures. Between desktops, laptops, phones, tablets, and cameras; over the last decade…

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question