Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

x
?
Solved

Dynamically creating an array of structures

Posted on 2000-05-05
5
Medium Priority
?
139 Views
Last Modified: 2013-11-20
Hi all
Win 95; VC 5.0 SP3

I am trying to create an array dynamically. this sort of works but I am
having trouble with memory leaks when destrying the array. any ideas.

CScaleThread **  ScThread;

in OnInitialUpdate()
{
....
 if (pDoc->iNumScales)
  {
  ScThread = new CScaleThread *[pDoc->iNumScales];
  }

 for (int y = 0; y < pDoc->iNumScales; y++)
  {
  ScThread[y] = 0;
  }
....
 for (int x =0; x < pDoc->iNumScales; x++)
  {
  GetDialogSize(&R);
  ScThread[x] = new CScaleThread;
  ScThread[x]->CreateThread(CREATE_SUSPENDED);
// Other stuff here
  ScThread[x]->ResumeThread();
  }
...
}

In OnDestroy()
{
 CTestscrollDoc* pDoc = GetDocument();
 if (ScThread)
  {
  for (int x =0; x < pDoc->iNumScales; x++)
   {
   if (ScThread[x])
    delete ScThread[x];
   }
  delete [] ScThread;
  }
 ScThread = 0;
}

This leaves me with a whole host of memory leaks. Why?
0
Comment
Question by:tcss
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
5 Comments
 
LVL 49

Expert Comment

by:DanRollins
ID: 2784646
You did not provide the definition of a CScaleThread.  It is possible that the ctor of this object allocates but the dtor does not free.

Also make sure that your OnDestroy() is in fact being called and when (put a break point there).  If it is not being called, put the delete stuff in the the dtor of the window object or call it from some other point in the program.

0
 
LVL 1

Author Comment

by:tcss
ID: 2787223
Hi Dan
Thank you for your input. By commenting you "took the blinkers" off my thinking. I found that the memory leak is comming from a "tested and working" portion of the code.

Though you did not answer the question directly (because the answer lay beyound the question asked) your invaluble comment helped be find the problem. Should you want the points, please replay with an answer indicating so. If not comment as such and I can delete the question.

Many thanks
Hylton
0
 
LVL 1

Author Comment

by:tcss
ID: 2797690
This question has a deletion request Pending
0
 
LVL 49

Expert Comment

by:DanRollins
ID: 2797733
This question no longer is pending deletion
0
 
LVL 49

Accepted Solution

by:
DanRollins earned 300 total points
ID: 2797734
Yes, I want points otherwise I would not bother answering questions.
0

Featured Post

Moving data to the cloud? Find out if you’re ready

Before moving to the cloud, it is important to carefully define your db needs, plan for the migration & understand prod. environment. This wp explains how to define what you need from a cloud provider, plan for the migration & what putting a cloud solution into practice entails.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: The undo support, implementing a stack. Continuing from the eigth article about sudoku.   We need a mechanism to keep track of the digits entered so as to implement an undo mechanism.  This should be a ‘Last In First Out’ collec…
If you use Adobe Reader X it is possible you can't open OLE PDF documents in the standard. The reason is the 'save box mode' in adobe reader X. Many people think the protected Mode of adobe reader x is only to stop the write access. But this fe…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
How to fix incompatible JVM issue while installing Eclipse While installing Eclipse in windows, got one error like above and unable to proceed with the installation. This video describes how to successfully install Eclipse. How to solve incompa…
Suggested Courses

715 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question