finding item

When I enter in an item to search the PCID field with I am running into problems.  If I enter in the first item in the record I get "good find" but if I enter in anything else I get "bad find".  I get this even when I enter in good search item.  Below is my code.

Option Explicit
'declare database variables
Public db As Database
Public rs As Recordset
Private Sub Cancel_Click()

    'quits login and closes program
    Unload LogInForm
   
End Sub
Private Sub Form_Load()

    'open database
    Set db = DBEngine.Workspaces(0).OpenDatabase(App.Path & "\tenneco.mdb")
    Set rs = db.OpenRecordset("select PCID from parts", dbOpenDynaset)
    rs.MoveLast
   
   
    'centers login in center of screen
    Me.Top = (Screen.Height - Me.Height) / 2
    Me.Left = (Screen.Width - Me.Width) / 2
   
    'starts user in login box
    LogInForm.Show
    OperatorID.SetFocus
       
End Sub
Private Sub LogIn_Click()
 
    If rs.RecordCount > 0 Then rs.MoveLast
    rs.MoveFirst
   
    If rs.Fields("PCID").Value = LogInForm.OperatorID.Text Then
        MsgBox "good find"
    Else
        MsgBox "bad find"
    End If
               
End Sub

TIA
Craig
csindorfAsked:
Who is Participating?
Advertise Here
 
deightonConnect With a Mentor Commented:
When comparing strings "ABCD" can be different from "ABCD ".  Trim removes any leading or trailing or leading spaces to give you a nice clean string.  

ucase converts lower case to upper case.  That way "ABCD" can be matched with "abcd" (no case sensitivity).  You'd remove the ucase if you needed case sensitivity.  

You don't necessarily need to use the trim & ucase functions.  

..FindFirst simply finds the first record matching the search parameter.  
..noMatch tells you when no record is found

As was mentioned earlier by PaulHews you need to get string parameters  enclosed within  '        ', but not with numerics.




Another idea to make it easier to see what is happening.


Private Sub LogIn_Click()

dim sscan as string

msgbox sscan

sscan = "ucase(trim(PCID)) = '" & ucase(trim(LogInForm.OperatorID.Text))  &    "'"

  rs.FindFirst sscan
                                                                   
                                      If Not rs.NoMatch Then
                                              MsgBox "good find"
                                        Else
                                             MsgBox "bad find"
                                         End If
                                                 
                                        End Sub
0
 
deightonCommented:

                    Private Sub LogIn_Click()
                     
                       
                        rs.FindFirst "PCID = " &  LogInForm.OperatorID.Text
                         
                        If not rs.NoMatch Then
                            MsgBox "good find"
                        Else
                            MsgBox "bad find"
                        End If
                                     
                    End Sub
0
 
csindorfAuthor Commented:
Adjusted points from 50 to 60
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Access It Now
 
csindorfAuthor Commented:
I get "Data type mismatch in criteria expression"

Here is the code as you suggested:
Option Explicit
'declare database variables
Public db As Database
Public rs As Recordset
Private Sub Cancel_Click()

    'quits login and closes program
    Unload LogInForm
   
End Sub
Private Sub Form_Load()

    'open database
    Set db = DBEngine.Workspaces(0).OpenDatabase(App.Path & "\tenneco.mdb")
    Set rs = db.OpenRecordset("select PCID from parts")
    rs.MoveLast

    'centers login in center of screen
    Me.Top = (Screen.Height - Me.Height) / 2
    Me.Left = (Screen.Width - Me.Width) / 2
   
    'starts user in login box
    LogInForm.Show
    OperatorID.SetFocus
       
End Sub
Private Sub LogIn_Click()

    rs.FindFirst "PCID = " & LogInForm.OperatorID.Text
                         
    If Not rs.NoMatch Then
        MsgBox "good find"
    Else
        MsgBox "bad find"
    End If
       
End Sub
0
 
PaulHewsCommented:
Deighton's answer is correct, but if the PCID field is a string, you will need:
 rs.FindFirst "PCID = '" & LogInForm.OperatorID.Text & "'"

String values in query criteria have to have single or double quotes around them.
0
 
csindorfAuthor Commented:
But if I enter in PCID which is the column name it come back ok, but if I enter in a value in that column no good.

TIA

Craig
0
 
deightonCommented:
Private Sub LogIn_Click()

                        rs.FindFirst "ucase(trim(PCID)) = '" & ucase(trim(LogInForm.OperatorID.Text))  & "'"
                                               
                        If Not rs.NoMatch Then
                            MsgBox "good find"
                        Else
                            MsgBox "bad find"
                        End If
                             
                    End Sub
0
 
csindorfAuthor Commented:
That was it deighton!  Great.  could you please explain the line: rs.FindFirst "ucase(trim(PCID)) = '" & ucase(trim(LogInForm.OperatorID.Text))  & "'"

that way I can understand better what the code is doing.

Craig    
                       
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.