Please Help WriteFile API

Hi I can someone give me some examples and reading and writeing files useing the Win API at the moment I have just been useing the normal vb way Open file for binary and so On.

Anyway Since I made a new program that can removes files form your system like a file wipeing tool I have run in to problums with the speed when dealing with big files anyway I hope someone can help. I have also included some of the code I am useing the so you will see what I mean when I say it goes solw. well I hope someone can help anyway I will be very helpfull.

Private Function WipeFiles(lzPath As String)
Dim Icount As Long
Dim TChar1 As String
Dim TChar2 As String
Dim T As Long

TFile = FreeFile
    On Error Resume Next
    x = Dir(lzPath, vbHidden)
    Do While x <> ""
        Open lzPath & x For Binary As #TFile
            FLen = LOF(TFile)
            For Icount = 0 To FLen
                    TChar1 = Chr(Val(Int(160 * Rnd) + 1))
                    TChar2 = Chr(Val(Int(60 * Rnd) + 2))
                    T = Seek(TFile)
                    Put #TFile, TFile, TChar1
                    Put #TFile, T, TChar2
        Close #TFile
    Kill lzPath & x
    x = Dir
    TChar1 = "": TChar2 = "": FLen = 0: Icount = 0: T = 0
End Function

Also please let me know if there is some thing wrong with the code I useing. or why it might be going slow
Who is Participating?

[Webinar] Streamline your web hosting managementRegister Today

sharmonConnect With a Mentor Commented:
It's not your kill that is slowing it down it's the fact that you are looping through and writing to the file but not just any character you are also grabbing a random char to wipe it with.  Use bigger blocks and a predefined char to write with as in this example and it should be faster.

Sub WipeFileClean (sFileName As String)
    Dim Block1 As String, Block2 As String, Blocks As Long
    Dim hFileHandle As Integer, iLoop As Long, Offset As Long
    'Create two buffers with a specified 'wi
    '     pe-out' characters
    Const BLOCKSIZE = 4096
    Block1 = String(BLOCKSIZE, "X")
    Block2 = String(BLOCKSIZE, " ")
    'Overwrite the file contents with the wi
    '     pe-out characters
    hFileHandle = FreeFile
    Open sFileName For Binary As hFileHandle
    Blocks = (LOF(hFileHandle) \ BLOCKSIZE) + 1

    For iLoop = 1 To Blocks
        Offset = Seek(hFileHandle)
        Put hFileHandle, , Block1
        Put hFileHandle, Offset, Block2
    Next iLoop
    Close hFileHandle
    'Now you can delete the file, which cont
    '     ains no sensitive data
    Kill sFileName
End Sub
I'm not sure if doing this is the same a scrambling the data in a file but I don't know of a way to recover from this

      Open lzPath & x For Output #TFile
>Use bigger blocks and a predefined char to write with as in this example and it should be faster.

As long as you use bigger blocks it doesn't matter if you use a predefined character or not.  Randomizing the data in the block is not the slow part.
dreamvbAuthor Commented:
Thanks this now seems to work a lot better now

Thanks again and also thanks the rest of you.

I haven't timed it at all, but shouldn't throwing two more function calls in the middle of the loop slow it down more?  I can understand it might not be much, but wouldn't it be something a bit slower?  Thanks for the info if you respond.

All Courses

From novice to tech pro — start learning today.