Duke01
asked on
Can anyone tell me what is wrong with this code????????????????
This coding has been edited from a currently woking code. this should get data from a html file and put it in a table called survey. the old code did the same but to a table called customers in the same database and sent out an email witch i do not need it to do anymore... PLEASE HELP.
package uk.co.eformoney.servlets;
import java.io.*;
import java.text.*;
import java.util.*;
import javax.servlet.*;
import java.sql.*;
import javax.servlet.http.*;
import charlesworth.database.*;
import charlesworth.utils.*;
import uk.co.eformoney.Context.*;
import uk.co.eformoney.DataObject s.*;
import java.net.*;
public class SurveyDetailsServlet extends HttpServlet {
private String errorPage;
public void init(ServletConfig config){
try{
super.init(config);
System.out.println( "Init method SurveyDetailsServlet " + new java.util.Date().toGMTStri ng() );
String errorPageURL = this.getInitParameter("err orPageURL" );
//Create a pool of connections to be used by the whole application
if( ApplicationContext.getConn ectionPool () == null ){
//String username = this.getInitParameter("use rname");
// String password = this.getInitParameter("pas sword");
String url = this.getInitParameter("url ");
String driver = this.getInitParameter("dri ver");
String incrementConnectionsBy = this.getInitParameter("inc rementConn ectionsBy" );
String initialDatabaseConnections = this.getInitParameter("ini tialDataba seConnecti ons");
ApplicationContext.setConn ectionPool ( new ConnectionPool(
url,
// username,
// password,
driver,
Integer.parseInt(initialDa tabaseConn ections),
Integer.parseInt(increment Connection sBy)));
}
//Retrieve the application's standing data
ApplicationContext.populat eStandingD ata();
//Load the error page into a char array for efficiency
errorPage = ApplicationContext.getRegE rrorPage( errorPageURL );
//start the Daemon for registration mailing
// String smtpHost = this.getInitParameter("smt phost");
// String from = this.getInitParameter("fro m");
// String emailTitle = this.getInitParameter("ema ilTitle");
// String emailBodyURL = this.getInitParameter("ema ilBodyURL" );
// new EmailSender(smtpHost, from, emailTitle, emailBodyURL);
}
catch( MalformedURLException e ){
System.out.println("****** **ERROR OCCURRED AT " + new java.util.Date().toGMTStri ng() );
e.printStackTrace();
this.getServletContext().l og( "A MalformedURLException occurred while loading data for the Registration form error page. Check the url given in the initialisation parameters for this Servlet", e );
}
catch( Exception e ){
System.out.println("****** **ERROR OCCURRED AT " + new java.util.Date().toGMTStri ng() );
e.printStackTrace();
this.getServletContext().l og( "An error occurred during initialisation. Check the url given in the initialisation parameters for this Servlet and the database setup", e );
}
}
public void doGet(HttpServletRequest req,
HttpServletResponse res)
throws IOException, ServletException
{
doPost( req, res );
}
public void doPost(HttpServletRequest req,
HttpServletResponse res)
throws IOException, ServletException
{
try{
PrintWriter out = res.getWriter();
res.setContentType("text/h tml");
insertRow(req,res);
res.sendRedirect("register success.ht ml");
//showSuccessPage(out);
}
catch( DatabaseObjectException e ){
ErrorHandler.showErrorPage ( res.getWriter(),
e.getMessage(),
errorPage );
}
catch( Exception e ){
System.out.println("****** **ERROR OCCURRED AT " + new java.util.Date().toGMTStri ng() );
e.printStackTrace();
this.getServletContext().l og( "An error occurred during processing. Check the url given in the initialisation parameters for this Servlet and the database setup", e );
ErrorHandler.showErrorPage ( res.getWriter(),
"A server error occurred while processing your input.<br>The error was not your fault.<br>Please try again later.",
errorPage );
}
}
private boolean insertRow(HttpServletReque st req,
HttpServletResponse res)
throws Exception{
String referrerID = null;
//Check for a unique username
//checkUsername(req.getPar ameter("us ername"));
//Check for a correct referrer
//referrerID = getReferrer(req.getParamet er("referr er"));
//Check that the passwords match
// if( !req.getParameter("passwor d").equals ( req.getParameter("verifypa ssword") )){
// throw new DatabaseObjectException( "Your passwords do not match. Please re-enter them.");
// }
ConnectionPool pool = ApplicationContext.getConn ectionPool ();
//Create a transaction to save the registration details
SurveyRegistrationTransact ion trans = new SurveyRegistrationTransact ion();
//Create a Survey customer object to hold the form data
SurveyDBObject reg = new SurveyDBObject();
reg.setId(req.getParameter ("firstnam e"));
reg.setTitle(req.getParame ter("title "));
reg.setFirst_name(req.getP arameter(" firstname" ));
reg.setSurname(req.getPara meter("sur name"));
reg.setGender(req.getParam eter("gend er"));
reg.setDob(DatabaseUtils.g etDDMonYYY Y(req.getP arameter(" day"),req. getParamet er("month" ),req.getP arameter(" year")));
reg.setEmail_address(req.g etParamete r("e-mail" ));
reg.setAddr_1(req.getParam eter("addr ess1"));
reg.setAddr_2(req.getParam eter("addr ess2"));
reg.setTown(req.getParamet er("town") );
reg.setChildren(req.getPar ameter("ch ildren"));
reg.setAddr_county(req.get Parameter( "addr_coun ty"));
reg.setPost_code(req.getPa rameter("p ost_code") );
reg.setQ1a(req.getParamete r("q1a"));
reg.setQ1b(req.getParamete r("q1b"));
reg.setQ1c(req.getParamete r("q1c"));
reg.setQ1d(req.getParamete r("q1d"));
reg.setQ1e(req.getParamete r("q1e"));
reg.setQ2a(req.getParamete r("q2a"));
reg.setQ2b(req.getParamete r("q2b"));
reg.setQ2c(req.getParamete r("q2c"));
reg.setQ2d(req.getParamete r("q2d"));
reg.setQ3a(req.getParamete r("q3a"));
reg.setQ4a(req.getParamete r("q4a"));
reg.setQ5a(req.getParamete r("q5a"));
reg.setQ6a(req.getParamete r("q6a"));
reg.setQ7a(req.getParamete r("q7a"));
reg.setQ8a(req.getParamete r("q8a"));
reg.setQ9a(req.getParamete r("q9a"));
reg.setQ10a(req.getParamet er("q10a") );
reg.setQ11a(req.getParamet er("q11a") );
reg.setQ12a(req.getParamet er("q12a") );
reg.setQ13a(req.getParamet er("q13a") );
reg.setQ14a(req.getParamet er("q14a") );
reg.setQ15a(req.getParamet er("q15a") );
reg.setQ16a(req.getParamet er("q16a") );
reg.setQ17a(req.getParamet er("q17a") );
reg.setQ18a(req.getParamet er("q18a") );
reg.setQ19a(req.getParamet er("q19a") );
reg.setQ20a(req.getParamet er("q20a") );
reg.setQ21a(req.getParamet er("q21a") );
reg.setQ22a(req.getParamet er("q22a") );
reg.setQ23a(req.getParamet er("q23a") );
reg.setQ24a(req.getParamet er("q24a") );
reg.setQ25a(req.getParamet er("q25a") );
reg.setQ25b(req.getParamet er("q25b") );
reg.setQ25c(req.getParamet er("q25c") );
reg.setQ25d(req.getParamet er("q25d") );
reg.setQ25e(req.getParamet er("q25e") );
reg.setQ25f(req.getParamet er("q25f") );
reg.setQ26a(req.getParamet er("q26a") );
reg.setQ27a(req.getParamet er("q27a") );
reg.setQ27b(req.getParamet er("q27b") );
reg.setQ27c(req.getParamet er("q27c") );
reg.setQ28a(req.getParamet er("q28a") );
reg.setQ29a(req.getParamet er("q29a") );
reg.setQ30a(req.getParamet er("q30a") );
reg.setQ31a(req.getParamet er("q31a") );
reg.setQ32a(req.getParamet er("q32a") );
reg.setSelect(req.getParam eter("sele ct1"));
reg.setSelect3(req.getPara meter("sel ect3"));
reg.setSelect6(req.getPara meter("sel ect6"));
reg.setSelect7(req.getPara meter("sel ect7"));
reg.setSelect8(req.getPara meter("sel ect8"));
reg.setSelect9(req.getPara meter("sel ect9"));
reg.setSelect10(req.getPar ameter("se lect10"));
reg.setSelect11(req.getPar ameter("se lect11"));
reg.setSelect12(req.getPar ameter("se lect12"));
reg.setSelect13(req.getPar ameter("se lect13"));
//Add the survey details to the transaction
trans.setSurvey(reg);
//Ask the transaction to insert the data into the database
trans.insert();
//send cookies with a 90 day expiry time
//Cookie userCookie = new Cookie("username", req.getParameter("user") );
//userCookie.setMaxAge(777 6000);
//res.addCookie( userCookie);
//Cookie passCookie = new Cookie("password", req.getParameter("password ") );
//passCookie.setMaxAge(777 6000);
//res.addCookie( passCookie);
//return true;
}
{
private void showSuccessPage( PrintWriter out ){
out.println("<html>");
out.println("<head><title> Success</t itle></hea d>");
out.println("<body>");
out.println("<b><font SIZE=\"5\" COLOR=\"#007346\" FACE=\"arial,helvetica\">C ongratulat ions, you have successfully registered your survey!</font></b>");
out.println("</body></html >");
}
//private String getReferrer( String username )throws Exception{
//if( username == null || username.length() == 0 ){
// return "";
// }
//username = username.toUpperCase();
// ConnectionPool pool = ApplicationContext.getConn ectionPool ();
// Connection con = null;
// Statement stmt = null;
// try{
// con = pool.getConnection();
// stmt = con.createStatement();
// StringBuffer sql = new StringBuffer("select id from survey where 1=1 ");
// sql.append( DatabaseUtils.getWhereChar SQL(userna me, "username"));
// ResultSet result = stmt.executeQuery( sql.toString() );
// String referrerId = null;
// while( result.next() ){
// referrerId = result.getString("id");
// }
// if( referrerId == null){
// throw new DatabaseObjectException("T he referred by username you entered does not exist .<br>Please check it and re-enter.");
// }
// return referrerId;
// }
// finally{
// if( stmt != null ){
// stmt.close();
// }
// if( con != null ){
// pool.returnConnection(con) ;
// con = null;
// }
// }
// }
// private void checkUsername( String username )throws Exception{
// ConnectionPool pool = ApplicationContext.getConn ectionPool ();
// Connection con = null;
// Statement stmt = null;
// try{
// if( username == null || username.length() == 0 ){
// throw new DatabaseObjectException("P lease enter a username.");
// }
// username = username.toUpperCase();
//con = pool.getConnection();
// stmt = con.createStatement();
// StringBuffer sql = new StringBuffer("select 0 from customers where 1=1 ");
// sql.append( DatabaseUtils.getWhereChar SQL(userna me, "username"));
// ResultSet result = stmt.executeQuery( sql.toString() );
// if(result.next()){
// throw new DatabaseObjectException("T he username you entered has been taken by another user.<br>Please enter another one.");
// }
// }
// finally{
// if( stmt != null ){
// stmt.close();
// }
if( con != null ){
pool.returnConnection(con) ;
con = null;
}
package uk.co.eformoney.servlets;
import java.io.*;
import java.text.*;
import java.util.*;
import javax.servlet.*;
import java.sql.*;
import javax.servlet.http.*;
import charlesworth.database.*;
import charlesworth.utils.*;
import uk.co.eformoney.Context.*;
import uk.co.eformoney.DataObject
import java.net.*;
public class SurveyDetailsServlet extends HttpServlet {
private String errorPage;
public void init(ServletConfig config){
try{
super.init(config);
System.out.println( "Init method SurveyDetailsServlet " + new java.util.Date().toGMTStri
String errorPageURL = this.getInitParameter("err
//Create a pool of connections to be used by the whole application
if( ApplicationContext.getConn
//String username = this.getInitParameter("use
// String password = this.getInitParameter("pas
String url = this.getInitParameter("url
String driver = this.getInitParameter("dri
String incrementConnectionsBy = this.getInitParameter("inc
String initialDatabaseConnections
ApplicationContext.setConn
url,
// username,
// password,
driver,
Integer.parseInt(initialDa
Integer.parseInt(increment
}
//Retrieve the application's standing data
ApplicationContext.populat
//Load the error page into a char array for efficiency
errorPage = ApplicationContext.getRegE
//start the Daemon for registration mailing
// String smtpHost = this.getInitParameter("smt
// String from = this.getInitParameter("fro
// String emailTitle = this.getInitParameter("ema
// String emailBodyURL = this.getInitParameter("ema
// new EmailSender(smtpHost, from, emailTitle, emailBodyURL);
}
catch( MalformedURLException e ){
System.out.println("******
e.printStackTrace();
this.getServletContext().l
}
catch( Exception e ){
System.out.println("******
e.printStackTrace();
this.getServletContext().l
}
}
public void doGet(HttpServletRequest req,
HttpServletResponse res)
throws IOException, ServletException
{
doPost( req, res );
}
public void doPost(HttpServletRequest req,
HttpServletResponse res)
throws IOException, ServletException
{
try{
PrintWriter out = res.getWriter();
res.setContentType("text/h
insertRow(req,res);
res.sendRedirect("register
//showSuccessPage(out);
}
catch( DatabaseObjectException e ){
ErrorHandler.showErrorPage
e.getMessage(),
errorPage );
}
catch( Exception e ){
System.out.println("******
e.printStackTrace();
this.getServletContext().l
ErrorHandler.showErrorPage
"A server error occurred while processing your input.<br>The error was not your fault.<br>Please try again later.",
errorPage );
}
}
private boolean insertRow(HttpServletReque
HttpServletResponse res)
throws Exception{
String referrerID = null;
//Check for a unique username
//checkUsername(req.getPar
//Check for a correct referrer
//referrerID = getReferrer(req.getParamet
//Check that the passwords match
// if( !req.getParameter("passwor
// throw new DatabaseObjectException( "Your passwords do not match. Please re-enter them.");
// }
ConnectionPool pool = ApplicationContext.getConn
//Create a transaction to save the registration details
SurveyRegistrationTransact
//Create a Survey customer object to hold the form data
SurveyDBObject reg = new SurveyDBObject();
reg.setId(req.getParameter
reg.setTitle(req.getParame
reg.setFirst_name(req.getP
reg.setSurname(req.getPara
reg.setGender(req.getParam
reg.setDob(DatabaseUtils.g
reg.setEmail_address(req.g
reg.setAddr_1(req.getParam
reg.setAddr_2(req.getParam
reg.setTown(req.getParamet
reg.setChildren(req.getPar
reg.setAddr_county(req.get
reg.setPost_code(req.getPa
reg.setQ1a(req.getParamete
reg.setQ1b(req.getParamete
reg.setQ1c(req.getParamete
reg.setQ1d(req.getParamete
reg.setQ1e(req.getParamete
reg.setQ2a(req.getParamete
reg.setQ2b(req.getParamete
reg.setQ2c(req.getParamete
reg.setQ2d(req.getParamete
reg.setQ3a(req.getParamete
reg.setQ4a(req.getParamete
reg.setQ5a(req.getParamete
reg.setQ6a(req.getParamete
reg.setQ7a(req.getParamete
reg.setQ8a(req.getParamete
reg.setQ9a(req.getParamete
reg.setQ10a(req.getParamet
reg.setQ11a(req.getParamet
reg.setQ12a(req.getParamet
reg.setQ13a(req.getParamet
reg.setQ14a(req.getParamet
reg.setQ15a(req.getParamet
reg.setQ16a(req.getParamet
reg.setQ17a(req.getParamet
reg.setQ18a(req.getParamet
reg.setQ19a(req.getParamet
reg.setQ20a(req.getParamet
reg.setQ21a(req.getParamet
reg.setQ22a(req.getParamet
reg.setQ23a(req.getParamet
reg.setQ24a(req.getParamet
reg.setQ25a(req.getParamet
reg.setQ25b(req.getParamet
reg.setQ25c(req.getParamet
reg.setQ25d(req.getParamet
reg.setQ25e(req.getParamet
reg.setQ25f(req.getParamet
reg.setQ26a(req.getParamet
reg.setQ27a(req.getParamet
reg.setQ27b(req.getParamet
reg.setQ27c(req.getParamet
reg.setQ28a(req.getParamet
reg.setQ29a(req.getParamet
reg.setQ30a(req.getParamet
reg.setQ31a(req.getParamet
reg.setQ32a(req.getParamet
reg.setSelect(req.getParam
reg.setSelect3(req.getPara
reg.setSelect6(req.getPara
reg.setSelect7(req.getPara
reg.setSelect8(req.getPara
reg.setSelect9(req.getPara
reg.setSelect10(req.getPar
reg.setSelect11(req.getPar
reg.setSelect12(req.getPar
reg.setSelect13(req.getPar
//Add the survey details to the transaction
trans.setSurvey(reg);
//Ask the transaction to insert the data into the database
trans.insert();
//send cookies with a 90 day expiry time
//Cookie userCookie = new Cookie("username", req.getParameter("user") );
//userCookie.setMaxAge(777
//res.addCookie( userCookie);
//Cookie passCookie = new Cookie("password", req.getParameter("password
//passCookie.setMaxAge(777
//res.addCookie( passCookie);
//return true;
}
{
private void showSuccessPage( PrintWriter out ){
out.println("<html>");
out.println("<head><title>
out.println("<body>");
out.println("<b><font SIZE=\"5\" COLOR=\"#007346\" FACE=\"arial,helvetica\">C
out.println("</body></html
}
//private String getReferrer( String username )throws Exception{
//if( username == null || username.length() == 0 ){
// return "";
// }
//username = username.toUpperCase();
// ConnectionPool pool = ApplicationContext.getConn
// Connection con = null;
// Statement stmt = null;
// try{
// con = pool.getConnection();
// stmt = con.createStatement();
// StringBuffer sql = new StringBuffer("select id from survey where 1=1 ");
// sql.append( DatabaseUtils.getWhereChar
// ResultSet result = stmt.executeQuery( sql.toString() );
// String referrerId = null;
// while( result.next() ){
// referrerId = result.getString("id");
// }
// if( referrerId == null){
// throw new DatabaseObjectException("T
// }
// return referrerId;
// }
// finally{
// if( stmt != null ){
// stmt.close();
// }
// if( con != null ){
// pool.returnConnection(con)
// con = null;
// }
// }
// }
// private void checkUsername( String username )throws Exception{
// ConnectionPool pool = ApplicationContext.getConn
// Connection con = null;
// Statement stmt = null;
// try{
// if( username == null || username.length() == 0 ){
// throw new DatabaseObjectException("P
// }
// username = username.toUpperCase();
//con = pool.getConnection();
// stmt = con.createStatement();
// StringBuffer sql = new StringBuffer("select 0 from customers where 1=1 ");
// sql.append( DatabaseUtils.getWhereChar
// ResultSet result = stmt.executeQuery( sql.toString() );
// if(result.next()){
// throw new DatabaseObjectException("T
// }
// }
// finally{
// if( stmt != null ){
// stmt.close();
// }
if( con != null ){
pool.returnConnection(con)
con = null;
}
I can tell you is a big source. What kind of error are you getting ? Describe the simptoms. By a "look from an airplane" I say that at the end of the code posted here you have left an uncommented if() statement and end method brace.
ASKER
When i trie to compile i get theys errors..
SurveyDetailsServlet.java: 6: Package javax.servlet not found in import.
import javax.servlet.*;
^
SurveyDetailsServlet.java: 8: Package javax.servlet.http not found in import.
import javax.servlet.http.*;
^
SurveyDetailsServlet.java: 15: Superclass uk.co.eformoney.servlets.H ttpServlet
class uk.co.eformoney.servlets.S urveyDetai lsServlet not found.
public class SurveyDetailsServlet extends HttpServlet {
SurveyDetailsServlet.java:
import javax.servlet.*;
^
SurveyDetailsServlet.java:
import javax.servlet.http.*;
^
SurveyDetailsServlet.java:
class uk.co.eformoney.servlets.S
public class SurveyDetailsServlet extends HttpServlet {
hi,
try downloading the servlet package from http://java.sun.com or if you already have it, add it to your CLASSPATH environment variable.
try downloading the servlet package from http://java.sun.com or if you already have it, add it to your CLASSPATH environment variable.
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
done that now i have new errors.
javac -deprecation SurveyDetailsServlet.java
SurveyDetailsServlet.java: 23: Note: The method java.lang.String
toGMTString() in class java.util.Date has been deprecated.
System.out.println( "Init method SurveyDetailsServlet " + new
java.util.Date().toGMTStri ng() );
^
SurveyDetailsServlet.java: 37: Wrong number of arguments in constructor.
ApplicationContext.setConn ectionPool ( new ConnectionPool(
^
SurveyDetailsServlet.java: 62: Note: The method java.lang.String
toGMTString() in class java.util.Date has been deprecated.
System.out.println("****** **ERROR OCCURRED AT " + new
java.util.Date().toGMTStri ng() );
^
SurveyDetailsServlet.java: 67: Note: The method java.lang.String
toGMTString() in class java.util.Date has been deprecated.
System.out.println("****** **ERROR OCCURRED AT " + new
java.util.Date().toGMTStri ng() );
^
SurveyDetailsServlet.java: 99: Note: The method java.lang.String
toGMTString() in class java.util.Date has been deprecated.
System.out.println("****** **ERROR OCCURRED AT " + new
java.util.Date().toGMTStri ng() );
^
SurveyDetailsServlet.java: 112: Return required at end of boolean
insertRow(javax.servlet.ht tp.HttpSer vletReques t,
javax.servlet.http.HttpSer vletRespon se).
private boolean insertRow(HttpServletReque st req,
^
Note: SurveyDetailsServlet.java uses or overrides a deprecated API. Please
consult the documentation for a better alternative.
2 errors, 1 warning
javac -deprecation SurveyDetailsServlet.java
SurveyDetailsServlet.java:
toGMTString() in class java.util.Date has been deprecated.
System.out.println( "Init method SurveyDetailsServlet " + new
java.util.Date().toGMTStri
^
SurveyDetailsServlet.java:
ApplicationContext.setConn
^
SurveyDetailsServlet.java:
toGMTString() in class java.util.Date has been deprecated.
System.out.println("******
java.util.Date().toGMTStri
^
SurveyDetailsServlet.java:
toGMTString() in class java.util.Date has been deprecated.
System.out.println("******
java.util.Date().toGMTStri
^
SurveyDetailsServlet.java:
toGMTString() in class java.util.Date has been deprecated.
System.out.println("******
java.util.Date().toGMTStri
^
SurveyDetailsServlet.java:
insertRow(javax.servlet.ht
javax.servlet.http.HttpSer
private boolean insertRow(HttpServletReque
^
Note: SurveyDetailsServlet.java uses or overrides a deprecated API. Please
consult the documentation for a better alternative.
2 errors, 1 warning
This are programming errors and some warnings about some deprecated methods.
ASKER
thanks mate..
Thanx
Cheers
RickyJackman
Cheers
RickyJackman