using CinternetSession

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

Or, not to be such a performance hog:

if(dwRet == HTTP_STATUS_OK){

while (nRead = pFile->Read(szBuff, 4096) > 0){
szBuff [ nRead + 1] = '/0'; ));// 'Read()' does not zero-terminate the buffer!!!

source.Insert(source.GetLength(),(char*)szBuff);
}
cout<<(LPCTSTR) source<<endl;
}

ASKER

could you explain what this line means, i just started on this stuff today =(

ZeroMemory ( szBuff, sizeof ( szBuff));

As we're just optimizing :o)

if(dwRet == HTTP_STATUS_OK){

while (nRead = pFile->Read(szBuff, 4096) > 0){
szBuff [ nRead + 1] = '/0'; ));// 'Read()' does not zero-terminate the buffer!!!

source += CString ( szBuff);
}
cout<<(LPCTSTR) source<<endl;
}

>>could you explain what this line means, i just started
>>on this stuff today =(
>> ZeroMemory ( szBuff, sizeof ( szBuff));

It zeroes out a memory area. A 'C'-style string is characterized by a terminating binary '0', and as the 'Read()' operation does not terminate the buffer with it, the strings you're adding are 'longer' - that's the 'extra characters' you noticed.

ASKER

>>>szBuff [ nRead + 1] = '/0'; ));
should be
szBuff [ nRead + 1] = "/0";

=)

ASKER

if(dwRet == HTTP_STATUS_OK){

while (nRead = pFile->Read(szBuff, 4096) > 0){
szBuff [ nRead + 1] = "/0";
source += CString ( szBuff);

}
cout<<(LPCTSTR) source<<endl;

}

compiler complain that:

C:\Documents\Programming\http\http.cpp(63) : error C2440: 'type cast' : cannot convert from 'char *[4096]' to 'class CString'

>>>>>szBuff [ nRead + 1] = '/0'; ));
>>should be
>>szBuff [ nRead + 1] = "/0";

No, it should read

szBuff [ nRead + 1] = '\0'; // backslash!

'\0' is a character, "\0" is a pointer to a zero-terminated string. What we want to do is inserting a null byte at the end of the stream...

BTW:

char* szBuff[4096];

is wrong, that declares an array of pointers - you probably wanted to use

char szBuff[4096];

As we need to write the terminating null byte, take that into consideration:

char szBuff[4096 + 1];

>>C:\Documents\Programming\http\http.cpp(63) : error
>>C2440: 'type cast' : cannot convert from 'char *[4096]'
>>to 'class CString'

That's related to my last comment - it should read

char szBuff[4096 + 1];

ASKER

but it doesn't print any of the html now. it did with the Zeromemory thing, but I do want to learn memory efficient coding

also it only works if I request an .asp page. as soon as i try and get an html page it dwRet give me: 405

HTTP_STATUS_BAD_METHOD 405 The method used is not allowed.

what the heck does that mean

You might want to check the sample at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vcsample98/html/_sample_mfc_tear.asp ('TEAR: "Tearing" HTML Pages Off the Internet'):

"The TEAR sample shows how to write an MFC console application that uses WININET.DLL to communicate with the Internet. The sample shows how to form an HTTP request using CHttpFile against CHttpConnection and CInternetSession objects."

This sample should also be available on your VC++ CD.

ASKER

unfortunately I'm not at home.

I'm thinking it's either how I'm setting up:

pNet = new CInternetSession(NULL, 1, PRE_CONFIG_INTERNET_ACCESS, NULL, NULL, INTERNET_FLAG_DONT_CACHE | INTERNET_FLAG_RELOAD);

or:

pNet->GetHttpConnection(site);

??

ASKER

s'ok it was

pFile = pConn->OpenRequest("GET", page); // Open an HTTP request.

instead of

pFile = pConn->OpenRequest(NULL, page); // Open an HTTP request.

ASKER

so currently it will only work like:

if(dwRet == HTTP_STATUS_OK){

ZeroMemory ( szBuff, sizeof ( szBuff));

while (nRead = pFile->Read(szBuff, 4096) > 0){

//szBuff [ nRead + 1] = '\0';
//source += CString ( szBuff);

source.Insert(source.GetLength(),(char*)szBuff);
ZeroMemory ( szBuff, sizeof ( szBuff));// 'Read()' does not zero-terminate the buffer!!!

}
cout<<"HTML RECEIVED: "<<(LPCTSTR) source<<endl;

}else{
cout<<dwRet<<endl;
}

and not

if(dwRet == HTTP_STATUS_OK){

while (nRead = pFile->Read(szBuff, 4096) > 0){
szBuff [ nRead + 1] = '\0';
source += CString ( szBuff);

}
cout<<(LPCTSTR) source<<endl;

}

this is from an active x i wrote, it may help

void CActiveXChatCtrl::OnButton()
{
/* the session must be created with a name or it asserts,
the documentation says otherwise!, typical */
CInternetSession session("session");
/* we can use the base class as we dont need the extra
functionality that CHttpFile offers (whats being returned in
our case here is a CHttpFile) but we will use the base class */
CStdioFile *file = session.OpenURL(m_url);

/* read in 100 bytes, this will call CHttpFile's Read member */
char buffer[100];
int l = file->Read(buffer,sizeof(buffer));
/* tak on a NULL */
buffer[l] = '\0';

/* set the window text of the edit control */
m_pEdit->SetWindowText(buffer);

/* delete the file object */
delete file;
/* the session will drop out of scope now and close */
}

m_url, is the url, its an object member, populated already

ASKER

well I wanted to use CString becuase it has lots of useful methods

m_url is a CString

ASKER

will a CStdioFile object let me query the pages,header info as well as the pages source?

no,
CHttpFile *file = session.OpenURL(m_url);

should work

ASKER

what is the advantage of:

pNet = new CInternetSession(NULL, 1, PRE_CONFIG_INTERNET_ACCESS, NULL, NULL, INTERNET_FLAG_DONT_CACHE
| INTERNET_FLAG_RELOAD);

pConn = pNet->GetHttpConnection(site);
pFile = pConn->OpenRequest(NULL, page);
pFile->SendRequest( );

Over

CHttpFile *file = session.OpenURL(m_url);

its alot easier to code but less powerfull, if horses for courses, use what suits

ASKER

in what way less powerful, is there a bigger performance hit or just less flexible