Link to home
Start Free TrialLog in
Avatar of RichBisset
RichBisset

asked on

onError method doesnt seem to work

I have a popup page that requests the URL of the page that openned it, using 'opener.location.href'.

The popup page is called on the unload of a page on my site and if a user closes the browser or goes to a site external to mine, the popup window checks the URL of new site and if it does not match my site it logs them out of the database (using ASP script).

The problem is that requesting the opener.location.href of the destination file (which works fine if the destination page is part of my site) brings up a JS Runtime error 'Permission Denied'.

I have tried using the onError method but that still causes an error message to appear on my browser (IE 5). However, the same code worked on a collegues browser (same ver of IE) and i was able to just 'return true'.

Both of us have Disable Script Debugging unticked on our browser settings.

This is the code i was using:

<script language=javascript>

function stopError()
     {
     return true
     }

onerror = stopError



if ((opener.location.href.indexOf( "www.myWebSitesURL.com" ) > 0 ) {
    alert("you are still on my site..")
}
else {
    alert("you are leaving my site..")
}

</script>



When this code is run and debugged the 'opener.location.href.indexOf' is highlighted with the error Permission Denied.

Basically, how can i get my browser to ignore the impending error message??


Avatar of bebonham
bebonham

I have also been frustrated by this

see

http://javascript.internet.com/messages/script-debugger.html

but it doesn't work!!
RichBisset,
In order to make the onerror work you need to turn of the debugger :
Tools >Internet Options>Advanced >Display Notification on javascript errors
Should be unchecked.

Generally the onerror is good only if you are creating a site for non-developers audience , since it's something that you cannot gurentee , the best is to use try/catch blocks in your site.

This problem might also be output of debuggers installations(Visual InterDev for example).

another thing you should do is to make an hirarchale "if " blocks for the tests, this will eleiminate the errors :

'opener.location.href.indexOf' >>
if (opener)
  if (opener.location.href)
    if (opener.location.href.indexOf('fg')!=-1)
      {
      //only then do whatever you need.
       }


Avatar of RichBisset

ASKER

avner,

The Display Notification is already unchecked and the problem still occurs.

I tried your code:

if (opener)
 if (opener.location.href)
   if (opener.location.href.indexOf('fg')!=-1)
     {
     //only then do whatever you need.
      }

but unfortunatly the permission denied occurred on the second line.

Any more ideas?

Many thanks
You should have say it's a "permission denied " error ! :)
Let me guess : Are you trying to run a script from one server to a page in a different server ?
If it's so , then this is yoour problem , javascript will just not allow such action due to security reasons.

okay, avner is right...

wow. I guess trapping errors is pretty worthless :(

always in the back of my head I thought this worked reliably...it was too good to be true.
Im running the script from my company's web server direct to my client browser. The onError method works for some of the computers here and not others. We are all using IE 4 or 5. Im using ver 5 and someone else who is also using ver 5 is able to use the script, and they seem to have the same Internet Option settings!?!

Any last ideas?
ASKER CERTIFIED SOLUTION
Avatar of avner
avner

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Thanks for the advice