Solved

Troublein FTPing with CFtpConnection

Posted on 2001-09-12
4
1,200 Views
Last Modified: 2013-11-20

Hi,

I've developed a class CBatchFtp, as a wrapper for CInternetSession and CFtpConnection. The class has methods to put and get single and multiple files and to check presence of a file in ftp server.

Problem :

A first time call to any of the get/put/seatch methods work fine. Immediately, a call to another method of the CBatchFtp object, fails in CInternetSession->GetFtpConnection API call.

Error Description :

CInternetException->GetErrorMessage = "The handle is invalid" and CInternetException->m_dwError = 6.

Given below is the class and its usage.

// CBatchFTP.h
//

#if !defined(CBatchFTP_h)
#define CBatchFTP_h

#include <afxwin.h>
#include <afxinet.h>

class CBatchFTP
{
public:

      bool ImportFiles(CString FTPServer, CString UserID, CString Password, CString pszLocalPath,  CString pszRemotePath);
      bool ExportFiles(CString FTPServer, CString UserID, CString Password, CString pszFileName,CString pszLocalPath,CString pszRemotePath, bool bDeleteFile = true);
      bool ExportFiles(CString FTPServer, CString UserID, CString Password, CString pszLocalPath,CString pszRemotePath, bool bDeleteFile = true);    
      bool SearchFileInServer(CString FTPServer, CString UserID, CString Password,CString pszFileName, CString pszRemotePath);
      CBatchFTP();
      CBatchFTP(int PortNumber);
    virtual ~CBatchFTP();

protected:


private:

    CInternetSession      m_InetSession;
    CFtpConnection *      m_FTPConnection;
      int                              m_PortNumber;

};

#endif /* CBatchFTP_h */


// CBatchFTP.cpp
//
#include "CBatchFTP.h"

bool CBatchFTP::ImportFiles(CString FTPServer, CString UserID, CString Password, CString pszLocalPath,  CString pszRemotePath)
{
      if (m_FTPConnection)
      {
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }

      try
      {
            m_FTPConnection = m_InetSession.GetFtpConnection(FTPServer,UserID,Password,m_PortNumber,0);
      }
      catch(CInternetException * eInetException)
      {
            char ErrMsg[2001];
            CString sErrMsg;

            memset(ErrMsg,0,2001);
            eInetException->GetErrorMessage(ErrMsg,2000);
            sErrMsg = ErrMsg;
      }

      if (m_FTPConnection)
      {
            CFtpFileFind RemoteFileFind(m_FTPConnection);
            if (! pszRemotePath.IsEmpty()) // If Remote path is not empty
            {
                  if (FALSE  == m_FTPConnection->SetCurrentDirectory(pszRemotePath))
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );

                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::SetCurrentDirectory",
                                                            //" ExportFiles");
                        LocalFree( lpMsgBuf );
                        return false;
                  }
            }

            CString RemoteFileName;
            CString LocalFileName;
            BOOL bFileFound = RemoteFileFind.FindFile();
            while (bFileFound)
            {
                  bFileFound = RemoteFileFind.FindNextFile();
                  if (RemoteFileFind.IsDots() || RemoteFileFind.IsDirectory())
                        continue;
                  LocalFileName = pszLocalPath;
                  RemoteFileName = RemoteFileFind.GetFileName();
                  if (LocalFileName[LocalFileName.GetLength() - 1] != '\\')
                  {
                        LocalFileName += "\\";
                  }
                  LocalFileName += RemoteFileName;
                  BOOL bGetDone = m_FTPConnection->GetFile(RemoteFileName, LocalFileName, 0,
                                                FILE_ATTRIBUTE_ARCHIVE, FTP_TRANSFER_TYPE_ASCII, 1);                  
                  if (FALSE == bGetDone)
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );

                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::GetFile",
                                                            //" ExportFiles");
                        LocalFree( lpMsgBuf );      
                  }
                  else
                  {
                        BOOL bRemoveDone = m_FTPConnection->Remove(RemoteFileName);
                        if (FALSE == bRemoveDone)
                        {
                              LPVOID lpMsgBuf;
                              FormatMessage(
                                    FORMAT_MESSAGE_ALLOCATE_BUFFER |
                                    FORMAT_MESSAGE_FROM_SYSTEM |
                                    FORMAT_MESSAGE_IGNORE_INSERTS,
                                    NULL,
                                    GetLastError(),
                                    MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                                    (LPTSTR) &lpMsgBuf,
                                    0,
                                    NULL
                              );

                              CString ErrorMesg;
                              ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                              //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::Remove",
                                                                  //" ExportFiles");
                              LocalFree( lpMsgBuf );      
                        }
                  }
            }
      }
      else
      {
            LPVOID lpMsgBuf;
            FormatMessage(
                  FORMAT_MESSAGE_ALLOCATE_BUFFER |
                  FORMAT_MESSAGE_FROM_SYSTEM |
                  FORMAT_MESSAGE_IGNORE_INSERTS,
                  NULL,
                  GetLastError(),
                  MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                  (LPTSTR) &lpMsgBuf,
                  0,
                  NULL
            );

            CString ErrorMesg;
            ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
            //oBatchErr.LogBatchError(0, ErrorMesg, "CInternetSession::GetFtpConnection",
                                                //" ExportFiles");
            LocalFree( lpMsgBuf );
            return false;
      }
      
      if (m_FTPConnection)
      {
            m_FTPConnection->Close();
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }
      m_InetSession.Close();
      return true;
}

bool CBatchFTP::ExportFiles(CString FTPServer, CString UserID, CString Password,  CString pszFileName, CString pszLocalPath,CString pszRemotePath, bool bDeleteFile)
{

      if (m_FTPConnection)
      {
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }

      try
      {
            m_FTPConnection = m_InetSession.GetFtpConnection( LPCTSTR(FTPServer),
                                                                                      LPCTSTR(UserID),
                                                                                      LPCTSTR(Password),
                                                                                      m_PortNumber,1);
      }
      catch(CInternetException * eInetException)
      {
            char ErrMsg[2001];
            CString sErrMsg;

            memset(ErrMsg,0,2001);
            eInetException->GetErrorMessage(ErrMsg,2000);
            sErrMsg = ErrMsg;
      }

      if (m_FTPConnection)
      {
            if (! pszRemotePath.IsEmpty()) // If Remote path is not empty
            {
                  if (FALSE  == m_FTPConnection->SetCurrentDirectory(pszRemotePath))
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );

                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::SetCurrentDirectory",
                                                            //" ExportFiles");
                        LocalFree( lpMsgBuf );
                        return false;
                  }
            }
            CString LocalFileName = pszLocalPath;
            if (LocalFileName[LocalFileName.GetLength() - 1] != '\\')
            {
                  LocalFileName += "\\";
            }
            LocalFileName += pszFileName;

            BOOL bGetDone = m_FTPConnection->PutFile(LocalFileName, pszFileName, FTP_TRANSFER_TYPE_ASCII,1);                  
            if (FALSE == bGetDone)
            {
                  LPVOID lpMsgBuf;
                  FormatMessage(
                        FORMAT_MESSAGE_ALLOCATE_BUFFER |
                        FORMAT_MESSAGE_FROM_SYSTEM |
                        FORMAT_MESSAGE_IGNORE_INSERTS,
                        NULL,
                        GetLastError(),
                        MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                        (LPTSTR) &lpMsgBuf,
                        0,
                        NULL
                  );

                  CString ErrorMesg;
                  ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                  //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::PutFile",
                                                      //" ExportFiles");
                  LocalFree( lpMsgBuf );
                  return false;
            }
            else
            {
                  if (bDeleteFile)
                  {
                        BOOL bDeleteDone = ::DeleteFile(LocalFileName);
                        if (FALSE == bDeleteDone)
                        {
                              CString ErrorMesg;
                              ErrorMesg.Format("DeleteFile Failed for : %s", LocalFileName);
                              //oBatchErr.LogBatchError(0, ErrorMesg, "::DeleteFile",
                                                                  //" ExportFiles");
                        }
                  }
            }
      }
      else
      {
            LPVOID lpMsgBuf;
            FormatMessage(
                  FORMAT_MESSAGE_ALLOCATE_BUFFER |
                  FORMAT_MESSAGE_FROM_SYSTEM |
                  FORMAT_MESSAGE_IGNORE_INSERTS,
                  NULL,
                  GetLastError(),
                  MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                  (LPTSTR) &lpMsgBuf,
                  0,
                  NULL
            );
            CString ErrorMesg;
            ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
            //oBatchErr.LogBatchError(0, ErrorMesg, "CInternetSession::GetFtpConnection",
                                                //" ExportFiles");
            LocalFree( lpMsgBuf );
            return false;
      }
      if (m_FTPConnection)
      {
            m_FTPConnection->Close();
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }
      m_InetSession.Close();
      return true;
}

bool CBatchFTP::ExportFiles(CString FTPServer, CString UserID, CString Password, CString pszLocalPath,CString pszRemotePath, bool bDeleteFile)
{
      if (m_FTPConnection)
      {
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }

      try
      {
            m_FTPConnection = m_InetSession.GetFtpConnection(FTPServer,UserID,Password,m_PortNumber,1);
      }
      catch(CInternetException * eInetException)
      {
            char ErrMsg[2001];
            CString sErrMsg;

            memset(ErrMsg,0,2001);
            eInetException->GetErrorMessage(ErrMsg,2000);
            sErrMsg = ErrMsg;
      }

      if (m_FTPConnection)
      {
            if (! pszRemotePath.IsEmpty()) // If Remote path is not empty
            {
                  if (FALSE  == m_FTPConnection->SetCurrentDirectory(pszRemotePath))
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );
                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::SetCurrentDirectory",
                                                            //" ExportFiles");
                        LocalFree( lpMsgBuf );
                        return false;
                  }
            }

            CFileFind      LocalFolderSearch;
            CString LocalFileName, LocalFolderName = pszLocalPath;
            if (LocalFolderName[LocalFolderName.GetLength() - 1] != '\\')
            {
                  LocalFolderName += "\\";
            }
            LocalFolderName += "*.*";

            BOOL bFileFound = LocalFolderSearch.FindFile(LocalFolderName);
            while (bFileFound)
            {
                  bFileFound = LocalFolderSearch.FindNextFile();
                  LocalFileName = LocalFolderSearch.GetFilePath();
                  if (LocalFolderSearch.IsDots() || LocalFolderSearch.IsDirectory())
                        continue;
                  BOOL bGetDone = m_FTPConnection->PutFile(LocalFileName,
                                                                               LocalFolderSearch.GetFileName(),
                                                                               FTP_TRANSFER_TYPE_ASCII,1);
                  if (FALSE == bGetDone)
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );
                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::PutFile",
                                                            //" ExportFiles");
                        LocalFree( lpMsgBuf );
                        return false;
                  }
                  else
                  {
                        if (bDeleteFile)
                        {
                              BOOL bDeleteDone = ::DeleteFile(LocalFileName);
                              if (FALSE == bDeleteDone)
                              {
                                    CString ErrorMesg;
                                    ErrorMesg.Format("DeleteFile Failed for : %s", LocalFileName);
                                    //oBatchErr.LogBatchError(0, ErrorMesg, "::DeleteFile",
                                                                        //" ExportFiles");
                              }
                        }
                  }

            }
      }
      else
      {
            LPVOID lpMsgBuf;
            FormatMessage(
                  FORMAT_MESSAGE_ALLOCATE_BUFFER |
                  FORMAT_MESSAGE_FROM_SYSTEM |
                  FORMAT_MESSAGE_IGNORE_INSERTS,
                  NULL,
                  GetLastError(),
                  MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                  (LPTSTR) &lpMsgBuf,
                  0,
                  NULL
            );
            CString ErrorMesg;
            ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
            //oBatchErr.LogBatchError(0, ErrorMesg, "CInternetSession::GetFtpConnection",
                                                //" ExportFiles");
            LocalFree( lpMsgBuf );
            return false;
      }
      if (m_FTPConnection)
      {
            m_FTPConnection->Close();
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }
      m_InetSession.Close();
      return true;
}

bool CBatchFTP::SearchFileInServer(CString FTPServer, CString UserID, CString Password,CString pszFileName, CString pszRemotePath)
{

      bool bFoundMyFile = false;
      
      if (m_FTPConnection)
      {
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }
      try
      {
            m_FTPConnection = m_InetSession.GetFtpConnection(FTPServer,UserID,Password,m_PortNumber,0);
      }
      catch(CInternetException * eInetException)
      {
            char ErrMsg[2001];
            CString sErrMsg;

            unsigned long ErrCode;

            ErrCode = eInetException->m_dwError;

            memset(ErrMsg,0,2001);
            eInetException->GetErrorMessage(ErrMsg,2000);
            sErrMsg = ErrMsg;
      }

      if (m_FTPConnection)
      {
            CFtpFileFind RemoteFileFind(m_FTPConnection);

            if (! pszRemotePath.IsEmpty()) // If Remote path is not empty
            {
                  if (FALSE  == m_FTPConnection->SetCurrentDirectory(pszRemotePath))
                  {
                        LPVOID lpMsgBuf;
                        FormatMessage(
                              FORMAT_MESSAGE_ALLOCATE_BUFFER |
                              FORMAT_MESSAGE_FROM_SYSTEM |
                              FORMAT_MESSAGE_IGNORE_INSERTS,
                              NULL,
                              GetLastError(),
                              MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                              (LPTSTR) &lpMsgBuf,
                              0,
                              NULL
                        );

                        CString ErrorMesg;
                        ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
                        //oBatchErr.LogBatchError(0, ErrorMesg, "CFTPConnection::SetCurrentDirectory",
                                                            //" SearchFileInServer");
                        LocalFree( lpMsgBuf );
                        return false;
                  }
            }

            CString RemoteFileName;
            BOOL bAnyFileFound = RemoteFileFind.FindFile();
            while (bAnyFileFound)
            {
                  bAnyFileFound = RemoteFileFind.FindNextFile();
                  if (RemoteFileFind.IsDots() || RemoteFileFind.IsDirectory())
                        continue;
                  RemoteFileName = RemoteFileFind.GetFileName();
                  if (RemoteFileName == pszFileName)                  
                  {
                        bFoundMyFile = true;
                        break;
                  }
            }
      }
      else
      {
            LPVOID lpMsgBuf;
            FormatMessage(
                  FORMAT_MESSAGE_ALLOCATE_BUFFER |
                  FORMAT_MESSAGE_FROM_SYSTEM |
                  FORMAT_MESSAGE_IGNORE_INSERTS,
                  NULL,
                  GetLastError(),
                  MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
                  (LPTSTR) &lpMsgBuf,
                  0,
                  NULL
            );

            CString ErrorMesg;
            ErrorMesg.Format("Batch FTP Failed. Error Msg : %s", (LPCTSTR) lpMsgBuf);
            //oBatchErr.LogBatchError(0, ErrorMesg, "CInternetSession::GetFtpConnection",
                                                //" SearchFileInServer");
            LocalFree( lpMsgBuf );
            return false;
      }
      
      if (m_FTPConnection)
      {
            m_FTPConnection->Close();
            delete m_FTPConnection;
            m_FTPConnection = NULL;
      }
      m_InetSession.Close();
      return bFoundMyFile;
}

CBatchFTP::CBatchFTP() : m_InetSession("My Application",
                                                         1,
                                                         INTERNET_OPEN_TYPE_PRECONFIG,
                                                         NULL,
                                       NULL,
                                                         0), m_FTPConnection(NULL),
                                                         m_PortNumber(21)
{
}

CBatchFTP::CBatchFTP(int PortNumber) : m_InetSession("My Application",
                                                         1,
                                                         INTERNET_OPEN_TYPE_PRECONFIG,
                                                         NULL,
                                       NULL,
                                                         0), m_FTPConnection(NULL),
                                                         m_PortNumber(PortNumber)
{
}

CBatchFTP::~CBatchFTP()
{
      if (m_FTPConnection)
      {
            m_FTPConnection->Close();
            delete m_FTPConnection;
      }
      m_InetSession.Close();
}

Call to the CBatchFtp class is as follows.

CBatchFTP MyFtpClient;
bool bWhatHappened = false;

bWhatHappened = batchFTP.ExportFiles(FTPServer, UserID, Pwd, FileName1, LocalPath, RemotePath,false);

if ( bWhatHappened)
{
    bWhatHappened = batchFTP.SearchFileInServer(FTPServer, UserID, Pwd, FileName1, RemotePath);
}

Your answer will be of great help.

Sindbad


0
Comment
Question by:sindbad
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
4 Comments
 
LVL 1

Expert Comment

by:MRNMurthy
ID: 6482828
Hi,

I will go through ur code & I will try recreate the problem & work that. Pls give me some time.

From

MRN Murthy
0
 
LVL 4

Accepted Solution

by:
mandhjo earned 100 total points
ID: 6482837
This may be really simple, but I see that you are closing the m_InetSession variable after you do an operation.  I think you either (1) only want to close that in the destructor of the object that contains it or (2) open the m_InetSession object every time you try to get an FTP connection.

Look into that and let me know how it goes.
0
 

Author Comment

by:sindbad
ID: 6484118

Yes,

"Not" closing the CInternetSession.Close() at the end of each function, did the trick.

Sindbad
0
 
LVL 4

Expert Comment

by:mandhjo
ID: 6487680
I'm always curious with the criteria people use for grades...why a 'C'?
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
repeateFront java challenge 31 95
Define unique primary key 9 95
how to split multiple lines delimiter : 8 119
Bartender label printing - switch on and off graphics 3 75
Introduction: Ownerdraw of the grid button.  A singleton class implentation and usage. Continuing from the fifth article about sudoku.   Open the project in visual studio. Go to the class view – CGridButton should be visible as a class.  R…
Exception Handling is in the core of any application that is able to dignify its name. In this article, I'll guide you through the process of writing a DRY (Don't Repeat Yourself) Exception Handling mechanism, using Aspect Oriented Programming.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
In a recent question (https://www.experts-exchange.com/questions/29004105/Run-AutoHotkey-script-directly-from-Notepad.html) here at Experts Exchange, a member asked how to run an AutoHotkey script (.AHK) directly from Notepad++ (aka NPP). This video…

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question