Solved

Does TTreeNode.Data need to be disposed of?

Posted on 2002-03-25
7
455 Views
Last Modified: 2008-02-26
Hi, I am populating TreeView with File Names and I use
the TTreeNode.Data property to point at strings
containing each File Name's path.

procedure TForm1.GetFiles(tree:TTreeView; pn: TTreeNode; fp:string);
//pn=parent node, fp=folder path, tn=temp node
var sr: TSearchRec;
    ps: ^string;
    tn: TTreeNode;
begin
  AddLastSlash(fp);
  if FindFirst(fp + '*.jpg', faArchive, sr) = 0 then
  begin
    repeat
      if ((sr.Attr and faArchive) = faArchive) then
      begin

        new(ps);
        ps^:= fp + sr.name;
        tn := tree.Items.AddChildObject(pn, sr.Name, ps);

        tn.ImageIndex := 6;
        tn.SelectedIndex := 6;
      end;
    until FindNext(sr) <> 0;
    FindClose(sr);
  end;
end;

My question is:  Do I have to call Dispose(Node.Data)
before I use Node.Delete, Node.DeleteChildren or
Tree.Items.Clear methods?  

I tried it with and without Dispose, there seems to be no
problem either way, so what is the right way?
Thanks
cj
0
Comment
Question by:czechmate
7 Comments
 
LVL 1

Expert Comment

by:Fraction
ID: 6895007
I don't think the dispose memory for node data is done automaticly when you delete a node, but when your application terminates I think it disposes all allocated memory. But a simple way to do this is to add the dispose memory code to the TreeView Deletion event.

procedure TForm1.TreeView1Deletion(Sender: TObject; Node: TTreeNode);
begin
 Dispose(Node.Data);
end;
0
 
LVL 1

Expert Comment

by:Fraction
ID: 6895015
I don't think the dispose memory for node data is done automaticly when you delete a node, but when your application terminates I think it disposes all allocated memory. But a simple way to do this is to add the dispose memory code to the TreeView Deletion event.

procedure TForm1.TreeView1Deletion(Sender: TObject; Node: TTreeNode);
begin
 Dispose(Node.Data);
end;
0
 
LVL 1

Author Comment

by:czechmate
ID: 6895031
Thanks Fraction, I know about this event I've used it.  
The question really is does one have to do it or not :)

Delphi Help says:
When an application is finished using a dynamic variable
created with New, it should dispose of the memory allocated for the variable using the Dispose standard procedure.

I would think that if it is used with parent-less
structures like linked lists than yes.  
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 26

Expert Comment

by:Russell Libby
ID: 6895067

The simple answer is yes.
The Delphi compiler makes no assumptions about the contents held in the the Data property, other than the fact its a pointer. (it could be a pointer to an object,  record type, record type with pointers to allocated memory, etc..). So you, as the programmer, are left with the resposibility of releasing any allocated memory.

Russell
0
 
LVL 1

Expert Comment

by:Fraction
ID: 6895082
I think you can ignore disposing memory, and run your application without any problem for some time, but you can't assume that the user should exit your application frequently just to free memory. If you keep adding and removing nodes to your tree view sooner or later you will run out of memory.
0
 

Accepted Solution

by:
classics earned 50 total points
ID: 6895567
In the destructor for TTreeNode, Data is simply set to Nil without checking its value.  Anything you associate with this pointer should be freed before destroying the node.
0
 
LVL 1

Author Comment

by:czechmate
ID: 6895713
To Classics:
I am going to accept your proposed answer since it looks technically correct.  However, I would like to remind you, it is much more friendy to post your response as a comment and thus give chance to other experts to contribute or voice their opinion.  
Regards
cj
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

The uses clause is one of those things that just tends to grow and grow. Most of the time this is in the main form, as it's from this form that all others are called. If you have a big application (including many forms), the uses clause in the in…
Hello everybody This Article will show you how to validate number with TEdit control, What's the TEdit control? TEdit is a standard Windows edit control on a form, it allows to user to write, read and copy/paste single line of text. Usua…
This tutorial gives a high-level tour of the interface of Marketo (a marketing automation tool to help businesses track and engage prospective customers and drive them to purchase). You will see the main areas including Marketing Activities, Design …
Sending a Secure fax is easy with eFax Corporate (http://www.enterprise.efax.com). First, just open a new email message. In the To field, type your recipient's fax number @efaxsend.com. You can even send a secure international fax — just include t…

895 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now