Solved

Does TTreeNode.Data need to be disposed of?

Posted on 2002-03-25
7
475 Views
Last Modified: 2008-02-26
Hi, I am populating TreeView with File Names and I use
the TTreeNode.Data property to point at strings
containing each File Name's path.

procedure TForm1.GetFiles(tree:TTreeView; pn: TTreeNode; fp:string);
//pn=parent node, fp=folder path, tn=temp node
var sr: TSearchRec;
    ps: ^string;
    tn: TTreeNode;
begin
  AddLastSlash(fp);
  if FindFirst(fp + '*.jpg', faArchive, sr) = 0 then
  begin
    repeat
      if ((sr.Attr and faArchive) = faArchive) then
      begin

        new(ps);
        ps^:= fp + sr.name;
        tn := tree.Items.AddChildObject(pn, sr.Name, ps);

        tn.ImageIndex := 6;
        tn.SelectedIndex := 6;
      end;
    until FindNext(sr) <> 0;
    FindClose(sr);
  end;
end;

My question is:  Do I have to call Dispose(Node.Data)
before I use Node.Delete, Node.DeleteChildren or
Tree.Items.Clear methods?  

I tried it with and without Dispose, there seems to be no
problem either way, so what is the right way?
Thanks
cj
0
Comment
Question by:czechmate
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
7 Comments
 
LVL 1

Expert Comment

by:Fraction
ID: 6895007
I don't think the dispose memory for node data is done automaticly when you delete a node, but when your application terminates I think it disposes all allocated memory. But a simple way to do this is to add the dispose memory code to the TreeView Deletion event.

procedure TForm1.TreeView1Deletion(Sender: TObject; Node: TTreeNode);
begin
 Dispose(Node.Data);
end;
0
 
LVL 1

Expert Comment

by:Fraction
ID: 6895015
I don't think the dispose memory for node data is done automaticly when you delete a node, but when your application terminates I think it disposes all allocated memory. But a simple way to do this is to add the dispose memory code to the TreeView Deletion event.

procedure TForm1.TreeView1Deletion(Sender: TObject; Node: TTreeNode);
begin
 Dispose(Node.Data);
end;
0
 
LVL 1

Author Comment

by:czechmate
ID: 6895031
Thanks Fraction, I know about this event I've used it.  
The question really is does one have to do it or not :)

Delphi Help says:
When an application is finished using a dynamic variable
created with New, it should dispose of the memory allocated for the variable using the Dispose standard procedure.

I would think that if it is used with parent-less
structures like linked lists than yes.  
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 26

Expert Comment

by:Russell Libby
ID: 6895067

The simple answer is yes.
The Delphi compiler makes no assumptions about the contents held in the the Data property, other than the fact its a pointer. (it could be a pointer to an object,  record type, record type with pointers to allocated memory, etc..). So you, as the programmer, are left with the resposibility of releasing any allocated memory.

Russell
0
 
LVL 1

Expert Comment

by:Fraction
ID: 6895082
I think you can ignore disposing memory, and run your application without any problem for some time, but you can't assume that the user should exit your application frequently just to free memory. If you keep adding and removing nodes to your tree view sooner or later you will run out of memory.
0
 

Accepted Solution

by:
classics earned 50 total points
ID: 6895567
In the destructor for TTreeNode, Data is simply set to Nil without checking its value.  Anything you associate with this pointer should be freed before destroying the node.
0
 
LVL 1

Author Comment

by:czechmate
ID: 6895713
To Classics:
I am going to accept your proposed answer since it looks technically correct.  However, I would like to remind you, it is much more friendy to post your response as a comment and thus give chance to other experts to contribute or voice their opinion.  
Regards
cj
0

Featured Post

Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Delphi: making a BW image transparent 10 96
Twebbrowser add css to the header 3 39
Slow Restore if incremental backups using RDiff.exe 4 39
Firemonkey Queue list 1 33
This article explains how to create forms/units independent of other forms/units object names in a delphi project. Have you ever created a form for user input in a Delphi project and then had the need to have that same form in a other Delphi proj…
Have you ever had your Delphi form/application just hanging while waiting for data to load? This is the article to read if you want to learn some things about adding threads for data loading in the background. First, I'll setup a general applica…
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

696 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question