Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Updating MS SQL Server 'bit' field through stored procedure from VB

Posted on 2002-06-18
5
1,064 Views
Last Modified: 2012-06-21
Why doesn't this work?

Using an unchanged and well tested VB routine for 'poking' an SQL Server stored procedure, I have run a new stored procedure that has to update a single 'bit' type field in my database.

VB does not have the 'bit' field type so I pass the 1 or 0 value in a smallint field and convert it within the stored procedure.

The routine and stored procedure run successfully (i.e. without returning any error code) but the field is not updated.

I have checked all of the obvious things (correct database/correct table/ I even ran the stored procedure (with hard coded parameter values) directly through Query Analyzer and it worked fine).

Has anyone come across something similar? Is there a better way of setting a 'bit' value through VB?

Here is my VB routine

The parameters passed are the name of the stored procedure
and a scripting dictionary.

Each entry to the dictionary is another dictionary containing details of the parameter to add (data type, size and value) i.e. A dictionary of dictionaries if you will.

NB it might be easier to copy this code into notepad/vb as it doesn't 'wrap' well in this little window!
 
---------------------------------------------------------
Public Function RunSP(SPName As String, Optional ParmDic) As Long

    Dim var As Variant, lngTemp As Long, Success As Boolean
   
    Set m_cmd = New Command
    With m_cmd
        .Parameters.Append .CreateParameter("RV", adInteger, adParamReturnValue)
        .CommandType = adCmdStoredProc
    End With
   
    'If m_cn Is Nothing Then
        Success = pOpenConnection
    'End If
   
    If Not Success Then Exit Function
   
    With m_cmd
        Set .ActiveConnection = m_cn
        .CommandText = SPName
        If Not IsMissing(ParmDic) Then
            For Each var In ParmDic
                If var = "COMMANDTIMEOUT" Then
                    m_cmd.CommandTimeout = ParmDic.Item(var).Item("Value")
                Else
'                    MsgBox SPName & vbCrLf & var & vbCrLf & ParmDic.Item(var).Item("Value") & vbCrLf & ParmDic.Item(var).Item("DataType") & vbCrLf & ParmDic.Item(var).Item("Size")
                    .Parameters.Append .CreateParameter(var, _
                                                        ParmDic.Item(var).Item("DataType"), _
                                                        adParamInput, _
                                                        ParmDic.Item(var).Item("Size"), _
                                                        ParmDic.Item(var).Item("Value"))
                End If
            Next var
        End If
        .Execute lngTemp
    End With
   
     
    RunSP = m_cmd.Parameters("RV")
   

End Function
----------------------------------------------------------

Here is the stored procedure...
----------------------------------------------------------

CREATE  PROCEDURE [dbo].[fl_Sys_Update_HasSubs_In_Documents_Record]      
            @P_HASSUBS smallint,
     @P_ID int

AS
     DECLARE @HASSUBS bit
     
     IF @P_HASSUBS = 1
          SET @HASSUBS = 1
     ELSE
          SET @HASSUBS = 0

     UPDATE dbo.FLSYS_Documents
     SET HasSubs = @HASSUBS
     WHERE ID = @P_ID


RETURN @@ERROR
GO
----------------------------------------------------------

Cheers,

Gareth
0
Comment
Question by:G_Evans
5 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 200 total points
ID: 7086813
>>VB does not have the 'bit' field type so I pass the 1 or 0 value in a smallint field and convert it within the stored procedure.

Use VB's boolean type, using true and false. I found this working fine...

CHeers
0
 
LVL 7

Expert Comment

by:Nitin Sontakke
ID: 7088397
angelIII, correct me if i am wrong, but you will probably be using it with MS-Access. To the best of my current knowledge, VB true/false won't work with SQL Server as it represent values -1 and 0 respectively, whereas SQL Server will expect 1 and 0.

To test it correctly, i will suggest that PLEASE deviate from the custom procedure which you are calling and code specifically for the this stored proc. JUST FOR TESTING PURPOSE. I am sure it will work. Several times, i have used a bit as parameter for a stored proc and said so while building parameters object, this works fine...

0
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 7089329
Nitin, I used SQL-bit + VB-boolean with ADO, where ADO did the mapping between boolean and bit...
CHeers
0
 
LVL 75

Expert Comment

by:Anthony Perkins
ID: 7091671
As angelIII has stated use the adBoolean datatype.

For this Stored Procedure:
CREATE Procedure sp_test3 @ID int, @BitCol bit

As

Update Table2
Set     BitCol = @BitCol
Where ID = @ID
GO


This VB code worked for me:
Dim cn As ADODB.Connection
Dim cmd As ADODB.Command

' Create connection and command objects
Set cn = New ADODB.Connection
Set cmd = New ADODB.Command

' Set connection properties and open
cn.ConnectionString = "Provider=SQLOLEDB.1;Password="""";Persist Security Info=True;User ID=sa;Initial Catalog=TestDB;Data Source=HOME-SERVER"
cn.Open

' Set command properties
With cmd
   Set .ActiveConnection = cn
   .CommandText = "sp_test3"
   .CommandType = adCmdStoredProc
   ' Define stored procedure params and append to command.
   .Parameters.Append .CreateParameter("@ID", adInteger, adParamInput, 2, 4000)
   .Parameters.Append .CreateParameter("@BitCol", adBoolean, adParamInput, 1, 1)
End With

' Execute the command
cmd.Execute , , adExecuteNoRecords
Set cmd = Nothing

cn.Close
Set cn = Nothing

Anthony
0
 

Author Comment

by:G_Evans
ID: 7103143
Thank you - you were first to suggest the correct answer so the points have to be yours!
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
vb6 programatically bring window to front 8 75
Saving history changes to sub form 4 48
bit defender blocks good applications 2 101
VB 6 error 5 in windows 10 but not in XP 7 63
Introduction While answering a recent question (http://www.experts-exchange.com/Q_27402310.html) in the VB classic zone, I wrote some VB code in the (Office) VBA environment, rather than fire up my older PC.  I didn't post completely correct code o…
This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
Get people started with the process of using Access VBA to control Excel using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Excel. Using automation, an Access application can laun…
Get people started with the utilization of class modules. Class modules can be a powerful tool in Microsoft Access. They allow you to create self-contained objects that encapsulate functionality. They can easily hide the complexity of a process from…

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question