Solved

Insert into SQL table

Posted on 2002-06-20
4
175 Views
Last Modified: 2013-12-24
Hell Experts,

I'm having a little difficulty doing something I've done many times before.  I, currently inserting into a SQL database with 4 fields.  To of them can be null and two can't.  The ICWAEmpID is a number and the other three are text fields.  Below is my SQL and below that is the error I get when I don't put a value into one or both of the not required fields (which can be null).  Any ideas?


My code:
<cfquery name="InsertICWA" datasource="ddssprojdev" dbtype="ODBC">
          INSERT INTO ICWA (Salco, ICWANO, BudgetNo, ICWAEmpID)
          VALUES ('#FORM.Salco#','#FORM.ICWANO#', '#FORM.BudgetNo#', #FORM.SelectOwner#);
          </cfquery>
Error Diagnostic Information
ODBC Error Code = 37000 (Syntax error or access violation)


[Microsoft][ODBC SQL Server Driver][SQL Server]Line 2: Incorrect syntax near ')'.


SQL = "INSERT INTO ICWA (Salco, ICWANO, BudgetNo, ICWAEmpID) VALUES ('333333', '11111', '', )"

Data Source = "DDSSPROJDEV"


The error occurred while processing an element with a general identifier of (CFQUERY), occupying document position (53:3) to (53:68) in the template file I:\WEBSITES\DDSSPM2\UPDATE\ADDICWA_APP.CFM.

0
Comment
Question by:tdenny
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
4 Comments
 
LVL 19

Accepted Solution

by:
cheekycj earned 50 total points
ID: 7097175
this is what you can do:

<cfquery name="InsertICWA" datasource="ddssprojdev" dbtype="ODBC">
         INSERT INTO ICWA (Salco, ICWANO, BudgetNo, ICWAEmpID)
         VALUES ('#FORM.Salco#','#FORM.ICWANO#', '#FORM.BudgetNo#', <cfif IsDefined("FORM.SelectOwner") and LEN(TRIM(FORM.SelectOwnder)) GT 0>#FORM.SelectOwner#<cfelse>null</cfif>)
         </cfquery>


do the same for the other field that allows null.

If that doesn't work use the same type of if then else structure to adjust the query to omit the fields that are null.

CJ
0
 

Author Comment

by:tdenny
ID: 7097310
CJ,

Thanks as always for your response.  I thought there might be some sort of isNull requirement for my SQL statement.  I am sure your suggestions will work.  Your suggestion is certainly better than running two separate queries based on whether or not the field is used.  I will do the same for both of those fields.  I can't wait until I get to the really big table that this application will be inserting recdords into.  

Many thanks
TD
0
 
LVL 19

Expert Comment

by:cheekycj
ID: 7097325
if the query gets too big, I would suggest creating a stored procedure for inserting new rows.  And make all the fields that allow null values optional parameters.

Then you don't need to do the whole query building just use CFStoredProc tag.

also, this approach is probably a better way to manage larger inserts

Thanx for the "A"

CJ
0
 

Author Comment

by:tdenny
ID: 7097348
CJ,

Thanks as always for your response.  I thought there might be some sort of isNull requirement for my SQL statement.  I am sure your suggestions will work.  Your suggestion is certainly better than running two separate queries based on whether or not the field is used.  I will do the same for both of those fields.  I can't wait until I get to the really big table that this application will be inserting recdords into.  

Many thanks
TD
0

Featured Post

Ransomware: The New Cyber Threat & How to Stop It

This infographic explains ransomware, type of malware that blocks access to your files or your systems and holds them hostage until a ransom is paid. It also examines the different types of ransomware and explains what you can do to thwart this sinister online threat.  

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Most ColdFusion developers get confused between the CFSet, Duplicate, and Structcopy methods of copying a Structure, especially which one to use when. This Article will explain the differences in the approaches with examples; therefore, after readin…
What You Need to Know when Searching for a Webhost Provider
This is a high-level webinar that covers the history of enterprise open source database use. It addresses both the advantages companies see in using open source database technologies, as well as the fears and reservations they might have. In this…
There are cases when e.g. an IT administrator wants to have full access and view into selected mailboxes on Exchange server, directly from his own email account in Outlook or Outlook Web Access. This proves useful when for example administrator want…

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question