Solved

problem of toolbar on dialog

Posted on 2002-07-01
10
315 Views
Last Modified: 2013-11-20
Hi,

I have a dialog need to have toolbar on it. I searched the web and found some examples about how to put toolbar on the dialog. And it works.

But I also need to declare the dialog as static. So the first time the dialog is opened, the toolbar on the dialog is okay. But if I close the dialog and opent is again, there will be some error. I know the reason is that the toolbar object already exists and should not be created again. But how can I solve this problem in detail? I tried to destory the toolbar object when the dialog is closed. But I failed. Can anyone help me in this? Thanks!!


0
Comment
Question by:yeshengl
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 4
  • 2
10 Comments
 
LVL 4

Expert Comment

by:mblat
ID: 7123231
One thing you can do is to declare static variable and check for it value

something like this:

in .h
class CMyClass
{
 static bool m_bToolbarAlreadyCreated;
};

in.cpp

bool CMyClass::m_bToolbarAlreadyCreated = false;

in
CMyClass::OnInitDialog()
{
  if(!CMyClass::m_bToolbarAlreadyCreated)
  {
    // create toolbar
    CMyClass::m_bToolbarAlreadyCreated  = true;
  }
}

second thing is of cause to destroy toolbar.  What exactly you need to do to achive that is difficult to say without knowing exactly how you created it....or at least how it fails when you creating dialog second time....  It is likely that you need to call Detach() on you CWnd class that represent dialog....

0
 

Author Comment

by:yeshengl
ID: 7123613
Hi Mblat,

Thank you very much for you help! Here is how I create and use the toolbar. Can you show me how to destroy the toolbar object?

1. When dialog is initialized:
BOOL MyDialog::OnInitDialog()
{
    CDialog::OnInitDialog();
    static bool firstTime = true;
   
    // Set the icon for this dialog.
    SetIcon(AfxGetApp()->LoadIcon(IDI_ICON_LEVEL_PATIENT), FALSE);
   
    // Get the client area before putting in Menu and ToolBar
    CRect rcClientStart, rcClientNow;
    GetClientRect(rcClientStart);


    if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
    {
         TRACE0("Failed to create toolbar\n");
         return -1;      // fail to create
    }

    // Put in ToolBar
    RepositionBars(AFX_IDW_CONTROLBAR_FIRST, AFX_IDW_CONTROLBAR_LAST, 0, reposQuery, rcClientNow);

    // Get the new client area after putting in Menu and ToolBar
    if(firstTime)
    {
         m_iNewClientTop = rcClientNow.top - rcClientStart.top;
         m_iNewClientLeft = rcClientNow.left - rcClientStart.left;
    }
         
    // Move all the controls to be in the same relative position
    // within the remaining client area
    CPoint     ptOffset(m_iNewClientLeft, m_iNewClientTop);
    CRect     rcChild;
    CWnd*     pwndChild = GetWindow(GW_CHILD);
    while (pwndChild)
    {
         pwndChild->GetWindowRect(rcChild);
         ScreenToClient(rcChild);
         rcChild.OffsetRect(ptOffset);
         pwndChild->MoveWindow(rcChild, FALSE);
         pwndChild = pwndChild->GetNextWindow();
    }

    // Adjust the dialog window dimensions
    CRect rcWindow;
    GetWindowRect(rcWindow);
    rcWindow.right += rcClientStart.Width() - rcClientNow.Width();
    rcWindow.bottom += rcClientStart.Height() - rcClientNow.Height();
    MoveWindow(rcWindow, FALSE);

    // And position the control bars
    RepositionBars(AFX_IDW_CONTROLBAR_FIRST, AFX_IDW_CONTROLBAR_LAST, 0);
}

2. Here is how I use the dialog:
void CMyApp::OnFileWorklist()
{
    static MyDialog md;
    md.DoModal();
}

3. Here is how I deletthe toolbar:
void MyDialog::OnClose()
{
  delete m_cToolBar;
  CDialog::OnClose();
}
0
 
LVL 4

Expert Comment

by:mblat
ID: 7123698
I assume that m_cToolBar is class of CToolBar type?

so you should try this:

m_cToolBar.DestroyWindow();


Hope it helps...
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 

Author Comment

by:yeshengl
ID: 7123702
Yes, the m_cToolBar is CToolBar type. I tried m_cToolBar.DestroyWindow(); But when the second time I open the dialog, the following statement will fail.

if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
   {
        TRACE0("Failed to create toolbar\n");
        return -1;      // fail to create
   }

It seems the m_cToolBar object is still not destroyed. Thanks!

0
 
LVL 12

Accepted Solution

by:
migel earned 50 total points
ID: 7123954
Hi!
your problem is that MFC classes do not free HANDLERS during window destroying. So you have invalild Window Handle after toolbar window destroing while MFC class still exist.
Try switch to the dynamic allocation of the ToolBar and destroying its object in the WM_DESTROY dialog handler.
for eample:
CMyDialog::OnInitDialog()
{
    m_pTool = new CToolBar();
    m_pTool->Create(....);
}

CMyDialog::OnDestroy();
{
   m_pTool->DestroyWindow();
   delete m_pTool;
}
0
 
LVL 4

Expert Comment

by:mblat
ID: 7124771
2 migel:
wasn't it my suggestion?

2 yeshengl:

How does it fail?  Try to step into library code as far as possible and tell us the line it is failing at.
0
 
LVL 12

Expert Comment

by:migel
ID: 7125059
not itsn`t
IMHO I use pointers while you use no dynamically allocated class member.
0
 
LVL 4

Expert Comment

by:mblat
ID: 7125383
On BIG question.

I was looking at your code and see that you are using

if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
   


and later

delete m_cToolBar;

It doesn't compute here.  If you are using pointers you should use m_cToolBar->Create

and if not you shoudn't do
delete m_cToolBar.  It's one or the other really.

0
 

Author Comment

by:yeshengl
ID: 7125480
Hi Migel,

Thank you so much for you excellent suggestion! The problem is solved! Yes, I think dynamically allocating class member works in this problem. Thanks!
0
 

Author Comment

by:yeshengl
ID: 7125481
Thank you very much, migel!
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this article, I'll describe -- and show pictures of -- some of the significant additions that have been made available to programmers in the MFC Feature Pack for Visual C++ 2008.  These same feature are in the MFC libraries that come with Visual …
Introduction: Hints for the grid button.  Nested classes, templated collections.  Squash that darned bug! Continuing from the sixth article about sudoku.   Open the project in visual studio. First we will finish with the SUD_SETVALUE messa…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
This video Micro Tutorial shows how to password-protect PDF files with free software. Many software products can do this, such as Adobe Acrobat (but not Adobe Reader), Nuance PaperPort, and Nuance Power PDF, but they are not free products. This vide…

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question