problem of toolbar on dialog

One thing you can do is to declare static variable and check for it value

something like this:

in .h
class CMyClass
{
 static bool m_bToolbarAlreadyCreated;
};

in.cpp

bool CMyClass::m_bToolbarAlreadyCreated = false;

in
CMyClass::OnInitDialog()
{
  if(!CMyClass::m_bToolbarAlreadyCreated)
  {
    // create toolbar
    CMyClass::m_bToolbarAlreadyCreated  = true;
  }
}

second thing is of cause to destroy toolbar.  What exactly you need to do to achive that is difficult to say without knowing exactly how you created it....or at least how it fails when you creating dialog second time....  It is likely that you need to call Detach() on you CWnd class that represent dialog....

Hi Mblat,

Thank you very much for you help! Here is how I create and use the toolbar. Can you show me how to destroy the toolbar object?

1. When dialog is initialized:
BOOL MyDialog::OnInitDialog()
{
    CDialog::OnInitDialog();
    static bool firstTime = true;
   
    // Set the icon for this dialog.
    SetIcon(AfxGetApp()->LoadIcon(IDI_ICON_LEVEL_PATIENT), FALSE);
   
    // Get the client area before putting in Menu and ToolBar
    CRect rcClientStart, rcClientNow;
    GetClientRect(rcClientStart);


    if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
    {
         TRACE0("Failed to create toolbar\n");
         return -1;      // fail to create
    }

    // Put in ToolBar
    RepositionBars(AFX_IDW_CONTROLBAR_FIRST, AFX_IDW_CONTROLBAR_LAST, 0, reposQuery, rcClientNow);

    // Get the new client area after putting in Menu and ToolBar
    if(firstTime)
    {
         m_iNewClientTop = rcClientNow.top - rcClientStart.top;
         m_iNewClientLeft = rcClientNow.left - rcClientStart.left;
    }
         
    // Move all the controls to be in the same relative position
    // within the remaining client area
    CPoint     ptOffset(m_iNewClientLeft, m_iNewClientTop);
    CRect     rcChild;
    CWnd*     pwndChild = GetWindow(GW_CHILD);
    while (pwndChild)
    {
         pwndChild->GetWindowRect(rcChild);
         ScreenToClient(rcChild);
         rcChild.OffsetRect(ptOffset);
         pwndChild->MoveWindow(rcChild, FALSE);
         pwndChild = pwndChild->GetNextWindow();
    }

    // Adjust the dialog window dimensions
    CRect rcWindow;
    GetWindowRect(rcWindow);
    rcWindow.right += rcClientStart.Width() - rcClientNow.Width();
    rcWindow.bottom += rcClientStart.Height() - rcClientNow.Height();
    MoveWindow(rcWindow, FALSE);

    // And position the control bars
    RepositionBars(AFX_IDW_CONTROLBAR_FIRST, AFX_IDW_CONTROLBAR_LAST, 0);
}

2. Here is how I use the dialog:
void CMyApp::OnFileWorklist()
{
    static MyDialog md;
    md.DoModal();
}

3. Here is how I deletthe toolbar:
void MyDialog::OnClose()
{
  delete m_cToolBar;
  CDialog::OnClose();
}

I assume that m_cToolBar is class of CToolBar type?

so you should try this:

m_cToolBar.DestroyWindow();


Hope it helps...

Yes, the m_cToolBar is CToolBar type. I tried m_cToolBar.DestroyWindow(); But when the second time I open the dialog, the following statement will fail.

if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
   {
        TRACE0("Failed to create toolbar\n");
        return -1;      // fail to create
   }

It seems the m_cToolBar object is still not destroyed. Thanks!

2 migel:
wasn't it my suggestion?

2 yeshengl:

How does it fail?  Try to step into library code as far as possible and tell us the line it is failing at.

not itsn`t
IMHO I use pointers while you use no dynamically allocated class member.

On BIG question.

I was looking at your code and see that you are using

if (!m_cToolBar.Create( this ) ||     !m_cToolBar.LoadToolBar(IDR_TOOLBAR_WORKLIST) )
   


and later

delete m_cToolBar;

It doesn't compute here.  If you are using pointers you should use m_cToolBar->Create

and if not you shoudn't do
delete m_cToolBar.  It's one or the other really.

Hi Migel,

Thank you so much for you excellent suggestion! The problem is solved! Yes, I think dynamically allocating class member works in this problem. Thanks!

Thank you very much, migel!