Javis: a small this.getParent() problem. JB 5........

Hiyah!

I have a problem with this snippet of code in JBuilder 5, from the program at (http://cs.baylor.edu/~donahoo/NIUNet/javis.html), its in the Javis.Java file...:

Container parent = this;
               
          while ( !( parent instanceof Frame ) )
               parent = parent.getParent();

          // Create the interface object to draw widgets and handle events.
          try {
               m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );
               // Add the interface to the applet.
               getContentPane().add( m_iface );
               m_run_ok = true;
          }
          catch (Exception e) {
               m_run_ok = false;
               System.err.println( e.getMessage() );
                        System.err.println("Error in Init!!!");
          }

The 'parent = parent.getParent();' bit keeps quitting with a null pointer exception.

What's going on? This code apparently works in other development environments, so why not JB 5?
LVL 1
Lab_RatAsked:
Who is Participating?
 
kylarCommented:
Change your code from this:

while ( !( parent instanceof Frame ) )
              parent = parent.getParent();

to:

while ( ! (( parent instanceof Window) && ( parent instanceof Applet)) )
              parent = parent.getParent();

And that will get you the proper top level window. Alternately you could use SwingUtilities.getWindowAncestor() call. You will also have to modify the constructor:

m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );

To not pass a frame, but instead to pass whatever is proper (perhaps a container).

Cheers,
Kylar
0
 
CEHJCommented:
Well, in the contexts you've seen it working before, you were probably looking at Frame-based stuff. In this  case, you're using an applet, which extends Panel. It *is* a container, hence the assignment:

Container parent = this;

works.

This also works:

while ( !( parent instanceof Frame ) )

as an applet is not an instanceof Frame.

Therefore

parent = parent.getParent();

works. But since the applet does not *have* a parent, you get a null pointer.


0
 
yasser_helmyCommented:
The highest level parent is not a frame. The loop executes until parent is referencing the highest level container. Since this is not a frame, the loop continues once more. But since parent does not have a parent the method getParent() returns null. The loop then continues, but the line:
(parent instanceof Frame)
throws an exception since null cannot be used with the instaceof operator.
0
Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

 
objectsCommented:
> But since the applet does not *have* a parent

Applets can have parents, and generally do.

I guess JBuilder mustn't run the applet in a browser, and instead runs it somehow in it's own container.

The problem is that your loops searches the component hierarchy for an instance of a Frame. If it doesn't find one then when it gets to the top of the tree you'll get an npe. So just change your code to test for null:

while ( parent!=null &&  !(parent instanceof Frame) )
              parent = parent.getParent();

or use:

Frame frame = (Frame) SwingUtilities.getAncestorOfClass(Frame.class, this);
0
 
kylarCommented:
D'Oh.. my code change should be an OR instead of an AND.. change the && to an ||

Cheers
0
 
Lab_RatAuthor Commented:
Thanks to everyone, but especially Kylar and objects!

Not only did you give two answers, one in the original algorithem style, and a new one utilising the API more efficiently, but both examples worked first time, and solved my problem.

Points for Kylar in this answer, and I've posted some points for you too objects on this board.
0
 
yasser_helmyCommented:
Hi all,
i think there is a problem with 'objects' code. the exception will not be thrown but the parent var will still be null. to fix this, use
Container parent = this;
Container son = this;
  while (parent!=null && !(parent instanceof Frame)){
    son = parent;
    parent = parent.getParent();
  }
  //when you get here, parent will either reference a frame or become null
  if(parent ==null)
    parent = son;

0
 
objectsCommented:
> i think there is a problem with 'objects' code

Watch what you're saying :-)

> the exception will not be thrown but the parent var
> will still be null

That's true if an instance of Frame is not found in the component hierarchy. And is desirable, as I am assuming that the SwingInterface ctor expects a Frame instance.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.