Javis: a small this.getParent() problem. JB 5........

Posted on 2002-07-08
Last Modified: 2008-02-26

I have a problem with this snippet of code in JBuilder 5, from the program at (, its in the Javis.Java file...:

Container parent = this;
          while ( !( parent instanceof Frame ) )
               parent = parent.getParent();

          // Create the interface object to draw widgets and handle events.
          try {
               m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );
               // Add the interface to the applet.
               getContentPane().add( m_iface );
               m_run_ok = true;
          catch (Exception e) {
               m_run_ok = false;
               System.err.println( e.getMessage() );
                        System.err.println("Error in Init!!!");

The 'parent = parent.getParent();' bit keeps quitting with a null pointer exception.

What's going on? This code apparently works in other development environments, so why not JB 5?
Question by:Lab_Rat
  • 2
  • 2
  • 2
  • +2
LVL 86

Expert Comment

ID: 7138041
Well, in the contexts you've seen it working before, you were probably looking at Frame-based stuff. In this  case, you're using an applet, which extends Panel. It *is* a container, hence the assignment:

Container parent = this;


This also works:

while ( !( parent instanceof Frame ) )

as an applet is not an instanceof Frame.


parent = parent.getParent();

works. But since the applet does not *have* a parent, you get a null pointer.


Expert Comment

ID: 7138229
The highest level parent is not a frame. The loop executes until parent is referencing the highest level container. Since this is not a frame, the loop continues once more. But since parent does not have a parent the method getParent() returns null. The loop then continues, but the line:
(parent instanceof Frame)
throws an exception since null cannot be used with the instaceof operator.

Accepted Solution

kylar earned 50 total points
ID: 7138493
Change your code from this:

while ( !( parent instanceof Frame ) )
              parent = parent.getParent();


while ( ! (( parent instanceof Window) && ( parent instanceof Applet)) )
              parent = parent.getParent();

And that will get you the proper top level window. Alternately you could use SwingUtilities.getWindowAncestor() call. You will also have to modify the constructor:

m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );

To not pass a frame, but instead to pass whatever is proper (perhaps a container).

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

LVL 92

Expert Comment

ID: 7139122
> But since the applet does not *have* a parent

Applets can have parents, and generally do.

I guess JBuilder mustn't run the applet in a browser, and instead runs it somehow in it's own container.

The problem is that your loops searches the component hierarchy for an instance of a Frame. If it doesn't find one then when it gets to the top of the tree you'll get an npe. So just change your code to test for null:

while ( parent!=null &&  !(parent instanceof Frame) )
              parent = parent.getParent();

or use:

Frame frame = (Frame) SwingUtilities.getAncestorOfClass(Frame.class, this);

Expert Comment

ID: 7139151
D'Oh.. my code change should be an OR instead of an AND.. change the && to an ||


Author Comment

ID: 7140118
Thanks to everyone, but especially Kylar and objects!

Not only did you give two answers, one in the original algorithem style, and a new one utilising the API more efficiently, but both examples worked first time, and solved my problem.

Points for Kylar in this answer, and I've posted some points for you too objects on this board.

Expert Comment

ID: 7140320
Hi all,
i think there is a problem with 'objects' code. the exception will not be thrown but the parent var will still be null. to fix this, use
Container parent = this;
Container son = this;
  while (parent!=null && !(parent instanceof Frame)){
    son = parent;
    parent = parent.getParent();
  //when you get here, parent will either reference a frame or become null
  if(parent ==null)
    parent = son;

LVL 92

Expert Comment

ID: 7140360
> i think there is a problem with 'objects' code

Watch what you're saying :-)

> the exception will not be thrown but the parent var
> will still be null

That's true if an instance of Frame is not found in the component hierarchy. And is desirable, as I am assuming that the SwingInterface ctor expects a Frame instance.

Featured Post

Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
hibernate example using maven 12 78
spring jars download 1 53
jsp insert to database example 2 62
java example issue 5 44
Java Flight Recorder and Java Mission Control together create a complete tool chain to continuously collect low level and detailed runtime information enabling after-the-fact incident analysis. Java Flight Recorder is a profiling and event collectio…
In this post we will learn how to connect and configure Android Device (Smartphone etc.) with Android Studio. After that we will run a simple Hello World Program.
Video by: Michael
Viewers learn about how to reduce the potential repetitiveness of coding in main by developing methods to perform specific tasks for their program. Additionally, objects are introduced for the purpose of learning how to call methods in Java. Define …
The viewer will learn how to implement Singleton Design Pattern in Java.

733 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question