Solved

Javis: a small this.getParent() problem. JB 5........

Posted on 2002-07-08
8
477 Views
Last Modified: 2008-02-26
Hiyah!

I have a problem with this snippet of code in JBuilder 5, from the program at (http://cs.baylor.edu/~donahoo/NIUNet/javis.html), its in the Javis.Java file...:

Container parent = this;
               
          while ( !( parent instanceof Frame ) )
               parent = parent.getParent();

          // Create the interface object to draw widgets and handle events.
          try {
               m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );
               // Add the interface to the applet.
               getContentPane().add( m_iface );
               m_run_ok = true;
          }
          catch (Exception e) {
               m_run_ok = false;
               System.err.println( e.getMessage() );
                        System.err.println("Error in Init!!!");
          }

The 'parent = parent.getParent();' bit keeps quitting with a null pointer exception.

What's going on? This code apparently works in other development environments, so why not JB 5?
0
Comment
Question by:Lab_Rat
  • 2
  • 2
  • 2
  • +2
8 Comments
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
Well, in the contexts you've seen it working before, you were probably looking at Frame-based stuff. In this  case, you're using an applet, which extends Panel. It *is* a container, hence the assignment:

Container parent = this;

works.

This also works:

while ( !( parent instanceof Frame ) )

as an applet is not an instanceof Frame.

Therefore

parent = parent.getParent();

works. But since the applet does not *have* a parent, you get a null pointer.


0
 
LVL 3

Expert Comment

by:yasser_helmy
Comment Utility
The highest level parent is not a frame. The loop executes until parent is referencing the highest level container. Since this is not a frame, the loop continues once more. But since parent does not have a parent the method getParent() returns null. The loop then continues, but the line:
(parent instanceof Frame)
throws an exception since null cannot be used with the instaceof operator.
0
 
LVL 4

Accepted Solution

by:
kylar earned 50 total points
Comment Utility
Change your code from this:

while ( !( parent instanceof Frame ) )
              parent = parent.getParent();

to:

while ( ! (( parent instanceof Window) && ( parent instanceof Applet)) )
              parent = parent.getParent();

And that will get you the proper top level window. Alternately you could use SwingUtilities.getWindowAncestor() call. You will also have to modify the constructor:

m_iface=new SwingInterface( (Frame) parent, getSize(), getCodeBase(), filename );

To not pass a frame, but instead to pass whatever is proper (perhaps a container).

Cheers,
Kylar
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
> But since the applet does not *have* a parent

Applets can have parents, and generally do.

I guess JBuilder mustn't run the applet in a browser, and instead runs it somehow in it's own container.

The problem is that your loops searches the component hierarchy for an instance of a Frame. If it doesn't find one then when it gets to the top of the tree you'll get an npe. So just change your code to test for null:

while ( parent!=null &&  !(parent instanceof Frame) )
              parent = parent.getParent();

or use:

Frame frame = (Frame) SwingUtilities.getAncestorOfClass(Frame.class, this);
0
6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

 
LVL 4

Expert Comment

by:kylar
Comment Utility
D'Oh.. my code change should be an OR instead of an AND.. change the && to an ||

Cheers
0
 
LVL 1

Author Comment

by:Lab_Rat
Comment Utility
Thanks to everyone, but especially Kylar and objects!

Not only did you give two answers, one in the original algorithem style, and a new one utilising the API more efficiently, but both examples worked first time, and solved my problem.

Points for Kylar in this answer, and I've posted some points for you too objects on this board.
0
 
LVL 3

Expert Comment

by:yasser_helmy
Comment Utility
Hi all,
i think there is a problem with 'objects' code. the exception will not be thrown but the parent var will still be null. to fix this, use
Container parent = this;
Container son = this;
  while (parent!=null && !(parent instanceof Frame)){
    son = parent;
    parent = parent.getParent();
  }
  //when you get here, parent will either reference a frame or become null
  if(parent ==null)
    parent = son;

0
 
LVL 92

Expert Comment

by:objects
Comment Utility
> i think there is a problem with 'objects' code

Watch what you're saying :-)

> the exception will not be thrown but the parent var
> will still be null

That's true if an instance of Frame is not found in the component hierarchy. And is desirable, as I am assuming that the SwingInterface ctor expects a Frame instance.
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

For customizing the look of your lightweight component and making it look lucid like it was made of glass. Or: how to make your component more Apple-ish ;) This tip assumes your component to be of rectangular shape and completely opaque. (COD…
For beginner Java programmers or at least those new to the Eclipse IDE, the following tutorial will show some (four) ways in which you can import your Java projects to your Eclipse workbench. Introduction While learning Java can be done with…
This theoretical tutorial explains exceptions, reasons for exceptions, different categories of exception and exception hierarchy.
This tutorial will introduce the viewer to VisualVM for the Java platform application. This video explains an example program and covers the Overview, Monitor, and Heap Dump tabs.

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now