Solved

Option Buttons, a better way?

Posted on 2002-07-11
10
153 Views
Last Modified: 2012-05-04
Say I have these options;

[Frame1]
Private Sub optA_Click()
Private Sub optB_Click()
[Frame2]
Private Sub optC_Click()
Private Sub optD_Click()

Is there a better way to do this?

Private Sub cmdCalc_Click()

If optA Then
    If optC Then
        intM1 = 2.5
        intM2 = 3.5
    Else
        intM1 = 3.5
        intM2 = 4.5
    End If
ElseIf optB Then
    If optC Then
        intM1 = 3
        intM2 = 4
    Else
        intM1 = 4
        intM2 = 5
    End If
End If

This works, but I think theres a better way...
0
Comment
Question by:mgfranz
10 Comments
 
LVL 142

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 7148484
Try this:

[Form code]
Private mintBase as integer
Private mintOffset as integer

Private Sub Form_Load()
  'to force the good values
  optB.Value = true
  optD.Value = true

  optA.Value = true
  optC.Value = true
End Sub

Private Sub optA_Click()
  mintBase = 2,5
End Sub

Private Sub optB_Click()
  mintBase = 3
End Sub

Private Sub optC_Click()
  mintOffset = 0
End Sub

Private Sub optD_Click()
  mintOffset = 1
End Sub

Private Sub cmdCalc_Click()
  intM1 = mintBase + mintOffset
  intM2 = intM1 + 1
End Sub

CHeers
0
 
LVL 4

Accepted Solution

by:
TigerZhao earned 50 total points
ID: 7148642
Private mvValue1 As Variant
Private mvValue2 As Variant

Private Sub Form_Load()
    mvValue1 = Array(2.5, 3.5, 3, 4)
    mvValue2 = Array(3.5, 4.5, 4, 5)
End Sub

Private Sub cmdCalc_Click()
    Dim I As Long
    I = IIf(optA.Value, 0, 2) + IIf(optC.Value, 0, 1)

    intM1 = mvValue1(I)
    intM2 = mvVAlue2(I)
End Sub
0
 
LVL 22

Expert Comment

by:rspahitz
ID: 7149579
If you'll be expanding this list, throw everything into a database.

The table will be a two-part key like this:

tblMValue
=========
KeyAB (integer)
KeyCD (integer)
MValue1 (double)
MValue2 (double)

Records:
KeyAB  KeyCD  MValue1  MValue2
0 (A)  0 (C)  2.5      3.5
0 (A)  1 (D)  3.5      4.5
1 (B)  0 (C)  3        4
1 (B)  1 (D)  4        5

Query:
SELECT MValue1, MValue2 FROM tblMValue WHERE KeyAB = (#1) AND KeyCD = (#2)

#1 and #2 are values extracted from your option buttons, which could be control arrays that have their index=the table key.

Then:
rstMValue.Open strSQL
if rstMValue.EOF then
   msgbox "couldn't find combination"
else
   intM1 = rstMValue.Fields("MValue1").Value
   intM2 = rstMValue.Fields("MValue2").Value
endif
rstMValue.close
0
 
LVL 18

Author Comment

by:mgfranz
ID: 7149605
Not really a dB issue... but a good suggestion.

Angelll you pretty much had the idea I was trying to work with, but Tiger has what would probably be a more efficient solution.

Let me try them both and do an analysis.
0
 
LVL 18

Author Comment

by:mgfranz
ID: 7150233
OK... Same scenario, different values for M2 if optA or optB selected;

If optA Then
   If optC Then
       intM1 = 2.5
       intM2 = 4
   Else
       intM1 = 3.5
       intM2 = 5
   End If
ElseIf optB Then
   If optC Then
       intM1 = 3
       intM2 = 4
   Else
       intM1 = 4
       intM2 = 5
   End If
End If

So in other words, M2 is going to be either 4 or 5.

This works, but it looks redundant on mvValue2;

Private Sub Form_Load()
   mvValue1 = Array(2.5, 3.5, 3, 4)
   mvValue2 = Array(4, 5, 4, 5)
End Sub

Private Sub cmdCalc_Click()
   Dim I As Long
   I = IIf(optA.Value, 0, 2) + IIf(optC.Value, 0, 1)

   intM1 = mvValue1(I)
   intM2 = mvVAlue2(I)
End Sub

0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 22

Expert Comment

by:rspahitz
ID: 7150243
It may seem redundant, but unless you can guarantee that those values will always be the same, it's worth keeping it this way.  The processing time is so minimal that it doesn't hurt to keep it.
0
 
LVL 18

Author Comment

by:mgfranz
ID: 7150252
I'm told they will, and I agree... the footprint for the array is so small anyway.  But just the same, is there a way around it?
0
 
LVL 22

Expert Comment

by:rspahitz
ID: 7150258
One simple way is to modify the two lines to appear as follows:

 mvValue2 = Array(4, 5)


  intM2 = mvVAlue2(I mod 2)
0
 
LVL 18

Author Comment

by:mgfranz
ID: 7150267
This worked excellent.

rspahitz, I'll throw you a bone too.  ;-)
0
 
LVL 22

Expert Comment

by:rspahitz
ID: 7150275
That wasn't necessary, but thanks.

I see it at http://www.experts-exchange.com/visualbasic/Q_20322798.html
0

Featured Post

Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

Join & Write a Comment

I’ve seen a number of people looking for examples of how to access web services from VB6.  I’ve been using a test harness I built in VB6 (using many resources I found online) that I use for small projects to work out how to communicate with web serv…
Since upgrading to Office 2013 or higher installing the Smart Indenter addin will fail. This article will explain how to install it so it will work regardless of the Office version installed.
Get people started with the process of using Access VBA to control Outlook using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Microsoft Outlook. Using automation, an Access applic…
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now