Updating A Table

Posted on 2002-07-19
Last Modified: 2010-05-02
It has been a long time since I have done any VB so and I know you people can get me going faster than I can do this myself.

I have the following code which is opening a table and putting records inside of it.  The end goal of my program is to read a spreadsheet and insert all the rows in the spreadsheet into the table.  My concern with the following code is that it is opening up the entire table of records and returning them.  This isn't a big problem off the start but as they gets to be thousands of records this could be a problem.  My question is am I right in thinking I have a problem.   If I do how do I fix it so that I am not returning all the records but I can still update the table.   There is no need to ever have any records in the recordset or if there was I would have all the records for a specific load which is recalled by a key in the table.

Set RSOpt= New ADODB.Recordset
RSOpt.CursorType = adOpenKeyset
RSOpt.LockType = adLockBatchOptimistic
RSOpt.Open "my_table", "connection_string", , , adCmdTable

RSOpt(1).Value = 1
RSOpt(2).Value = 4
RSOpt(3).Value = 1
RSOpt(4).Value = 1000


Question by:curtis591
LVL 14

Accepted Solution

ajexpert earned 100 total points
ID: 7165200
  Well you can write the select statement in RSOpt.Open

dim strSql as string
strSql = "Select * from my_table"

Modify strSql so that select statement should return 0 records

ie if you are using SQL Server then

strSql = "select top 0 from my_table"

This returns 0 records but still opens the recordset

RSOpt.Open strSql, "connection_string", , , adCmdTable

RSOpt(1).Value = 1
RSOpt(2).Value = 4
RSOpt(3).Value = 1
RSOpt(4).Value = 1000

LVL 44

Expert Comment

ID: 7165239
If you are ONLY inserting new records, then the MUCH better approach is to use the EXECUTE method of the connection object, and NOT OPEN a recordset at all:

dim Conn as ADO.Connection
Conn.ConnectionString = "Connection_String"
Conn.Execute "INSERT INTO My_Table (FieldName1, FieldName2,FieldName3,FieldName4) VALUES(1,4,1,1000)"

if the values to be inserted are Variables, then:

Conn.Execute "INSERT INTO My_Table (FieldName1, FieldName2,FieldName3,FieldName4) VALUES(" & Value1 & "," & Value2 & "," & Value3 & "," & Value4 & ")"

Arthur Wood

Expert Comment

ID: 7165242
Alternatively you can use a SQL statement which is going to run faster...

Dim sSQL as string
Dim objConn as ADODB.Connection

'Open the connection using a connection string

sSQL = "INSERT INTO MyTable (Field1,Field2,Field3,Field4) VALUES(1,4,1,1000)"

objConn.Execute sSQL

LVL 44

Expert Comment

ID: 7165252
alternatively, if you feel that you MUST use a recordset :

RSOpt.Open "Select * from my_table where PK = 0", "connection_string", ,adLockOptimistic

RSOpt(1).Value = 1
RSOpt(2).Value = 4
RSOpt(3).Value = 1
RSOpt(4).Value = 1000


here PK is the NAME of the FIELD which is the PrimaryKey of the Table (and you would assign a VALUE (indicated here with 0) that IS NOT present in the table.  This will create a recordset, with NO records, but will ALL of the fields defined.  Be sure to use the proper LOCK parameter (adLockOptimistic).

Author Comment

ID: 7165256
My spreadsheet has in the neighboorhood of 200 columns that will be changed and I think the code requires will require fewer changes with field names by referencing them by number rather than field names and I don't have to worry about commas and other characters causing me problems in trying to make the sql string.

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Reading the Contents of a Directory In Access VBA 5 76
Access query that references subform 5 47
Dinamic report to Crosstab query 9 33
transition to visual .net from vb6 5 37
Introduction While answering a recent question about filtering a custom class collection, I realized that this could be accomplished with very little code by using the ScriptControl (SC) library.  This article will introduce you to the SC library a…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Get people started with the process of using Access VBA to control Outlook using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Microsoft Outlook. Using automation, an Access applic…
Get people started with the utilization of class modules. Class modules can be a powerful tool in Microsoft Access. They allow you to create self-contained objects that encapsulate functionality. They can easily hide the complexity of a process from…

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question