Solved

slow subquery

Posted on 2002-07-20
4
620 Views
Last Modified: 2008-03-06
I am no expert so this is probably embarrassingly easy for you experts out there but why is this simple 1st statement so much quicker than the simple 2nd (with subquery)?

1st:

DECLARE @tmpDueDate datetime
SET @tmpDueDate = 7/18/2002
DECLARE @PolicyID int
SET @PolicyID = 20
DECLARE @AccountID int

SELECT @AccountID = (SELECT  top 1 AccountID FROM tblAccounts
          WHERE DueDate > @tmpDueDate AND PolicyID = @PolicyID
          AND (TransactionTypeID = 1 or transactiontypeid = 19)  
          AND TransactionStatusID <> 2 and TransactionstatusID <> 4
          AND Contra = 0 And paymentmethodid = 1 ORDER BY DueDate)

          UPDATE tblAccounts SET TransactionStatusID = 1
          WHERE AccountID = @AccountID
2nd:

DECLARE @tmpDueDate datetime
SET @tmpDueDate = 7/18/2002
DECLARE @PolicyID int
SET @PolicyID = 20
DECLARE @AccountID int

UPDATE tblAccounts SET TransactionStatusID = 1
          WHERE AccountID = (SELECT top 1 AccountID FROM tblAccounts
          WHERE DueDate > @tmpDueDate AND PolicyID = @PolicyID
          AND (TransactionTypeID = 1 or transactiontypeid = 19)  
          AND TransactionStatusID <> 2 and TransactionstatusID <> 4
          AND Contra = 0 And paymentmethodid = 1 ORDER BY DueDate)


tblAccounts is indexed on PolicyID, AccountID AND DueDate and contains c. 3 million rows. 1st takes 1 second, 2nd takes 150 seconds, both to do 1 update! For 2nd, estimated execution plan shows 34% of query taken up with Hash Match/Inner Join (whatever they are! - all rows read) and 25% with a sort.
0
Comment
Question by:dlisk
  • 3
4 Comments
 
LVL 1

Accepted Solution

by:
tnewc59 earned 100 total points
Comment Utility
The second example will require a full table scan.

This is because it will look at the tblAccounts table, one record at a time to see if the row matches on AccountID.

The first method is executing the update for only a single accountid.  So the tblAccounts does not need to be scanned for each match.
0
 
LVL 1

Expert Comment

by:tnewc59
Comment Utility
The following select operation will experience the same problem:

SELECT myTable.Column1, myTable.Column2
FROM myTable
WHERE myTable.Column1 IN (
      SELECT mySecondTable.Column1
      FROM mySecondTable
      WHERE mySecondTable.Column2 < 1000)

This same query could be re-written more efficiently as:
SELECT myTable.Column1, myTable.Column2
FROM myTable INNER JOIN
      (
      SELECT mySecondTable.Column1
      FROM mySecondTable
      WHERE mySecondTable.Column2 < 1000
      ) as mySubQueryTable on myTable.Column1 = mySubQueryTable.Column1


The second is more efficient as the sub query will be executed and assembled only once, but the first example will require the query to be executed 'x' times.  Where 'x' is equal to the number of rows in myTable.

This is the same concept that is slowing down your second update.
0
 
LVL 1

Expert Comment

by:tnewc59
Comment Utility
The sort time is the time it takes to execute the 'order by' portion of the query.

The problem with using a 'top' with an order by is that your query will not return until the full result set is ordered on the 'order by'.  

When possible, I try to write my queries that utilize 'top' without an 'order by' clause.
0
 

Author Comment

by:dlisk
Comment Utility
Thanx for your time tnewc59.
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

When you hear the word proxy, you may become apprehensive. This article will help you to understand Proxy and when it is useful. Let's talk Proxy for SQL Server. (Not in terms of Internet access.) Typically, you'll run into this type of problem w…
Load balancing is the method of dividing the total amount of work performed by one computer between two or more computers. Its aim is to get more work done in the same amount of time, ensuring that all the users get served faster.
This video shows how to set up a shell script to accept a positional parameter when called, pass that to a SQL script, accept the output from the statement back and then manipulate it in the Shell.
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now